feat(Techdocs) fix the annotations

Signed-off-by: jrwpatterson <jrwpatterson@gmail.com>

plugins/catalog/src/components/AboutCard/AboutCard.tsx

@@ -61,6 +61,10 @@ import EditIcon from '@material-ui/icons/Edit';
 import { isTemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
 import { parseEntityRef } from '@backstage/catalog-model';
 
+const TECHDOCS_ANNOTATION = 'backstage.io/techdocs-ref';
+
+const TECHDOCS_EXTERNAL_ANNOTATION = 'backstage.io/techdocs-entity';
+
 const useStyles = makeStyles({
   gridItemCard: {
     display: 'flex',
@@ -114,10 +118,10 @@ export function AboutCard(props: AboutCardProps) {
 
   let techdocsRef: CompoundEntityRef | undefined;
 
-  if (entity.metadata.annotations?.['backstage.io/techdocs-entity']) {
+  if (entity.metadata.annotations?.[TECHDOCS_EXTERNAL_ANNOTATION]) {
     try {
       techdocsRef = parseEntityRef(
-        entity.metadata.annotations?.['backstage.io/techdocs-entity'],
+        entity.metadata.annotations?.[TECHDOCS_EXTERNAL_ANNOTATION],
       );
       // not a fan of this but we don't care if the parseEntityRef fails
     } catch {
@@ -135,8 +139,8 @@ export function AboutCard(props: AboutCardProps) {
     label: 'View TechDocs',
     disabled:
       !(
-        entity.metadata.annotations?.['backstage.io/techdocs-ref'] ||
-        entity.metadata.annotations?.['backstage.io/techdocs-entity']
+        entity.metadata.annotations?.[TECHDOCS_ANNOTATION] ||
+        entity.metadata.annotations?.[TECHDOCS_EXTERNAL_ANNOTATION]
       ) || !viewTechdocLink,
     icon: <DocsIcon />,
     href:

plugins/techdocs/src/EntityPageDocs.tsx

@@ -25,15 +25,17 @@ import { TechDocsReaderPage } from './plugin';
 import { TechDocsReaderPageContent } from './reader/components/TechDocsReaderPageContent';
 import { TechDocsReaderPageSubheader } from './reader/components/TechDocsReaderPageSubheader';
 
+const TECHDOCS_EXTERNAL_ANNOTATION = 'backstage.io/techdocs-entity';
+
 type EntityPageDocsProps = { entity: Entity };
 
 export const EntityPageDocs = ({ entity }: EntityPageDocsProps) => {
   let entityRef = getCompoundEntityRef(entity);
 
-  if (entity.metadata.annotations?.['backstage.io/techdocs-entity']) {
+  if (entity.metadata.annotations?.[TECHDOCS_EXTERNAL_ANNOTATION]) {
     try {
       entityRef = parseEntityRef(
-        entity.metadata.annotations?.['backstage.io/techdocs-entity'],
+        entity.metadata.annotations?.[TECHDOCS_EXTERNAL_ANNOTATION],
       );
     } catch {
       // not a fan of this but we don't care if the parseEntityRef fails

plugins/techdocs/src/Router.tsx

@@ -84,7 +84,7 @@ export const EmbeddedDocsRouter = (props: PropsWithChildren<{}>) => {
   if (!projectId) {
     return (
       <MissingAnnotationEmptyState
-        annotation={[TECHDOCS_ANNOTATION, TECHDOCS_EXTERNAL_ANNOTATION]}
+        annotation={[TECHDOCS_ANNOTATION]}
       />
     );
   }