From 0389801062bde0c4a87f9ba0e3393baa275e2a67 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sun, 25 Aug 2024 11:09:37 +0200 Subject: [PATCH] signals-react: fix isSignalsAvailable Signed-off-by: Patrik Oldsberg --- .changeset/tricky-apricots-film.md | 5 +++++ plugins/signals-react/src/hooks/useSignal.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/tricky-apricots-film.md diff --git a/.changeset/tricky-apricots-film.md b/.changeset/tricky-apricots-film.md new file mode 100644 index 0000000000..7b1c28fdb9 --- /dev/null +++ b/.changeset/tricky-apricots-film.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-signals-react': patch +--- + +Fix for `useSignal` returning the inverse value for `isSignalsAvailable`. diff --git a/plugins/signals-react/src/hooks/useSignal.ts b/plugins/signals-react/src/hooks/useSignal.ts index 6fb0f4696f..dcf86ca25c 100644 --- a/plugins/signals-react/src/hooks/useSignal.ts +++ b/plugins/signals-react/src/hooks/useSignal.ts @@ -46,7 +46,7 @@ export const useSignal = ( }, [signals, channel]); // Can be used to fallback (for example to long polling) if signals are not available in the system - const isSignalsAvailable = useMemo(() => !signals, [signals]); + const isSignalsAvailable = useMemo(() => !!signals, [signals]); return { lastSignal, isSignalsAvailable }; };