Merge pull request #15615 from backstage/rugvip/cleanlog

Avoid directly logging error objects

plugins/catalog-backend-module-aws/src/providers/AwsS3EntityProvider.ts

@@ -131,7 +131,7 @@ export class AwsS3EntityProvider implements EntityProvider {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-azure/src/providers/AzureDevOpsEntityProvider.ts

@@ -113,7 +113,7 @@ export class AzureDevOpsEntityProvider implements EntityProvider {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-bitbucket-cloud/src/BitbucketCloudEntityProvider.ts

@@ -152,7 +152,7 @@ export class BitbucketCloudEntityProvider
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-bitbucket-server/src/providers/BitbucketServerEntityProvider.ts

@@ -130,7 +130,7 @@ export class BitbucketServerEntityProvider implements EntityProvider {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-gerrit/src/providers/GerritEntityProvider.ts

@@ -129,7 +129,7 @@ export class GerritEntityProvider implements EntityProvider {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-github/src/providers/GithubEntityProvider.ts

@@ -157,7 +157,7 @@ export class GithubEntityProvider implements EntityProvider, EventSubscriber {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-github/src/providers/GithubOrgEntityProvider.ts

@@ -565,7 +565,7 @@ export class GithubOrgEntityProvider
           try {
             await this.read({ logger });
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-gitlab/src/providers/GitlabDiscoveryEntityProvider.ts

@@ -133,7 +133,7 @@ export class GitlabDiscoveryEntityProvider implements EntityProvider {
           try {
             await this.refresh(logger);
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-incremental-ingestion/src/engine/IncrementalIngestionEngine.ts

@@ -111,7 +111,10 @@ export class IncrementalIngestionEngine implements IterationEngine {
               );
 
               const backoffLength = currentBackoff.as('milliseconds');
-              this.options.logger.error(error);
+              this.options.logger.error(
+                `incremental-engine: Ingestion '${ingestionId}' failed`,
+                error,
+              );
 
               const truncatedError = stringifyError(error).substring(0, 700);
               this.options.logger.error(

plugins/catalog-backend-module-ldap/src/processors/LdapOrgEntityProvider.ts

@@ -225,7 +225,7 @@ export class LdapOrgEntityProvider implements EntityProvider {
           try {
             await this.read({ logger });
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/catalog-backend-module-msgraph/src/processors/MicrosoftGraphOrgEntityProvider.ts

@@ -351,7 +351,7 @@ export class MicrosoftGraphOrgEntityProvider implements EntityProvider {
           try {
             await this.read({ logger });
           } catch (error) {
-            logger.error(error);
+            logger.error(`${this.getProviderName()} refresh failed`, error);
           }
         },
       });

plugins/events-backend-module-aws-sqs/src/publisher/AwsSqsConsumingEventPublisher.ts

@@ -100,7 +100,7 @@ export class AwsSqsConsumingEventPublisher implements EventPublisher {
             await this.sleep(this.waitTimeAfterEmptyReceiveMs);
           }
         } catch (error) {
-          logger.error(error);
+          logger.error('Failed to consume AWS SQS messages', error);
         }
       },
     });