Code review updates

Signed-off-by: Eric Voshall <6836155+ericvoshall@users.noreply.github.com>
2022-05-11 14:29:05 -04:00
parent 64e83f3cb6
commit 1f70704580
5 changed files with 26 additions and 8 deletions
@@ -0,0 +1,8 @@
+---
+'@backstage/plugin-catalog-react': minor
+---
+
+Accessibility updates:
+
+- Wrapped the `EntityLifecyclePicker`, `EntityOwnerPicker`, `EntityTagPicker`, in `label` elements
+- Changed group name `Typography` component to `span` (from default `h6`), added `aria-label` to the `List` component, and `role` of `menuitem` to the container of the `MenuItem` component
@@ -0,0 +1,7 @@
+---
+'@backstage/create-app': minor
+---
+
+Accessibility updates:
+
+- Added `aria-label` to the sidebar Logo link
@@ -0,0 +1,7 @@
+---
+'@backstage/plugin-catalog': minor
+---
+
+Accessibility updates:
+
+- Added screen reader elements to describe default table `Action` buttons
@@ -1,13 +1,8 @@
 ---
-'@backstage/core-components': minor
-'@backstage/plugin-catalog': minor
-'@backstage/plugin-catalog-react': minor
+'@backstage/core-components': patch
 ---

 Accessibility updates:

- Added `aria-label` to the `Select` component in `core-components`
- Changed heading level used in the header of `Table` component in `core-components`
- Added screen reader elements to describe default table `Action` buttons in `plugin-catalog`
- Wrapped the `EntityLifecyclePicker`, `EntityOwnerPicker`, `EntityTagPicker`, in `label` elements in `plugin-catalog-react`
- Changed group name `Typography` component to `span` (from default `h6`), added `aria-label` to the `List` component, and `role` of `menuitem` to the container of the `MenuItem` component in `plugin-catalog-react`
+- Added `aria-label` to the `Select` component
+- Changed heading level used in the header of `Table` component
@@ -69,6 +69,7 @@ const SidebarLogo = () => {
        to="/"
        underline="none"
        className={classes.link}
+        aria-label="Home"
      >
        {isOpen ? <LogoFull /> : <LogoIcon />}
      </Link>