Kubernetes react -> Warning: validateDOMNesting(...): <ul> cannot appear as a descendant of <p> (#25559)

* fix html markup in FixDialog

Signed-off-by: sebalaini <sebastianolaini@gmail.com>

* Update .changeset/short-impalas-suffer.md

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Seba <17096352+sebalaini@users.noreply.github.com>

---------

Signed-off-by: sebalaini <sebastianolaini@gmail.com>
Signed-off-by: Seba <17096352+sebalaini@users.noreply.github.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
This commit is contained in:
Seba
2024-07-10 14:28:50 +02:00
committed by GitHub
parent 0eb075b85c
commit 2414d86668
2 changed files with 16 additions and 11 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-kubernetes-react': patch
---
Fix the `HTML` markup of the `FixDialog` component, `ul` and `li` are not allowed inside a `p` tag.
@@ -33,6 +33,8 @@ import { DetectedError } from '@backstage/plugin-kubernetes-common';
import { PodLogs } from '../PodLogs';
import { Events } from '../Events';
import { LinkButton } from '@backstage/core-components';
import List from '@material-ui/core/List';
import ListItem from '@material-ui/core/ListItem';
const useStyles = makeStyles((theme: Theme) =>
createStyles({
@@ -96,17 +98,15 @@ export const FixDialog: React.FC<FixDialogProps> = ({
</Grid>
<Grid item xs={12}>
<Typography variant="h6">Fix:</Typography>
<Typography>
<ul>
{(error.proposedFix?.actions ?? []).map((fix, i) => {
return (
<li key={`${pod.metadata?.name ?? 'unknown'}-pf-${i}`}>
{fix}
</li>
);
})}
</ul>
</Typography>
<List>
{(error.proposedFix?.actions ?? []).map((fix, i) => {
return (
<ListItem key={`${pod.metadata?.name ?? 'unknown'}-pf-${i}`}>
{fix}
</ListItem>
);
})}
</List>
</Grid>
{pf && pf.type === 'logs' && (