Add filter param to MyGroupsSidebarItem

Signed-off-by: kielosz <kielosz@gmail.com>
This commit is contained in:
kielosz
2022-06-01 12:21:01 +02:00
parent bd671d0696
commit 306d0b4fdd
3 changed files with 102 additions and 2 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-org': patch
---
Added the ability to use an additional `filter` when fetching groups in `MyGroupsSidebarItem` component
@@ -196,4 +196,92 @@ describe('MyGroupsSidebarItem Test', () => {
expect(rendered.getByLabelText('My Squads')).toBeInTheDocument();
});
});
describe('When an additional filter is not provided', () => {
it('catalogApi.getEntities() should be called with the default filter', async () => {
const identityApi: Partial<IdentityApi> = {
getBackstageIdentity: async () => ({
type: 'user',
userEntityRef: 'user:default/guest',
ownershipEntityRefs: ['user:default/guest'],
}),
};
const mockCatalogApi: Partial<CatalogApi> = {
getEntities: jest.fn(),
};
await renderInTestApp(
<TestApiProvider
apis={[
[identityApiRef, identityApi],
[catalogApiRef, mockCatalogApi],
]}
>
<MyGroupsSidebarItem
singularTitle="My Squad"
pluralTitle="My Squads"
icon={GroupIcon}
/>
</TestApiProvider>,
{
mountedRoutes: {
'/catalog/:namespace/:kind/:name': entityRouteRef,
},
},
);
expect(mockCatalogApi.getEntities).toHaveBeenCalledWith({
filter: [
{
kind: 'group',
'relations.hasMember': 'user:default/guest',
},
],
fields: ['metadata', 'kind'],
});
});
});
describe('When an additional filter is provided', () => {
it('catalogApi.getEntities() should be called with an additional filter item', async () => {
const identityApi: Partial<IdentityApi> = {
getBackstageIdentity: async () => ({
type: 'user',
userEntityRef: 'user:default/guest',
ownershipEntityRefs: ['user:default/guest'],
}),
};
const mockCatalogApi: Partial<CatalogApi> = {
getEntities: jest.fn(),
};
await renderInTestApp(
<TestApiProvider
apis={[
[identityApiRef, identityApi],
[catalogApiRef, mockCatalogApi],
]}
>
<MyGroupsSidebarItem
singularTitle="My Squad"
pluralTitle="My Squads"
icon={GroupIcon}
filter={{ 'spec.type': 'team' }}
/>
</TestApiProvider>,
{
mountedRoutes: {
'/catalog/:namespace/:kind/:name': entityRouteRef,
},
},
);
expect(mockCatalogApi.getEntities).toHaveBeenCalledWith({
filter: [
{
kind: 'group',
'relations.hasMember': 'user:default/guest',
'spec.type': 'team',
},
],
fields: ['metadata', 'kind'],
});
});
});
});
@@ -45,8 +45,9 @@ export const MyGroupsSidebarItem = (props: {
singularTitle: string;
pluralTitle: string;
icon: IconComponent;
filter?: Record<string, string | symbol | (string | symbol)[]>;
}) => {
const { singularTitle, pluralTitle, icon } = props;
const { singularTitle, pluralTitle, icon, filter } = props;
const identityApi = useApi(identityApiRef);
const catalogApi: CatalogApi = useApi(catalogApiRef);
@@ -56,7 +57,13 @@ export const MyGroupsSidebarItem = (props: {
const profile = await identityApi.getBackstageIdentity();
const response = await catalogApi.getEntities({
filter: [{ kind: 'group', 'relations.hasMember': profile.userEntityRef }],
filter: [
{
kind: 'group',
'relations.hasMember': profile.userEntityRef,
...(filter ?? {}),
},
],
fields: ['metadata', 'kind'],
});