From 378784ebf07b5bab00f1924ea6bf97a10eeeda17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Wed, 27 May 2026 14:51:28 +0200 Subject: [PATCH] fix: restore runtime dependencies incorrectly demoted to devDependencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #33936 removed duplicate dependency entries, but in two cases moved deps from dependencies to devDependencies that are still re-exported in the published API reports: - @backstage/catalog-client: @backstage/plugin-catalog-common (AnalyzeLocationRequest/AnalyzeLocationResponse types) - @backstage/frontend-plugin-api: @backstage/config (Config type) These need to be runtime dependencies so consumers can resolve the types at build time. Co-Authored-By: Claude Opus 4.6 (1M context) Signed-off-by: Fredrik Adelöw --- .changeset/fix-missing-runtime-deps.md | 6 ++++++ packages/catalog-client/package.json | 2 +- packages/frontend-plugin-api/package.json | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/fix-missing-runtime-deps.md diff --git a/.changeset/fix-missing-runtime-deps.md b/.changeset/fix-missing-runtime-deps.md new file mode 100644 index 0000000000..0206424cdc --- /dev/null +++ b/.changeset/fix-missing-runtime-deps.md @@ -0,0 +1,6 @@ +--- +'@backstage/catalog-client': patch +'@backstage/frontend-plugin-api': patch +--- + +Moved dependencies that are re-exported in the public API from `devDependencies` to `dependencies`. These were incorrectly demoted in #33936 because the source code only uses type imports, but the types still appear in the published API surface and need to be resolvable by consumers at build time. diff --git a/packages/catalog-client/package.json b/packages/catalog-client/package.json index ed87a8c293..f527316262 100644 --- a/packages/catalog-client/package.json +++ b/packages/catalog-client/package.json @@ -51,13 +51,13 @@ "@backstage/catalog-model": "workspace:^", "@backstage/errors": "workspace:^", "@backstage/filter-predicates": "workspace:^", + "@backstage/plugin-catalog-common": "workspace:^", "cross-fetch": "^4.0.0", "lodash": "^4.17.21", "uri-template": "^2.0.0" }, "devDependencies": { "@backstage/cli": "workspace:^", - "@backstage/plugin-catalog-common": "workspace:^", "@types/lodash": "^4.14.151", "msw": "^1.0.0" } diff --git a/packages/frontend-plugin-api/package.json b/packages/frontend-plugin-api/package.json index f4f4e51bf9..f9e7caccce 100644 --- a/packages/frontend-plugin-api/package.json +++ b/packages/frontend-plugin-api/package.json @@ -44,6 +44,7 @@ "test": "backstage-cli package test" }, "dependencies": { + "@backstage/config": "workspace:^", "@backstage/errors": "workspace:^", "@backstage/filter-predicates": "workspace:^", "@backstage/types": "workspace:^", @@ -54,7 +55,6 @@ }, "devDependencies": { "@backstage/cli": "workspace:^", - "@backstage/config": "workspace:^", "@backstage/frontend-app-api": "workspace:^", "@backstage/frontend-test-utils": "workspace:^", "@backstage/test-utils": "workspace:^",