fix secret widget required and disabled properties

Signed-off-by: Stephen Glass <stephen@stephen.glass>
This commit is contained in:
Stephen Glass
2024-08-22 22:21:10 -04:00
parent 3bc05ce226
commit 3ebb64fcf1
3 changed files with 19 additions and 2 deletions
+7
View File
@@ -0,0 +1,7 @@
---
'@backstage/plugin-scaffolder-react': patch
---
- Fix scaffolder secret widget field not displaying as required when it's listed as required.
- Fix scaffolder secret widget not able to be required inside nested objects.
- Fix scaffolder secret widget not able to be disabled.
+4 -1
View File
@@ -152,7 +152,10 @@ export type ScaffolderReactTemplateCategoryPickerClassKey = 'root' | 'label';
// @alpha
export const SecretWidget: (
props: Pick<WidgetProps, 'name' | 'onChange' | 'schema'>,
props: Pick<
WidgetProps,
'name' | 'onChange' | 'schema' | 'required' | 'disabled'
>,
) => React_2.JSX.Element;
// @alpha
@@ -24,13 +24,18 @@ import React from 'react';
* @alpha
*/
export const SecretWidget = (
props: Pick<WidgetProps, 'name' | 'onChange' | 'schema'>,
props: Pick<
WidgetProps,
'name' | 'onChange' | 'schema' | 'required' | 'disabled'
>,
) => {
const { setSecrets, secrets } = useTemplateSecrets();
const {
name,
onChange,
schema: { title },
required,
disabled,
} = props;
return (
@@ -45,6 +50,8 @@ export const SecretWidget = (
value={secrets[name] ?? ''}
type="password"
autoComplete="off"
required={required}
disabled={disabled}
/>
);
};