From 4b64d8556e98ee2bd495f141e3c2f1bb98096e2c Mon Sep 17 00:00:00 2001
From: Camila Belo <camilaibs@gmail.com>
Date: Tue, 27 Feb 2024 14:09:38 +0100
Subject: [PATCH] refactor(scaffolder-backend): apply review suggestions

Signed-off-by: Camila Belo <camilaibs@gmail.com>
---
 .../src/scaffolder/dryrun/createDryRunner.ts                  | 4 ++--
 plugins/scaffolder-backend/src/service/router.ts              | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts b/plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts
index bfab492a1d..2eaa505c8c 100644
--- a/plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts
+++ b/plugins/scaffolder-backend/src/scaffolder/dryrun/createDryRunner.ts
@@ -41,7 +41,7 @@ interface DryRunInput {
   spec: TaskSpec;
   secrets?: TaskSecrets;
   directoryContents: SerializedFile[];
-  getInitiatorCredentials(): Promise<BackstageCredentials>;
+  credentials: BackstageCredentials;
 }
 
 interface DryRunResult {
@@ -118,7 +118,7 @@ export function createDryRunner(options: TemplateTesterCreateOptions) {
           },
         },
         secrets: input.secrets,
-        getInitiatorCredentials: input.getInitiatorCredentials,
+        getInitiatorCredentials: () => Promise.resolve(input.credentials),
         // No need to update this at the end of the run, so just hard-code it
         done: false,
         isDryRun: true,
diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts
index 51286f76c9..a78e37bc7f 100644
--- a/plugins/scaffolder-backend/src/service/router.ts
+++ b/plugins/scaffolder-backend/src/service/router.ts
@@ -626,9 +626,7 @@ export async function createRouter(
           ...(token && { backstageToken: token }),
           initiatorCredentials: JSON.stringify(credentials),
         },
-        getInitiatorCredentials(): Promise<BackstageCredentials> {
-          return Promise.resolve(credentials);
-        },
+        credentials,
       });
 
       res.status(200).json({