From 5223c4ce63251d53ae2db8a657eb5aae9e95386f Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 25 Apr 2024 12:39:57 +0200 Subject: [PATCH] core-components: fix circular import Signed-off-by: Patrik Oldsberg --- .changeset/fuzzy-seahorses-tell.md | 5 +++++ .../core-components/src/layout/HeaderTabs/HeaderTabs.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fuzzy-seahorses-tell.md diff --git a/.changeset/fuzzy-seahorses-tell.md b/.changeset/fuzzy-seahorses-tell.md new file mode 100644 index 0000000000..f184e9ce95 --- /dev/null +++ b/.changeset/fuzzy-seahorses-tell.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Fixed an internal circular import that broke Jest mocks. diff --git a/packages/core-components/src/layout/HeaderTabs/HeaderTabs.tsx b/packages/core-components/src/layout/HeaderTabs/HeaderTabs.tsx index 852622c741..9ee9c5525f 100644 --- a/packages/core-components/src/layout/HeaderTabs/HeaderTabs.tsx +++ b/packages/core-components/src/layout/HeaderTabs/HeaderTabs.tsx @@ -18,7 +18,7 @@ import { makeStyles } from '@material-ui/core/styles'; import TabUI, { TabProps } from '@material-ui/core/Tab'; import Tabs from '@material-ui/core/Tabs'; import React, { useCallback, useEffect, useState } from 'react'; -import { Link } from '@backstage/core-components'; +import { Link } from '../../components/Link'; // TODO(blam): Remove this implementation when the Tabs are ready // This is just a temporary solution to implementing tabs for now