From 670acd88ee482090dae447d5182df470912506ca Mon Sep 17 00:00:00 2001
From: Adam Harvey <adaharve@cisco.com>
Date: Thu, 15 Apr 2021 21:05:26 -0400
Subject: [PATCH] Move diagram to system page

Signed-off-by: Adam Harvey <adaharve@cisco.com>
---
 .changeset/sour-plums-enjoy.md                             | 7 +++++++
 packages/app/src/components/catalog/EntityPage.tsx         | 7 +++----
 .../packages/app/src/components/catalog/EntityPage.tsx     | 7 +++----
 3 files changed, 13 insertions(+), 8 deletions(-)
 create mode 100644 .changeset/sour-plums-enjoy.md

diff --git a/.changeset/sour-plums-enjoy.md b/.changeset/sour-plums-enjoy.md
new file mode 100644
index 0000000000..ef68166255
--- /dev/null
+++ b/.changeset/sour-plums-enjoy.md
@@ -0,0 +1,7 @@
+---
+'@backstage/create-app': patch
+---
+
+Fix system diagram card to be on the system page
+
+To apply the same fix to an existing application, in `EntityPage.tsx` simply move the `<EntityLayout.route>` for the `/diagram` path from the `groupPage` down into the `systemPage` element.
diff --git a/packages/app/src/components/catalog/EntityPage.tsx b/packages/app/src/components/catalog/EntityPage.tsx
index d6f91957a9..d4db2b0e63 100644
--- a/packages/app/src/components/catalog/EntityPage.tsx
+++ b/packages/app/src/components/catalog/EntityPage.tsx
@@ -441,10 +441,6 @@ const groupPage = (
         </Grid>
       </Grid>
     </EntityLayout.Route>
-
-    <EntityLayout.Route path="/diagram" title="Diagram">
-      <EntitySystemDiagramCard />
-    </EntityLayout.Route>
   </EntityLayoutWrapper>
 );
 
@@ -463,6 +459,9 @@ const systemPage = (
         </Grid>
       </Grid>
     </EntityLayout.Route>
+    <EntityLayout.Route path="/diagram" title="Diagram">
+      <EntitySystemDiagramCard />
+    </EntityLayout.Route>
   </EntityLayoutWrapper>
 );
 
diff --git a/packages/create-app/templates/default-app/packages/app/src/components/catalog/EntityPage.tsx b/packages/create-app/templates/default-app/packages/app/src/components/catalog/EntityPage.tsx
index f1aba46c52..a302bb6dd7 100644
--- a/packages/create-app/templates/default-app/packages/app/src/components/catalog/EntityPage.tsx
+++ b/packages/create-app/templates/default-app/packages/app/src/components/catalog/EntityPage.tsx
@@ -208,10 +208,6 @@ const groupPage = (
         </Grid>
       </Grid>
     </EntityLayout.Route>
-
-    <EntityLayout.Route path="/diagram" title="Diagram">
-      <EntitySystemDiagramCard />
-    </EntityLayout.Route>
   </EntityLayout>
 );
 
@@ -230,6 +226,9 @@ const systemPage = (
         </Grid>
       </Grid>
     </EntityLayout.Route>
+    <EntityLayout.Route path="/diagram" title="Diagram">
+      <EntitySystemDiagramCard />
+    </EntityLayout.Route>
   </EntityLayout>
 );