remove inline and internal CSS

Signed-off-by: mufaddal motiwala <mufaddalmm.52@gmail.com>
2021-12-23 15:27:21 +05:30
parent 489d491b8c
commit 79b342bd36
2 changed files with 24 additions and 6 deletions
@@ -0,0 +1,23 @@
+---
+'@backstage/create-app': patch
+---
+
+removed inline and internal CSS from index.html
+
+To make this change to an existing app, apply the following changes to the `app/public/index.html` file:
+Remove internal style
+
+```diff
+ - <style>
+ -  #root {
+ -    min-height: 100%;
+ -  }
+ - </style>
+```
+
+Remove inline style from the body tag
+
+```diff
+- <body style="margin: 0">
+ <body>
+```
@@ -42,11 +42,6 @@
      href="<%= publicPath %>/safari-pinned-tab.svg"
      color="#5bbad5"
    />
-    <style>
-      #root {
-        min-height: 100%;
-      }
-    </style>
    <title><%= config.getString('app.title') %></title>
    <% if (config.has('app.googleAnalyticsTrackingId')) { %>
    <script
@@ -67,7 +62,7 @@
    </script>
    <% } %>
  </head>
-  <body style="margin: 0">
+  <body>
    <noscript>You need to enable JavaScript to run this app.</noscript>
    <div id="root"></div>
    <!--