From 7c8a974515c75e5e18dcd58523f35f6ec76385fb Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Tue, 13 Dec 2022 23:32:30 +0100
Subject: [PATCH] cli: make --since flag for repo build, lint and test commands
 diff yarn lock

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/tasty-impalas-cross.md       | 5 +++++
 packages/cli/src/commands/repo/build.ts | 1 +
 packages/cli/src/commands/repo/lint.ts  | 5 ++++-
 packages/cli/src/commands/repo/test.ts  | 1 +
 4 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/tasty-impalas-cross.md

diff --git a/.changeset/tasty-impalas-cross.md b/.changeset/tasty-impalas-cross.md
new file mode 100644
index 0000000000..f7d7712b29
--- /dev/null
+++ b/.changeset/tasty-impalas-cross.md
@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+The `repo test`, `repo lint`, and `repo build` commands will now analyze `yarn.lock` for dependency changes when searching for changed packages. This allows you to use the `--since <ref>` flag even if you have `yarn.lock` changes.
diff --git a/packages/cli/src/commands/repo/build.ts b/packages/cli/src/commands/repo/build.ts
index 21b1580cb9..a6bf87da82 100644
--- a/packages/cli/src/commands/repo/build.ts
+++ b/packages/cli/src/commands/repo/build.ts
@@ -84,6 +84,7 @@ export async function command(opts: OptionValues, cmd: Command): Promise<void> {
     const graph = PackageGraph.fromPackages(packages);
     const changedPackages = await graph.listChangedPackages({
       ref: opts.since,
+      analyzeLockfile: true,
     });
     const withDevDependents = graph.collectPackageNames(
       changedPackages.map(pkg => pkg.name),
diff --git a/packages/cli/src/commands/repo/lint.ts b/packages/cli/src/commands/repo/lint.ts
index 61d85b3773..8e8ec20ff8 100644
--- a/packages/cli/src/commands/repo/lint.ts
+++ b/packages/cli/src/commands/repo/lint.ts
@@ -34,7 +34,10 @@ export async function command(opts: OptionValues): Promise<void> {
 
   if (opts.since) {
     const graph = PackageGraph.fromPackages(packages);
-    packages = await graph.listChangedPackages({ ref: opts.since });
+    packages = await graph.listChangedPackages({
+      ref: opts.since,
+      analyzeLockfile: true,
+    });
   }
 
   // Packages are ordered from most to least number of dependencies, as a
diff --git a/packages/cli/src/commands/repo/test.ts b/packages/cli/src/commands/repo/test.ts
index 578cb15e83..95bfe8f449 100644
--- a/packages/cli/src/commands/repo/test.ts
+++ b/packages/cli/src/commands/repo/test.ts
@@ -93,6 +93,7 @@ export async function command(opts: OptionValues, cmd: Command): Promise<void> {
     const graph = PackageGraph.fromPackages(packages);
     const changedPackages = await graph.listChangedPackages({
       ref: opts.since,
+      analyzeLockfile: true,
     });
 
     const packageNames = Array.from(