From 7f9676b242eeba6cd521c5b13139130b8746914e Mon Sep 17 00:00:00 2001 From: Philipp Hugenroth Date: Mon, 16 Aug 2021 11:39:39 +0200 Subject: [PATCH] Remove added color from theme types to prevent version bump Signed-off-by: Philipp Hugenroth --- .../core-components/src/layout/Sidebar/Bar.tsx | 2 +- .../core-components/src/layout/Sidebar/Items.tsx | 16 +++++++--------- packages/theme/src/themes.ts | 2 -- packages/theme/src/types.ts | 1 - 4 files changed, 8 insertions(+), 13 deletions(-) diff --git a/packages/core-components/src/layout/Sidebar/Bar.tsx b/packages/core-components/src/layout/Sidebar/Bar.tsx index 05bb751cc8..f928c4b7c4 100644 --- a/packages/core-components/src/layout/Sidebar/Bar.tsx +++ b/packages/core-components/src/layout/Sidebar/Bar.tsx @@ -42,7 +42,7 @@ const useStyles = makeStyles(theme => ({ msOverflowStyle: 'none', scrollbarWidth: 'none', width: sidebarConfig.drawerWidthClosed, - borderRight: `1px solid ${theme.palette.navigation.divider}`, + borderRight: `1px solid #383838`, transition: theme.transitions.create('width', { easing: theme.transitions.easing.sharp, duration: theme.transitions.duration.shortest, diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx index 00771c837b..1068a877bd 100644 --- a/packages/core-components/src/layout/Sidebar/Items.tsx +++ b/packages/core-components/src/layout/Sidebar/Items.tsx @@ -344,15 +344,13 @@ export const SidebarSpacer = styled('div')({ height: 8, }); -export const SidebarDivider = styled('hr')( - ({ theme }: { theme: BackstageTheme }) => ({ - height: 1, - width: '100%', - background: theme.palette.navigation.divider, - border: 'none', - margin: '12px 0px', - }), -); +export const SidebarDivider = styled('hr')({ + height: 1, + width: '100%', + background: '#383838', + border: 'none', + margin: '12px 0px', +}); const styledScrollbar = (theme: Theme): CreateCSSProperties => ({ overflowY: 'auto', diff --git a/packages/theme/src/themes.ts b/packages/theme/src/themes.ts index 03a8fad2a2..b31786aae9 100644 --- a/packages/theme/src/themes.ts +++ b/packages/theme/src/themes.ts @@ -66,7 +66,6 @@ export const lightTheme = createTheme({ background: '#171717', indicator: '#9BF0E1', color: '#b5b5b5', - divider: '#383838', selectedColor: '#FFF', }, pinSidebarButton: { @@ -133,7 +132,6 @@ export const darkTheme = createTheme({ background: '#424242', indicator: '#9BF0E1', color: '#b5b5b5', - divider: '#383838', selectedColor: '#FFF', }, pinSidebarButton: { diff --git a/packages/theme/src/types.ts b/packages/theme/src/types.ts index 2c4d198a4f..c2758c29e7 100644 --- a/packages/theme/src/types.ts +++ b/packages/theme/src/types.ts @@ -47,7 +47,6 @@ type PaletteAdditions = { background: string; indicator: string; color: string; - divider: string; selectedColor: string; }; tabbar: {