From 88d03d85dfac1c9f0948e78f316d260fe1f1240f Mon Sep 17 00:00:00 2001
From: Sydney Achinger <78113809+squid-ney@users.noreply.github.com>
Date: Wed, 2 Oct 2024 15:24:27 -0400
Subject: [PATCH] SearchType.Accordion UX improvement (#26935)

* Update default SearchType.Accordion behavior to NOT close accordion after selection.

Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
---
 .changeset/shy-plants-retire.md                      |  5 +++++
 .../SearchType/SearchType.Accordion.test.tsx         | 12 ------------
 .../components/SearchType/SearchType.Accordion.tsx   |  1 -
 3 files changed, 5 insertions(+), 13 deletions(-)
 create mode 100644 .changeset/shy-plants-retire.md

diff --git a/.changeset/shy-plants-retire.md b/.changeset/shy-plants-retire.md
new file mode 100644
index 0000000000..77427452f5
--- /dev/null
+++ b/.changeset/shy-plants-retire.md
@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-search': patch
+---
+
+Updated the default SearchType.Accordion behavior to remain open after result type selection. This is a UX improvement to reduce the number of clicks needed when toggling result type filters.
diff --git a/plugins/search/src/components/SearchType/SearchType.Accordion.test.tsx b/plugins/search/src/components/SearchType/SearchType.Accordion.test.tsx
index 556a9550a0..453b766791 100644
--- a/plugins/search/src/components/SearchType/SearchType.Accordion.test.tsx
+++ b/plugins/search/src/components/SearchType/SearchType.Accordion.test.tsx
@@ -140,18 +140,6 @@ describe('SearchType.Accordion', () => {
     expect(setPageCursorMock).toHaveBeenCalledWith(undefined);
   });
 
-  it('should collapse when a new type is selected', async () => {
-    const { getByText, queryByText } = render(
-      <Wrapper>
-        <SearchType.Accordion name={expectedLabel} types={[expectedType]} />
-      </Wrapper>,
-    );
-
-    await user.click(getByText(expectedType.name));
-
-    expect(queryByText('Collapse')).not.toBeInTheDocument();
-  });
-
   it('should show result counts if enabled', async () => {
     const { getAllByText } = render(
       <Wrapper>
diff --git a/plugins/search/src/components/SearchType/SearchType.Accordion.tsx b/plugins/search/src/components/SearchType/SearchType.Accordion.tsx
index f9a07b6dcd..bdd13f2fb2 100644
--- a/plugins/search/src/components/SearchType/SearchType.Accordion.tsx
+++ b/plugins/search/src/components/SearchType/SearchType.Accordion.tsx
@@ -96,7 +96,6 @@ export const SearchTypeAccordion = (props: SearchTypeAccordionProps) => {
     return () => {
       setTypes(type !== '' ? [type] : []);
       setPageCursor(undefined);
-      setExpanded(false);
     };
   };