Fix PermissionEvaluator instance checks
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
This commit is contained in:
committed by
Joe Porpeglia
parent
a5c37457a6
commit
8cc75993a6
@@ -0,0 +1,7 @@
|
||||
---
|
||||
'@backstage/plugin-catalog-backend': patch
|
||||
'@backstage/plugin-jenkins-backend': patch
|
||||
'@backstage/plugin-search-backend': patch
|
||||
---
|
||||
|
||||
Fixed issue in `PermissionEvaluator` instance check that would cause unexpected "invalid union" errors.
|
||||
@@ -382,7 +382,7 @@ export class CatalogBuilder {
|
||||
const unauthorizedEntitiesCatalog = new DefaultEntitiesCatalog(dbClient);
|
||||
|
||||
let permissionEvaluator: PermissionEvaluator;
|
||||
if ('query' in permissions) {
|
||||
if ('authorizeConditional' in permissions) {
|
||||
permissionEvaluator = permissions as PermissionEvaluator;
|
||||
} else {
|
||||
logger.warn(
|
||||
|
||||
@@ -40,7 +40,7 @@ export async function createRouter(
|
||||
const { jenkinsInfoProvider, permissions, logger } = options;
|
||||
|
||||
let permissionEvaluator: PermissionEvaluator | undefined;
|
||||
if (permissions && 'query' in permissions) {
|
||||
if (permissions && 'authorizeConditional' in permissions) {
|
||||
permissionEvaluator = permissions as PermissionEvaluator;
|
||||
} else {
|
||||
logger.warn(
|
||||
|
||||
@@ -76,7 +76,7 @@ export async function createRouter(
|
||||
});
|
||||
|
||||
let permissionEvaluator: PermissionEvaluator;
|
||||
if ('query' in permissions) {
|
||||
if ('authorizeConditional' in permissions) {
|
||||
permissionEvaluator = permissions as PermissionEvaluator;
|
||||
} else {
|
||||
logger.warn(
|
||||
|
||||
Reference in New Issue
Block a user