From 49ae28b46b2b1fd0822cfa9c5c6ef69aadff3b4d Mon Sep 17 00:00:00 2001 From: Kiss Miklos Date: Mon, 28 Nov 2022 16:13:02 +0100 Subject: [PATCH 1/3] make the githubCredentialsProvider overrideable Signed-off-by: Kiss Miklos --- .../src/analyzers/GithubLocationAnalyzer.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/catalog-backend-module-github/src/analyzers/GithubLocationAnalyzer.ts b/plugins/catalog-backend-module-github/src/analyzers/GithubLocationAnalyzer.ts index a740fd7706..139a92ee83 100644 --- a/plugins/catalog-backend-module-github/src/analyzers/GithubLocationAnalyzer.ts +++ b/plugins/catalog-backend-module-github/src/analyzers/GithubLocationAnalyzer.ts @@ -39,6 +39,7 @@ export type GithubLocationAnalyzerOptions = { config: Config; discovery: PluginEndpointDiscovery; tokenManager: TokenManager; + githubCredentialsProvider?: GithubCredentialsProvider; }; /** @public */ @@ -52,6 +53,7 @@ export class GithubLocationAnalyzer implements ScmLocationAnalyzer { this.catalogClient = new CatalogClient({ discoveryApi: options.discovery }); this.integrations = ScmIntegrations.fromConfig(options.config); this.githubCredentialsProvider = + options.githubCredentialsProvider || DefaultGithubCredentialsProvider.fromIntegrations(this.integrations); this.tokenManager = options.tokenManager; } From fe93cce74310cdb6809838aafad694046dff7165 Mon Sep 17 00:00:00 2001 From: Kiss Miklos Date: Mon, 28 Nov 2022 16:14:38 +0100 Subject: [PATCH 2/3] add changeset to catalog-backend-module-github Signed-off-by: Kiss Miklos --- .changeset/famous-cobras-suffer.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/famous-cobras-suffer.md diff --git a/.changeset/famous-cobras-suffer.md b/.changeset/famous-cobras-suffer.md new file mode 100644 index 0000000000..d09948f876 --- /dev/null +++ b/.changeset/famous-cobras-suffer.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-backend-module-github': patch +--- + +Added the githubCredentialsProvider property to the GithubLocationAnalyzerOptions to be able to override the GithubCredentialsProvider. From 97520cd44db4983f8aff7d2a0d8a9d2856191a0c Mon Sep 17 00:00:00 2001 From: Kiss Miklos Date: Mon, 28 Nov 2022 16:30:08 +0100 Subject: [PATCH 3/3] add api-report to catalog-backend-module-github Signed-off-by: Kiss Miklos --- plugins/catalog-backend-module-github/api-report.md | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/catalog-backend-module-github/api-report.md b/plugins/catalog-backend-module-github/api-report.md index 7a85d685a3..8ccfdb09ee 100644 --- a/plugins/catalog-backend-module-github/api-report.md +++ b/plugins/catalog-backend-module-github/api-report.md @@ -128,6 +128,7 @@ export type GithubLocationAnalyzerOptions = { config: Config; discovery: PluginEndpointDiscovery; tokenManager: TokenManager; + githubCredentialsProvider?: GithubCredentialsProvider; }; // @public