refactor: address PR comments

This commit is contained in:
Ivan Shmidt
2020-09-02 15:56:14 +02:00
parent 9a99a92f84
commit 9988479c61
16 changed files with 86 additions and 78 deletions
+6 -7
View File
@@ -269,7 +269,7 @@ async function createPlugin(pluginName: string, appDir: string) {
/**
* Start serving the newly created app and make sure that the create plugin is rendering correctly
*/
async function testAppServe(_pluginName: string, appDir: string) {
async function testAppServe(pluginName: string, appDir: string) {
const startApp = spawnPiped(['yarn', 'start'], {
cwd: appDir,
});
@@ -280,12 +280,11 @@ async function testAppServe(_pluginName: string, appDir: string) {
const browser = new Browser();
await waitForPageWithText(browser, '/', 'Backstage Service Catalog');
// TODO(shmidt-i): adjust the plugin creation flow with new routing patterns
// await waitForPageWithText(
// browser,
// `/${pluginName}`,
// `Welcome to ${pluginName}!`,
// );
await waitForPageWithText(
browser,
`/${pluginName}`,
`Welcome to ${pluginName}!`,
);
print('Both App and Plugin loaded correctly');
successful = true;