paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Refactoring based on feedback

Browse Source 
Signed-off-by: Andre Wanlin <awanlin@spotify.com>
This commit is contained in:
Andre Wanlin
2024-09-09 18:12:12 -05:00
parent a159180869
commit 9adc552602
12 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/sour-cherries-allow.md
+7
View File
@@ -0,0 +1,7 @@
---
'@backstage/core-components': patch
---
Added missing items to `overridableComponents`
**BREAKING** Overridable component name for styling `OAuthRequestDialog` changed to `BackstageOAuthRequestDialog`. Overridable component name `BackstageMissingAnnotationEmptyState` that was previously deprecated has been removed.
.changeset/ten-numbers-vanish.md
-2
View File
@@ -1,7 +1,5 @@
---
'@backstage/core-components': patch
'@backstage/plugin-catalog-graph': patch
'@backstage/plugin-catalog-react': patch
'@backstage/plugin-search-react': patch
'@backstage/plugin-catalog': patch
'@backstage/plugin-home': patch
.changeset/tough-plants-divide.md
+7
View File
@@ -0,0 +1,7 @@
---
'@backstage/plugin-catalog-react': patch
---
Added missing items to `overridableComponents`
**BREAKING** Overridable component name for styling `BackstageMissingAnnotationEmptyState` has been changed to `CatalogReactMissingAnnotationEmptyState`
packages/core-components/api-report.md
-3
View File
@@ -800,9 +800,6 @@ export function MissingAnnotationEmptyState(
props: Props_3,
): React_2.JSX.Element;
// @public @deprecated (undocumented)
export type MissingAnnotationEmptyStateClassKey = 'code';
// @public
export const MobileSidebar: (
props: MobileSidebarProps,
packages/core-components/src/components/EmptyState/MissingAnnotationEmptyState.tsx
-6
View File
@@ -49,12 +49,6 @@ type Props = {
readMoreUrl?: string;
};
/**
* @public
* @deprecated This component is deprecated, please use {@link @backstage/plugin-catalog-react#MissingAnnotationEmptyStateClassKey} instead
*/
export type MissingAnnotationEmptyStateClassKey = 'code';
const useStyles = makeStyles(
theme => ({
code: {
packages/core-components/src/components/EmptyState/index.ts
-1
View File
@@ -18,4 +18,3 @@ export { EmptyState } from './EmptyState';
export type { EmptyStateClassKey } from './EmptyState';
export type { EmptyStateImageClassKey } from './EmptyStateImage';
export { MissingAnnotationEmptyState } from './MissingAnnotationEmptyState';
export type { MissingAnnotationEmptyStateClassKey } from './MissingAnnotationEmptyState';
packages/core-components/src/overridableComponents.ts
+2 -4
View File
@@ -25,7 +25,6 @@ import {
DismissableBannerClassKey,
EmptyStateClassKey,
EmptyStateImageClassKey,
MissingAnnotationEmptyStateClassKey,
ErrorPanelClassKey,
FeatureCalloutCircleClassKey,
HeaderIconLinkRowClassKey,
@@ -107,7 +106,6 @@ type BackstageComponentsNameToClassKey = {
BackstageDismissableBanner: DismissableBannerClassKey;
BackstageEmptyState: EmptyStateClassKey;
BackstageEmptyStateImage: EmptyStateImageClassKey;
BackstageMissingAnnotationEmptyState: MissingAnnotationEmptyStateClassKey;
BackstageErrorPanel: ErrorPanelClassKey;
BackstageFeatureCalloutCircular: FeatureCalloutCircleClassKey;
BackstageHeaderIconLinkRow: HeaderIconLinkRowClassKey;
@@ -117,7 +115,7 @@ type BackstageComponentsNameToClassKey = {
BackstageMarkdownContent: MarkdownContentClassKey;
BackstageLoginRequestListItem: LoginRequestListItemClassKey;
BackstageLogViewer: LogViewerClassKey;
OAuthRequestDialog: OAuthRequestDialogClassKey;
BackstageOAuthRequestDialog: OAuthRequestDialogClassKey;
BackstageOverflowTooltip: OverflowTooltipClassKey;
BackstageGauge: GaugeClassKey;
BackstageGaugeCard: GaugeCardClassKey;
@@ -173,7 +171,7 @@ type BackstageComponentsNameToClassKey = {
BackstageTabbedCard: TabbedCardClassKey;
BackstageTabbedCardBoldHeader: BoldHeaderClassKey;
BackstageCardTab: CardTabClassKey;
Link: LinkClassKey;
BackstageLink: LinkClassKey;
BackstageFavoriteToggleIcon: FavoriteToggleIconClassKey;
};
plugins/catalog-react/api-report.md
+2 -2
View File
@@ -92,10 +92,10 @@ export type CatalogReactComponentsNameToClassKey = {
CatalogReactEntitySearchBar: CatalogReactEntitySearchBarClassKey;
CatalogReactEntityTagPicker: CatalogReactEntityTagPickerClassKey;
CatalogReactEntityOwnerPicker: CatalogReactEntityOwnerPickerClassKey;
FixedWidthFormControlLabel: FixedWidthFormControlLabelClassKey;
CatalogReactFixedWidthFormControlLabel: FixedWidthFormControlLabelClassKey;
CatalogReactEntityProcessingStatusPicker: CatalogReactEntityProcessingStatusPickerClassKey;
CatalogReactEntityAutocompletePickerClassKey: CatalogReactEntityAutocompletePickerClassKey;
BackstageMissingAnnotationEmptyState: MissingAnnotationEmptyStateClassKey;
CatalogReactMissingAnnotationEmptyState: MissingAnnotationEmptyStateClassKey;
};
// @public (undocumented)
plugins/catalog-react/src/overridableComponents.ts
+2 -2
View File
@@ -38,10 +38,10 @@ export type CatalogReactComponentsNameToClassKey = {
CatalogReactEntitySearchBar: CatalogReactEntitySearchBarClassKey;
CatalogReactEntityTagPicker: CatalogReactEntityTagPickerClassKey;
CatalogReactEntityOwnerPicker: CatalogReactEntityOwnerPickerClassKey;
FixedWidthFormControlLabel: FixedWidthFormControlLabelClassKey;
CatalogReactFixedWidthFormControlLabel: FixedWidthFormControlLabelClassKey;
CatalogReactEntityProcessingStatusPicker: CatalogReactEntityProcessingStatusPickerClassKey;
CatalogReactEntityAutocompletePickerClassKey: CatalogReactEntityAutocompletePickerClassKey;
BackstageMissingAnnotationEmptyState: MissingAnnotationEmptyStateClassKey;
CatalogReactMissingAnnotationEmptyState: MissingAnnotationEmptyStateClassKey;
};
/** @public */
plugins/catalog/api-report.md
+2 -2
View File
@@ -632,8 +632,8 @@ export type PluginCatalogComponentsNameToClassKey = {
PluginCatalogEntityLinksEmptyState: EntityLinksEmptyStateClassKey;
PluginCatalogSystemDiagramCard: SystemDiagramCardClassKey;
PluginCatalogEntityContextMenu: EntityContextMenuClassKey;
CatalogSearchResultListItem: CatalogSearchResultListItemClassKey;
pluginCatalogTableToolbar: CatalogTableToolbarClassKey;
PluginCatalogSearchResultListItem: CatalogSearchResultListItemClassKey;
PluginCatalogTableToolbar: CatalogTableToolbarClassKey;
PluginCatalogEntityLabelsEmptyState: EntityLabelsEmptyStateClassKey;
};
plugins/catalog/src/overridableComponents.ts
+2 -2
View File
@@ -28,8 +28,8 @@ export type PluginCatalogComponentsNameToClassKey = {
PluginCatalogEntityLinksEmptyState: EntityLinksEmptyStateClassKey;
PluginCatalogSystemDiagramCard: SystemDiagramCardClassKey;
PluginCatalogEntityContextMenu: EntityContextMenuClassKey;
CatalogSearchResultListItem: CatalogSearchResultListItemClassKey;
pluginCatalogTableToolbar: CatalogTableToolbarClassKey;
PluginCatalogSearchResultListItem: CatalogSearchResultListItemClassKey;
PluginCatalogTableToolbar: CatalogTableToolbarClassKey;
PluginCatalogEntityLabelsEmptyState: EntityLabelsEmptyStateClassKey;
};
plugins/search-react/src/overridableComponents.ts
+1 -1
View File
@@ -20,7 +20,7 @@ import { HighlightedSearchResultTextClassKey } from './components';
/** @public */
export type CatalogReactComponentsNameToClassKey = {
BackstageHighlightedSearchResultText: HighlightedSearchResultTextClassKey;
SearchReactHighlightedSearchResultText: HighlightedSearchResultTextClassKey;
};
/** @public */