From 9b78090f5f6f4e888fe2b22e077aef98d522bb3f Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sat, 16 Sep 2023 17:18:55 +0200 Subject: [PATCH] backend-defaults: update createBackend test to avoid starting backend Signed-off-by: Patrik Oldsberg --- .../backend-defaults/src/CreateBackend.test.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/packages/backend-defaults/src/CreateBackend.test.ts b/packages/backend-defaults/src/CreateBackend.test.ts index 23e5c571bd..55fdbe5a6a 100644 --- a/packages/backend-defaults/src/CreateBackend.test.ts +++ b/packages/backend-defaults/src/CreateBackend.test.ts @@ -18,16 +18,24 @@ import { coreServices, createServiceFactory, } from '@backstage/backend-plugin-api'; -import { mockServices } from '@backstage/backend-test-utils'; import { createBackend } from './CreateBackend'; describe('createBackend', () => { it('should not throw when overriding a default service implementation', async () => { const backend = createBackend(); - backend.add(mockServices.rootConfig.factory()); + backend.add( + createServiceFactory({ + service: coreServices.rootConfig, + deps: {}, + factory(): never { + throw new Error('NOPE'); + }, + }), + ); - await expect(backend.start()).resolves.toBe(undefined); + // We expect the service factory error to be thrown, rather than any earlier validation + await expect(backend.start()).rejects.toThrow('NOPE'); }); it('should throw on duplicate service implementations', async () => {