paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix some particularly noisy test log warning sources

Browse Source 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2024-05-30 14:52:48 +02:00
parent 422d464e84
commit 9cdc651a41
13 changed files with 120 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/clever-radios-yawn.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-api-docs': patch
---
Make sure that the toggle button state is properly reflected in API cards
packages/core-app-api/src/app/AppManager.test.tsx
+4 -2
View File
@@ -20,7 +20,7 @@ import {
renderWithEffects,
withLogCollector,
} from '@backstage/test-utils';
import { render, screen, waitFor } from '@testing-library/react';
import { render, screen, waitFor, act } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import React, { PropsWithChildren, ReactNode } from 'react';
import { BrowserRouter, Navigate, Route, Routes } from 'react-router-dom';
@@ -874,7 +874,9 @@ describe('Integration Test', () => {
);
await renderWithEffects(<Root />);
await userEvent.click(screen.getByText('Sign Out'));
await act(async () => {
await userEvent.click(screen.getByText('Sign Out'));
});
await waitFor(() =>
expect(fetchApiMock.fetch).toHaveBeenCalledWith(
packages/core-components/src/layout/TabbedCard/TabbedCard.test.tsx
+1 -1
View File
@@ -104,7 +104,7 @@ describe('<TabbedCard />', () => {
const rendered = render(
wrapInTestApp(
<TabbedCard onChange={mockOnChange}>
<TabbedCard onChange={mockOnChange} value="one">
<CardTab value="one" label="Test 1">
Test Content 1
</CardTab>
packages/core-components/src/setupTests.ts
+15
View File
@@ -15,3 +15,18 @@
*/
import '@testing-library/jest-dom';
// eslint-disable-next-line no-console
const originalConsoleWarn = console.warn;
// eslint-disable-next-line no-console
console.warn = (...args: any[]) => {
const message = args[0];
if (
typeof message === 'string' &&
(message.includes('CSSOM.parse is not a function') ||
message.includes('[JSS]'))
) {
return;
}
originalConsoleWarn(...args);
};
packages/frontend-app-api/src/setupTests.ts
+15
View File
@@ -15,3 +15,18 @@
*/
import '@testing-library/jest-dom';
// eslint-disable-next-line no-console
const originalConsoleWarn = console.warn;
// eslint-disable-next-line no-console
console.warn = (...args: any[]) => {
const message = args[0];
if (
typeof message === 'string' &&
(message.includes('CSSOM.parse is not a function') ||
message.includes('[JSS]'))
) {
return;
}
originalConsoleWarn(...args);
};
packages/frontend-plugin-api/src/setupTests.ts
+15
View File
@@ -15,3 +15,18 @@
*/
import '@testing-library/jest-dom';
// eslint-disable-next-line no-console
const originalConsoleWarn = console.warn;
// eslint-disable-next-line no-console
console.warn = (...args: any[]) => {
const message = args[0];
if (
typeof message === 'string' &&
(message.includes('CSSOM.parse is not a function') ||
message.includes('[JSS]'))
) {
return;
}
originalConsoleWarn(...args);
};
packages/frontend-test-utils/src/setupTests.ts
+15
View File
@@ -15,3 +15,18 @@
*/
import '@testing-library/jest-dom';
// eslint-disable-next-line no-console
const originalConsoleWarn = console.warn;
// eslint-disable-next-line no-console
console.warn = (...args: any[]) => {
const message = args[0];
if (
typeof message === 'string' &&
(message.includes('CSSOM.parse is not a function') ||
message.includes('[JSS]'))
) {
return;
}
originalConsoleWarn(...args);
};
plugins/api-docs/src/components/ApisCards/presets.tsx
+1
View File
@@ -38,6 +38,7 @@ const ApiDefinitionButton = ({ apiEntity }: { apiEntity: ApiEntity }) => {
<ToggleButton
aria-label="Toggle API Definition Dialog"
onClick={() => setDialogOpen(!dialogOpen)}
value={dialogOpen}
>
<ExtensionIcon />
</ToggleButton>
plugins/catalog-react/src/hooks/useEntity.test.tsx
+14 -8
View File
@@ -24,20 +24,26 @@ import {
} from './useEntity';
import { Entity } from '@backstage/catalog-model';
import { analyticsApiRef, useAnalytics } from '@backstage/core-plugin-api';
import { MockAnalyticsApi, TestApiRegistry } from '@backstage/test-utils';
import {
MockAnalyticsApi,
TestApiRegistry,
withLogCollector,
} from '@backstage/test-utils';
import { ApiProvider } from '@backstage/core-app-api';
const entity = { metadata: { name: 'my-entity' }, kind: 'MyKind' } as Entity;
describe('useEntity', () => {
it('should throw if no entity is provided', async () => {
expect(() =>
renderHook(() => useEntity(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<EntityProvider children={children} />
),
}),
).toThrow(/entity has not been loaded/);
withLogCollector(() => {
expect(() =>
renderHook(() => useEntity(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<EntityProvider children={children} />
),
}),
).toThrow(/entity has not been loaded/);
});
});
it('should provide an entity', async () => {
plugins/techdocs-module-addons-contrib/src/TextSize/TextSize.test.tsx
+4 -5
View File
@@ -15,11 +15,8 @@
*/
import { TechDocsAddonTester } from '@backstage/plugin-techdocs-addons-test-utils';
import React from 'react';
import { fireEvent, waitFor } from '@testing-library/react';
import { fireEvent, waitFor, act } from '@testing-library/react';
import { TextSize } from '../plugin';
describe('TextSize', () => {
@@ -47,7 +44,9 @@ describe('TextSize', () => {
const slider = getByRole('slider');
slider.focus();
act(() => {
slider.focus();
});
fireEvent.keyDown(slider, {
key: 'ArrowRight',
plugins/techdocs-module-addons-contrib/src/setupTests.ts
+3
View File
@@ -13,6 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import '@testing-library/jest-dom';
Element.prototype.scrollIntoView = jest.fn();
@@ -41,3 +42,5 @@ global.BroadcastChannel = jest
close: jest.fn(),
};
});
window.scroll = jest.fn();
plugins/techdocs/src/search/components/TechDocsSearch.test.tsx
+15 -5
View File
@@ -18,7 +18,13 @@ import { ApiProvider } from '@backstage/core-app-api';
import { searchApiRef } from '@backstage/plugin-search-react';
import { TestApiRegistry, renderInTestApp } from '@backstage/test-utils';
import Button from '@material-ui/core/Button';
import { fireEvent, screen, waitFor, within } from '@testing-library/react';
import {
fireEvent,
screen,
waitFor,
within,
act,
} from '@testing-library/react';
import React, { useState } from 'react';
import { TechDocsSearch } from './TechDocsSearch';
@@ -91,9 +97,11 @@ it('should trigger query when autocomplete input changed', async () => {
const autocomplete = screen.getByTestId('techdocs-search-bar');
const input = within(autocomplete).getByRole('textbox');
autocomplete.click();
autocomplete.focus();
fireEvent.change(input, { target: { value: 'asdf' } });
act(() => {
autocomplete.click();
autocomplete.focus();
fireEvent.change(input, { target: { value: 'asdf' } });
});
await singleResult;
await waitFor(() =>
@@ -148,7 +156,9 @@ it('should update filter values when a new entityName is provided', async () =>
});
const button = screen.getByText('Update Entity');
button.click();
act(() => {
button.click();
});
await singleResult;
await waitFor(() =>
plugins/user-settings/src/components/SettingsPage/SettingsPage.test.tsx
+13 -4
View File
@@ -22,6 +22,7 @@ import { useOutlet } from 'react-router-dom';
import { SettingsLayout } from '../SettingsLayout';
import { screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { entityRouteRef } from '@backstage/plugin-catalog-react';
jest.mock('react-router-dom', () => ({
...jest.requireActual('react-router-dom'),
@@ -34,7 +35,9 @@ describe('<SettingsPage />', () => {
});
it('should render the default settings page with 3 tabs', async () => {
const { container } = await renderInTestApp(<SettingsPage />);
const { container } = await renderInTestApp(<SettingsPage />, {
mountedRoutes: { '/catalog/:namespace/:kind/:name': entityRouteRef },
});
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(3);
@@ -47,7 +50,9 @@ describe('<SettingsPage />', () => {
</UserSettingsTab>
);
(useOutlet as jest.Mock).mockReturnValue(advancedTabRoute);
const { container } = await renderInTestApp(<SettingsPage />);
const { container } = await renderInTestApp(<SettingsPage />, {
mountedRoutes: { '/catalog/:namespace/:kind/:name': entityRouteRef },
});
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
@@ -61,7 +66,9 @@ describe('<SettingsPage />', () => {
</SettingsLayout.Route>
);
(useOutlet as jest.Mock).mockReturnValue(advancedTabRoute);
const { container } = await renderInTestApp(<SettingsPage />);
const { container } = await renderInTestApp(<SettingsPage />, {
mountedRoutes: { '/catalog/:namespace/:kind/:name': entityRouteRef },
});
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(4);
@@ -84,7 +91,9 @@ describe('<SettingsPage />', () => {
</SettingsLayout>
);
(useOutlet as jest.Mock).mockReturnValue(customLayout);
const { container } = await renderInTestApp(<SettingsPage />);
const { container } = await renderInTestApp(<SettingsPage />, {
mountedRoutes: { '/catalog/:namespace/:kind/:name': entityRouteRef },
});
const tabs = container.querySelectorAll('[class*=MuiTabs-root] a');
expect(tabs).toHaveLength(2);