From a3ec2f32ea439c43532121b5d0b35588fab49985 Mon Sep 17 00:00:00 2001
From: Patrik Oldsberg <poldsberg@gmail.com>
Date: Fri, 30 Dec 2022 10:54:14 +0100
Subject: [PATCH] backend-test-utils: include all core services in test backend

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
---
 .changeset/little-beans-hammer.md             |  5 ++++
 .../src/next/wiring/TestBackend.ts            | 26 ++++++++++++++++---
 .../app-backend/src/service/appPlugin.test.ts | 10 -------
 3 files changed, 28 insertions(+), 13 deletions(-)
 create mode 100644 .changeset/little-beans-hammer.md

diff --git a/.changeset/little-beans-hammer.md b/.changeset/little-beans-hammer.md
new file mode 100644
index 0000000000..d998f5f5ba
--- /dev/null
+++ b/.changeset/little-beans-hammer.md
@@ -0,0 +1,5 @@
+---
+'@backstage/backend-test-utils': patch
+---
+
+The `startTestBackend` setup now includes default implementations for all core services.
diff --git a/packages/backend-test-utils/src/next/wiring/TestBackend.ts b/packages/backend-test-utils/src/next/wiring/TestBackend.ts
index 647ebc9dda..f21cad6049 100644
--- a/packages/backend-test-utils/src/next/wiring/TestBackend.ts
+++ b/packages/backend-test-utils/src/next/wiring/TestBackend.ts
@@ -17,10 +17,20 @@
 import {
   Backend,
   createSpecializedBackend,
+  cacheFactory,
+  configFactory,
+  databaseFactory,
+  discoveryFactory,
+  httpRouterFactory,
   lifecycleFactory,
-  rootLifecycleFactory,
   loggerFactory,
+  permissionsFactory,
+  rootHttpRouterFactory,
+  rootLifecycleFactory,
   rootLoggerFactory,
+  schedulerFactory,
+  tokenManagerFactory,
+  urlReaderFactory,
 } from '@backstage/backend-app-api';
 import {
   ServiceFactory,
@@ -55,10 +65,20 @@ export interface TestBackendOptions<
 }
 
 const defaultServiceFactories = [
-  rootLoggerFactory(),
-  loggerFactory(),
+  cacheFactory(),
+  configFactory(),
+  databaseFactory(),
+  discoveryFactory(),
+  httpRouterFactory(),
   lifecycleFactory(),
+  loggerFactory(),
+  permissionsFactory(),
+  rootHttpRouterFactory(),
   rootLifecycleFactory(),
+  rootLoggerFactory(),
+  schedulerFactory(),
+  tokenManagerFactory(),
+  urlReaderFactory(),
 ];
 
 const backendInstancesToCleanUp = new Array<Backend>();
diff --git a/plugins/app-backend/src/service/appPlugin.test.ts b/plugins/app-backend/src/service/appPlugin.test.ts
index 14921622c9..d911919425 100644
--- a/plugins/app-backend/src/service/appPlugin.test.ts
+++ b/plugins/app-backend/src/service/appPlugin.test.ts
@@ -20,12 +20,6 @@ import fetch from 'node-fetch';
 import { coreServices } from '@backstage/backend-plugin-api';
 import { startTestBackend } from '@backstage/backend-test-utils';
 import { appPlugin } from './appPlugin';
-import {
-  databaseFactory,
-  httpRouterFactory,
-  loggerFactory,
-  rootLoggerFactory,
-} from '@backstage/backend-app-api';
 import { ConfigReader } from '@backstage/config';
 import getPort from 'get-port';
 
@@ -59,10 +53,6 @@ describe('appPlugin', () => {
             },
           }),
         ],
-        loggerFactory(),
-        rootLoggerFactory(),
-        databaseFactory(),
-        httpRouterFactory(),
       ],
       features: [
         appPlugin({