techdocs-common: Allow techdocs-cli to import in a non-backstage environment

techdocs-common has a dependency on @backstage/plugin-techdocs-backend. This prohibits techdocs-cli to import it and generate/publish docs on a CI/CD environment to an external storage
This commit is contained in:
Himanshu Mishra
2021-01-15 09:26:26 +01:00
parent 2b7ba47ce2
commit a594a72576
2 changed files with 26 additions and 7 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/techdocs-common': patch
---
@backstage/techdocs-common can now be imported in an environment without @backstage/plugin-techdocs-backend being installed.
@@ -16,6 +16,8 @@
import fetch from 'cross-fetch';
import express from 'express';
import fs from 'fs-extra';
import path from 'path';
import os from 'os';
import { Logger } from 'winston';
import { Entity, EntityName } from '@backstage/catalog-model';
import {
@@ -25,10 +27,20 @@ import {
import { Config } from '@backstage/config';
import { PublisherBase, PublishRequest, PublishResponse } from './types';
const staticDocsDir = resolvePackagePath(
'@backstage/plugin-techdocs-backend',
'static/docs',
);
// TODO: Use a more persistent storage than node_modules or /tmp directory.
// Make it configurable with techdocs.publisher.local.publishDirectory
let staticDocsDir = '';
try {
staticDocsDir = resolvePackagePath(
'@backstage/plugin-techdocs-backend',
'static/docs',
);
} catch (err) {
// This will most probably never be used.
// The try/catch is introduced so that techdocs-cli can import @backstage/techdocs-common
// on CI/CD without installing techdocs backend plugin.
staticDocsDir = os.tmpdir();
}
/**
* Local publisher which uses the local filesystem to store the generated static files. It uses a directory
@@ -39,6 +51,9 @@ export class LocalPublish implements PublisherBase {
private readonly logger: Logger;
private readonly discovery: PluginEndpointDiscovery;
// TODO: Use a static fromConfig method to create a LocalPublish instance, similar to aws/gcs publishers.
// Move the logic of setting staticDocsDir based on config over to fromConfig,
// and set the value as a class parameter.
constructor(
config: Config,
logger: Logger,
@@ -52,9 +67,8 @@ export class LocalPublish implements PublisherBase {
publish({ entity, directory }: PublishRequest): Promise<PublishResponse> {
const entityNamespace = entity.metadata.namespace ?? 'default';
const publishDir = resolvePackagePath(
'@backstage/plugin-techdocs-backend',
'static/docs',
const publishDir = path.join(
staticDocsDir,
entityNamespace,
entity.kind,
entity.metadata.name,