Rename event modules to comply with naming pattern

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
This commit is contained in:
Johan Haals
2023-03-08 11:50:36 +01:00
parent f6cc42ab10
commit a5de745ac1
36 changed files with 85 additions and 50 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-bitbucket-cloud': patch
---
Renamed `bitbucketCloudEventRouterEventsModule` to `eventsModuleBitbucketCloudEventRouter` to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-aws-sqs': patch
---
Renamed `awsSqsConsumingEventPublisherEventsModule` to `eventsModuleAwsSqsConsumingEventPublisher` to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-gerrit': patch
---
Renamed `gerritEventRouterEventsModule` to `eventsModuleGerritEventRouter` to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-github': patch
---
Renamed `githubEventRouterEventsModule` to `eventsModuleGithubEventRouter` and `githubWebhookEventsModule` to `eventsModuleGithubWebhook`, to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-gitlab': patch
---
Renamed `gitlabEventRouterEventsModule` to `eventsModuleGitlabEventRouter` and `gitlabWebhookEventsModule` to `eventsModuleGitlabWebhook` to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend-module-azure': patch
---
Renamed `azureDevOpsEventRouterEventsModule` to `eventsModuleAzureDevOpsEventRouter` to match the [recommended naming patterns](https://backstage.io/docs/backend-system/architecture/naming-patterns).
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-events-backend': patch
---
Updated README instructions
@@ -6,7 +6,7 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const awsSqsConsumingEventPublisherEventsModule: () => BackendFeature;
export const eventsModuleAwsSqsConsumingEventPublisher: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,4 +14,4 @@
* limitations under the License.
*/
export { awsSqsConsumingEventPublisherEventsModule } from './service/AwsSqsConsumingEventPublisherEventsModule';
export { eventsModuleAwsSqsConsumingEventPublisher } from './service/eventsModuleAwsSqsConsumingEventPublisher';
@@ -20,10 +20,10 @@ import { startTestBackend } from '@backstage/backend-test-utils';
import { ConfigReader } from '@backstage/config';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { TestEventBroker } from '@backstage/plugin-events-backend-test-utils';
import { awsSqsConsumingEventPublisherEventsModule } from './AwsSqsConsumingEventPublisherEventsModule';
import { eventsModuleAwsSqsConsumingEventPublisher } from './eventsModuleAwsSqsConsumingEventPublisher';
import { AwsSqsConsumingEventPublisher } from '../publisher/AwsSqsConsumingEventPublisher';
describe('awsSqsEventsModule', () => {
describe('eventsModuleAwsSqsConsumingEventPublisher', () => {
it('should be correctly wired and set up', async () => {
const config = new ConfigReader({
events: {
@@ -68,7 +68,7 @@ describe('awsSqsEventsModule', () => {
[coreServices.logger, getVoidLogger()],
[coreServices.scheduler, scheduler],
],
features: [awsSqsConsumingEventPublisherEventsModule()],
features: [eventsModuleAwsSqsConsumingEventPublisher()],
});
expect(addedPublishers).not.toBeUndefined();
@@ -27,9 +27,9 @@ import { AwsSqsConsumingEventPublisher } from '../publisher/AwsSqsConsumingEvent
*
* @alpha
*/
export const awsSqsConsumingEventPublisherEventsModule = createBackendModule({
export const eventsModuleAwsSqsConsumingEventPublisher = createBackendModule({
pluginId: 'events',
moduleId: 'awsSqsConsumingEventPublisherEventsModule',
moduleId: 'awsSqsConsumingEventPublisher',
register(env) {
env.registerInit({
deps: {
@@ -6,7 +6,7 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const azureDevOpsEventRouterEventsModule: () => BackendFeature;
export const eventsModuleAzureDevOpsEventRouter: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,4 +14,4 @@
* limitations under the License.
*/
export { azureDevOpsEventRouterEventsModule } from './service/AzureDevOpsEventRouterEventsModule';
export { eventsModuleAzureDevOpsEventRouter } from './service/eventsModuleAzureDevOpsEventRouter';
@@ -16,10 +16,10 @@
import { startTestBackend } from '@backstage/backend-test-utils';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { azureDevOpsEventRouterEventsModule } from './AzureDevOpsEventRouterEventsModule';
import { eventsModuleAzureDevOpsEventRouter } from './eventsModuleAzureDevOpsEventRouter';
import { AzureDevOpsEventRouter } from '../router/AzureDevOpsEventRouter';
describe('azureDevOpsEventRouterEventsModule', () => {
describe('eventsModuleAzureDevOpsEventRouter', () => {
it('should be correctly wired and set up', async () => {
let addedPublisher: AzureDevOpsEventRouter | undefined;
let addedSubscriber: AzureDevOpsEventRouter | undefined;
@@ -35,7 +35,7 @@ describe('azureDevOpsEventRouterEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [],
features: [azureDevOpsEventRouterEventsModule()],
features: [eventsModuleAzureDevOpsEventRouter()],
});
expect(addedPublisher).not.toBeUndefined();
@@ -25,7 +25,7 @@ import { AzureDevOpsEventRouter } from '../router/AzureDevOpsEventRouter';
*
* @alpha
*/
export const azureDevOpsEventRouterEventsModule = createBackendModule({
export const eventsModuleAzureDevOpsEventRouter = createBackendModule({
pluginId: 'events',
moduleId: 'azureDevOpsEventRouter',
register(env) {
@@ -6,7 +6,7 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const bitbucketCloudEventRouterEventsModule: () => BackendFeature;
export const eventsModuleBitbucketCloudEventRouter: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,4 +14,4 @@
* limitations under the License.
*/
export { bitbucketCloudEventRouterEventsModule } from './service/BitbucketCloudEventRouterEventsModule';
export { eventsModuleBitbucketCloudEventRouter } from './service/eventsModuleBitbucketCloudEventRouter';
@@ -16,10 +16,10 @@
import { startTestBackend } from '@backstage/backend-test-utils';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { bitbucketCloudEventRouterEventsModule } from './BitbucketCloudEventRouterEventsModule';
import { eventsModuleBitbucketCloudEventRouter } from './eventsModuleBitbucketCloudEventRouter';
import { BitbucketCloudEventRouter } from '../router/BitbucketCloudEventRouter';
describe('bitbucketCloudEventRouterEventsModule', () => {
describe('eventsModuleBitbucketCloudEventRouter', () => {
it('should be correctly wired and set up', async () => {
let addedPublisher: BitbucketCloudEventRouter | undefined;
let addedSubscriber: BitbucketCloudEventRouter | undefined;
@@ -35,7 +35,7 @@ describe('bitbucketCloudEventRouterEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [],
features: [bitbucketCloudEventRouterEventsModule()],
features: [eventsModuleBitbucketCloudEventRouter()],
});
expect(addedPublisher).not.toBeUndefined();
@@ -25,7 +25,7 @@ import { BitbucketCloudEventRouter } from '../router/BitbucketCloudEventRouter';
*
* @alpha
*/
export const bitbucketCloudEventRouterEventsModule = createBackendModule({
export const eventsModuleBitbucketCloudEventRouter = createBackendModule({
pluginId: 'events',
moduleId: 'bitbucketCloudEventRouter',
register(env) {
@@ -6,7 +6,7 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const gerritEventRouterEventsModule: () => BackendFeature;
export const eventsModuleGerritEventRouter: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,4 +14,4 @@
* limitations under the License.
*/
export { gerritEventRouterEventsModule } from './service/GerritEventRouterEventsModule';
export { eventsModuleGerritEventRouter } from './service/eventsModuleGerritEventRouter';
@@ -16,10 +16,10 @@
import { startTestBackend } from '@backstage/backend-test-utils';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { gerritEventRouterEventsModule } from './GerritEventRouterEventsModule';
import { eventsModuleGerritEventRouter } from './eventsModuleGerritEventRouter';
import { GerritEventRouter } from '../router/GerritEventRouter';
describe('gerritEventRouterEventsModule', () => {
describe('eventsModuleGerritEventRouter', () => {
it('should be correctly wired and set up', async () => {
let addedPublisher: GerritEventRouter | undefined;
let addedSubscriber: GerritEventRouter | undefined;
@@ -35,7 +35,7 @@ describe('gerritEventRouterEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [],
features: [gerritEventRouterEventsModule()],
features: [eventsModuleGerritEventRouter()],
});
expect(addedPublisher).not.toBeUndefined();
@@ -25,7 +25,7 @@ import { GerritEventRouter } from '../router/GerritEventRouter';
*
* @alpha
*/
export const gerritEventRouterEventsModule = createBackendModule({
export const eventsModuleGerritEventRouter = createBackendModule({
pluginId: 'events',
moduleId: 'gerritEventRouter',
register(env) {
@@ -6,10 +6,10 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const githubEventRouterEventsModule: () => BackendFeature;
export const eventsModuleGithubEventRouter: () => BackendFeature;
// @alpha
export const githubWebhookEventsModule: () => BackendFeature;
export const eventsModuleGithubWebhook: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,5 +14,5 @@
* limitations under the License.
*/
export { githubEventRouterEventsModule } from './service/GithubEventRouterEventsModule';
export { githubWebhookEventsModule } from './service/GithubWebhookEventsModule';
export { eventsModuleGithubEventRouter } from './service/eventsModuleGithubEventRouter';
export { eventsModuleGithubWebhook } from './service/eventsModuleGithubWebhook';
@@ -16,10 +16,10 @@
import { startTestBackend } from '@backstage/backend-test-utils';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { githubEventRouterEventsModule } from './GithubEventRouterEventsModule';
import { eventsModuleGithubEventRouter } from './eventsModuleGithubEventRouter';
import { GithubEventRouter } from '../router/GithubEventRouter';
describe('githubEventRouterEventsModule', () => {
describe('eventsModuleGithubEventRouter', () => {
it('should be correctly wired and set up', async () => {
let addedPublisher: GithubEventRouter | undefined;
let addedSubscriber: GithubEventRouter | undefined;
@@ -35,7 +35,7 @@ describe('githubEventRouterEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [],
features: [githubEventRouterEventsModule()],
features: [eventsModuleGithubEventRouter()],
});
expect(addedPublisher).not.toBeUndefined();
@@ -25,7 +25,7 @@ import { GithubEventRouter } from '../router/GithubEventRouter';
*
* @alpha
*/
export const githubEventRouterEventsModule = createBackendModule({
export const eventsModuleGithubEventRouter = createBackendModule({
pluginId: 'events',
moduleId: 'githubEventRouter',
register(env) {
@@ -23,9 +23,9 @@ import {
RequestDetails,
} from '@backstage/plugin-events-node';
import { sign } from '@octokit/webhooks-methods';
import { githubWebhookEventsModule } from './GithubWebhookEventsModule';
import { eventsModuleGithubWebhook } from './eventsModuleGithubWebhook';
describe('githubWebhookEventsModule', () => {
describe('eventsModuleGithubWebhook', () => {
const secret = 'valid-secret';
const payload = { test: 'payload' };
const payloadString = JSON.stringify(payload);
@@ -60,7 +60,7 @@ describe('githubWebhookEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [[coreServices.config, config]],
features: [githubWebhookEventsModule()],
features: [eventsModuleGithubWebhook()],
});
expect(addedIngress).not.toBeUndefined();
@@ -28,7 +28,7 @@ import { createGithubSignatureValidator } from '../http/createGithubSignatureVal
*
* @alpha
*/
export const githubWebhookEventsModule = createBackendModule({
export const eventsModuleGithubWebhook = createBackendModule({
pluginId: 'events',
moduleId: 'githubWebhook',
register(env) {
@@ -6,10 +6,10 @@
import { BackendFeature } from '@backstage/backend-plugin-api';
// @alpha
export const gitlabEventRouterEventsModule: () => BackendFeature;
export const eventsModuleGitlabEventRouter: () => BackendFeature;
// @alpha
export const gitlabWebhookEventsModule: () => BackendFeature;
export const eventsModuleGitlabWebhook: () => BackendFeature;
// (No @packageDocumentation comment for this package)
```
@@ -14,5 +14,5 @@
* limitations under the License.
*/
export { gitlabEventRouterEventsModule } from './service/GitlabEventRouterEventsModule';
export { gitlabWebhookEventsModule } from './service/GitlabWebhookEventsModule';
export { eventsModuleGitlabEventRouter } from './service/eventsModuleGitlabEventRouter';
export { eventsModuleGitlabWebhook } from './service/eventsModuleGitlabWebhook';
@@ -16,10 +16,10 @@
import { startTestBackend } from '@backstage/backend-test-utils';
import { eventsExtensionPoint } from '@backstage/plugin-events-node/alpha';
import { gitlabEventRouterEventsModule } from './GitlabEventRouterEventsModule';
import { eventsModuleGitlabEventRouter } from './eventsModuleGitlabEventRouter';
import { GitlabEventRouter } from '../router/GitlabEventRouter';
describe('gitlabEventRouterEventsModule', () => {
describe('eventsModuleGitlabEventRouter', () => {
it('should be correctly wired and set up', async () => {
let addedPublisher: GitlabEventRouter | undefined;
let addedSubscriber: GitlabEventRouter | undefined;
@@ -35,7 +35,7 @@ describe('gitlabEventRouterEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [],
features: [gitlabEventRouterEventsModule()],
features: [eventsModuleGitlabEventRouter()],
});
expect(addedPublisher).not.toBeUndefined();
@@ -25,7 +25,7 @@ import { GitlabEventRouter } from '../router/GitlabEventRouter';
*
* @alpha
*/
export const gitlabEventRouterEventsModule = createBackendModule({
export const eventsModuleGitlabEventRouter = createBackendModule({
pluginId: 'events',
moduleId: 'gitlabEventRouter',
register(env) {
@@ -22,7 +22,7 @@ import {
HttpPostIngressOptions,
RequestDetails,
} from '@backstage/plugin-events-node';
import { gitlabWebhookEventsModule } from './GitlabWebhookEventsModule';
import { eventsModuleGitlabWebhook } from './eventsModuleGitlabWebhook';
describe('gitlabWebhookEventsModule', () => {
const requestWithToken = (token?: string) => {
@@ -55,7 +55,7 @@ describe('gitlabWebhookEventsModule', () => {
await startTestBackend({
extensionPoints: [[eventsExtensionPoint, extensionPoint]],
services: [[coreServices.config, config]],
features: [gitlabWebhookEventsModule()],
features: [eventsModuleGitlabWebhook()],
});
expect(addedIngress).not.toBeUndefined();
@@ -30,7 +30,7 @@ import { createGitlabTokenValidator } from '../http/createGitlabTokenValidator';
*
* @alpha
*/
export const gitlabWebhookEventsModule = createBackendModule({
export const eventsModuleGitlabWebhook = createBackendModule({
pluginId: 'events',
moduleId: 'gitlabWebhook',
register(env) {
+2 -2
View File
@@ -186,9 +186,9 @@ import { eventsExtensionPoint } from '@backstage/plugin-events-node';
// [...]
export const yourModuleEventsModule = createBackendModule({
export const eventsModuleYourFeature = createBackendModule({
pluginId: 'events',
moduleId: 'yourModule',
moduleId: 'yourFeature',
register(env) {
// [...]
env.registerInit({