From a62a1f9dca0446424e806f5b4e0be0de09d7d4e1 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Wed, 21 Dec 2022 15:30:41 +0100 Subject: [PATCH] cli: apply package duplication filter during yarn start Signed-off-by: Patrik Oldsberg --- .changeset/forty-years-retire.md | 5 +++++ packages/cli/src/commands/start/startFrontend.ts | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/forty-years-retire.md diff --git a/.changeset/forty-years-retire.md b/.changeset/forty-years-retire.md new file mode 100644 index 0000000000..e7b887a1e4 --- /dev/null +++ b/.changeset/forty-years-retire.md @@ -0,0 +1,5 @@ +--- +'@backstage/cli': patch +--- + +The frontend serve task now filters out allowed package duplicates during its package check, just like `versions:bump` and `versions:check`. diff --git a/packages/cli/src/commands/start/startFrontend.ts b/packages/cli/src/commands/start/startFrontend.ts index f6923632c8..689fb28466 100644 --- a/packages/cli/src/commands/start/startFrontend.ts +++ b/packages/cli/src/commands/start/startFrontend.ts @@ -21,7 +21,7 @@ import { serveBundle } from '../../lib/bundler'; import { loadCliConfig } from '../../lib/config'; import { paths } from '../../lib/paths'; import { Lockfile } from '../../lib/versioning'; -import { includedFilter } from '../versions/lint'; +import { forbiddenDuplicatesFilter, includedFilter } from '../versions/lint'; interface StartAppOptions { verifyVersions?: boolean; @@ -37,9 +37,9 @@ export async function startFrontend(options: StartAppOptions) { const result = lockfile.analyze({ filter: includedFilter, }); - const problemPackages = [...result.newVersions, ...result.newRanges].map( - ({ name }) => name, - ); + const problemPackages = [...result.newVersions, ...result.newRanges] + .map(({ name }) => name) + .filter(forbiddenDuplicatesFilter); if (problemPackages.length > 1) { console.log(