refactor: more review refinements

Signed-off-by: Camila Belo <camilaibs@gmail.com>

plugins/auth-node/src/identity/createCookieAuthRefreshMiddleware.test.ts

@@ -1,49 +0,0 @@
-/*
- * Copyright 2024 The Backstage Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import express from 'express';
-import request from 'supertest';
-import { mockCredentials, mockServices } from '@backstage/backend-test-utils';
-import { createCookieAuthRefreshMiddleware } from './createCookieAuthRefreshMiddleware';
-
-describe('createCookieAuthRefreshMiddleware', () => {
-  let app: express.Express;
-
-  beforeAll(async () => {
-    const auth = mockServices.auth();
-    const httpAuth = mockServices.httpAuth();
-    const router = createCookieAuthRefreshMiddleware({ auth, httpAuth });
-    app = express().use(router);
-  });
-
-  beforeEach(() => {
-    jest.resetAllMocks();
-  });
-
-  it('should issue the user cookie', async () => {
-    const response = await request(app).get('/.backstage/auth/v1/cookie');
-    expect(response.status).toBe(200);
-    expect(response.header['set-cookie'][0]).toMatch(
-      `backstage-auth=${mockCredentials.limitedUser.token()}`,
-    );
-  });
-
-  it('should remove the user cookie', async () => {
-    const response = await request(app).delete('/.backstage/auth/v1/cookie');
-    expect(response.status).toBe(200);
-    expect(response.header['set-cookie'][0]).toMatch('backstage-auth=');
-  });
-});

plugins/auth-node/src/identity/createCookieAuthRefreshMiddleware.ts

@@ -1,47 +0,0 @@
-/*
- * Copyright 2024 The Backstage Authors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import { AuthService, HttpAuthService } from '@backstage/backend-plugin-api';
-import { Router } from 'express';
-
-const WELL_KNOWN_COOKIE_PATH_V1 = '/.backstage/auth/v1/cookie';
-
-/**
- * @public
- * Creates a middleware that can be used to refresh the cookie for the user.
- */
-export function createCookieAuthRefreshMiddleware(options: {
-  auth: AuthService;
-  httpAuth: HttpAuthService;
-}) {
-  const { auth, httpAuth } = options;
-  const router = Router();
-
-  // Endpoint that sets the cookie for the user
-  router.get(WELL_KNOWN_COOKIE_PATH_V1, async (_, res) => {
-    const { expiresAt } = await httpAuth.issueUserCookie(res);
-    res.json({ expiresAt: expiresAt.toISOString() });
-  });
-
-  // Endpoint that removes the cookie for the user
-  router.delete(WELL_KNOWN_COOKIE_PATH_V1, async (_, res) => {
-    const credentials = await auth.getNoneCredentials();
-    await httpAuth.issueUserCookie(res, { credentials });
-    res.send(200);
-  });
-
-  return router;
-}

plugins/auth-node/src/identity/index.ts

@@ -22,4 +22,3 @@ export {
 } from './DefaultIdentityClient';
 export { IdentityClient } from './IdentityClient';
 export type { IdentityApi, IdentityApiGetIdentityRequest } from './IdentityApi';
-export { createCookieAuthRefreshMiddleware } from './createCookieAuthRefreshMiddleware';