address remaining comments

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
This commit is contained in:
its-mitesh-kumar
2025-11-18 20:17:39 +05:30
parent ff28f897c4
commit bb42830a77
8 changed files with 33 additions and 15 deletions
@@ -92,14 +92,12 @@ const ClusterSummary = ({
spacing={0}
>
<Grid item>
<StatusOK>
{totalNumberOfPods} {t('cluster.pods')}
</StatusOK>
<StatusOK>{t('cluster.pods', { count: totalNumberOfPods })}</StatusOK>
</Grid>
<Grid item>
{numberOfPodsWithErrors > 0 ? (
<StatusError>
{numberOfPodsWithErrors} {t('cluster.podsWithErrors')}
{t('cluster.podsWithErrors', { count: numberOfPodsWithErrors })}
</StatusError>
) : (
<StatusOK>{t('cluster.noPodsWithErrors')}</StatusOK>
@@ -58,7 +58,10 @@ export const ConfigmapsDrawer = ({
</Grid>
{namespace && (
<Grid item>
<Chip size="small" label={`${t('namespace.label')} ${namespace}`} />
<Chip
size="small"
label={t('namespace.labelWithValue', { namespace })}
/>
</Grid>
)}
</Grid>
@@ -62,7 +62,10 @@ export const CronJobDrawer = ({
</Grid>
{namespace && (
<Grid item>
<Chip size="small" label={`${t('namespace.label')} ${namespace}`} />
<Chip
size="small"
label={t('namespace.labelWithValue', { namespace })}
/>
</Grid>
)}
</Grid>
@@ -128,18 +128,20 @@ const RolloutSummary = ({
>
<Grid item>
<Typography variant="subtitle2">
{t('hpa.minReplicas')} {hpa.spec?.minReplicas ?? '?'} /{' '}
{t('hpa.maxReplicas')} {hpa.spec?.maxReplicas ?? '?'}
{t('hpa.replicasSummary', {
min: hpa.spec?.minReplicas ?? '?',
max: hpa.spec?.maxReplicas ?? '?',
})}
</Typography>
</Grid>
<Grid item>
<Typography variant="subtitle2">
{t('hpa.currentCpuUsage')} {cpuUtil ?? '?'}%
{t('hpa.currentCpuUsageLabel', { value: cpuUtil ?? '?' })}
</Typography>
</Grid>
<Grid item>
<Typography variant="subtitle2">
{t('hpa.targetCpuUsage')} {specCpuUtil ?? '?'}%
{t('hpa.targetCpuUsageLabel', { value: specCpuUtil ?? '?' })}
</Typography>
</Grid>
</Grid>
@@ -56,7 +56,10 @@ export const RolloutDrawer = ({
</Grid>
{namespace && (
<Grid item>
<Chip size="small" label={`${t('namespace.label')} ${namespace}`} />
<Chip
size="small"
label={t('namespace.labelWithValue', { namespace })}
/>
</Grid>
)}
</Grid>
@@ -71,7 +71,10 @@ export const DaemonSetDrawer = ({
</Grid>
{namespace && (
<Grid item>
<Chip size="small" label={`${t('namespace.label')} ${namespace}`} />
<Chip
size="small"
label={t('namespace.labelWithValue', { namespace })}
/>
</Grid>
)}
</Grid>
@@ -74,7 +74,10 @@ export const DeploymentDrawer = ({
</Grid>
{namespace && (
<Grid item>
<Chip size="small" label={`${t('namespace.label')} ${namespace}`} />
<Chip
size="small"
label={t('namespace.labelWithValue', { namespace })}
/>
</Grid>
)}
</Grid>
+5 -2
View File
@@ -23,10 +23,12 @@ export const kubernetesReactTranslationRef = createTranslationRef({
cluster: {
label: 'Cluster',
pods: 'pods',
pods_one: '{{count}} pod',
pods_other: '{{count}} pods',
podsWithErrors: 'pods with errors',
podsWithErrors_one: '{{count}} pod with errors',
podsWithErrors_other: '{{count}} pods with errors',
noPodsWithErrors: 'No pods with errors',
podWithErrors_one: '{{count}} pod with errors',
podWithErrors_other: '{{count}} pods with errors',
},
podsTable: {
columns: {
@@ -138,6 +140,7 @@ export const kubernetesReactTranslationRef = createTranslationRef({
},
namespace: {
label: 'namespace:',
labelWithValue: 'namespace: {{namespace}}',
},
kubernetesDialog: {
closeAriaLabel: 'close',