From dd4ea5896d0f575c2eb36fd39d15869e8fe9b062 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Mon, 13 Apr 2026 21:29:21 +0200 Subject: [PATCH] Remove unnecessary exports of file-local helpers Remove the `export` keyword from functions that are only used within their own file and are not part of any package's public API: - `parseStringsParam` and `isOrder` in notifications-backend - `toWeb` in backend-defaults urlReader - `resolvePublicPath` in app-backend Signed-off-by: Patrik Oldsberg Made-with: Cursor --- .../backend-defaults/src/entrypoints/urlReader/lib/util.ts | 2 +- plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts | 2 +- .../src/service/parseEntityOrderFieldParams.ts | 7 ++----- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/backend-defaults/src/entrypoints/urlReader/lib/util.ts b/packages/backend-defaults/src/entrypoints/urlReader/lib/util.ts index 68c66e5239..0ae0aabdf1 100644 --- a/packages/backend-defaults/src/entrypoints/urlReader/lib/util.ts +++ b/packages/backend-defaults/src/entrypoints/urlReader/lib/util.ts @@ -42,7 +42,7 @@ export function responseToReadable(response: Response): Readable { // The NodeJS ReadableStream is that fetch returns is super basic and not even // iterable. This function converts it to the smarter, iterable stream/web // variant instead. -export function toWeb( +function toWeb( responseBody: ReadableStream, ): WebReadableStream { const reader = responseBody.getReader(); diff --git a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts index cfc62243f2..38ab117fda 100644 --- a/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts +++ b/plugins/app-backend/src/lib/config/injectConfigIntoHtml.ts @@ -70,7 +70,7 @@ ${JSON.stringify(appConfigs, null, 2) return Buffer.from(indexHtmlContentWithConfig, 'utf8'); } -export function resolvePublicPath(config: Config) { +function resolvePublicPath(config: Config) { const baseUrl = new URL( config.getOptionalString('app.baseUrl') ?? '/', 'http://localhost:7007', diff --git a/plugins/notifications-backend/src/service/parseEntityOrderFieldParams.ts b/plugins/notifications-backend/src/service/parseEntityOrderFieldParams.ts index 913e04993c..fa47a0fa36 100644 --- a/plugins/notifications-backend/src/service/parseEntityOrderFieldParams.ts +++ b/plugins/notifications-backend/src/service/parseEntityOrderFieldParams.ts @@ -23,10 +23,7 @@ import { EntityOrder } from '../database'; * Takes a single unknown parameter and makes sure that it's a single string or * an array of strings, and returns as an array. */ -export function parseStringsParam( - param: unknown, - ctx: string, -): string[] | undefined { +function parseStringsParam(param: unknown, ctx: string): string[] | undefined { if (param === undefined) { return undefined; } @@ -57,6 +54,6 @@ export function parseEntityOrderFieldParams( }); } -export function isOrder(order: string): order is 'asc' | 'desc' { +function isOrder(order: string): order is 'asc' | 'desc' { return ['asc', 'desc'].includes(order); }