From dede4d1cc7f0fa2ffd83aa0cd3e557c34283f10c Mon Sep 17 00:00:00 2001 From: hennnnes Date: Thu, 13 Apr 2023 11:26:05 +0200 Subject: [PATCH] Declare closeButtonColor as optional and use inherit as fallback Signed-off-by: hennnnes --- .../src/components/DismissableBanner/DismissableBanner.tsx | 4 ++-- packages/theme/api-report.md | 2 +- packages/theme/src/types.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core-components/src/components/DismissableBanner/DismissableBanner.tsx b/packages/core-components/src/components/DismissableBanner/DismissableBanner.tsx index 186f38a111..9b74b1e9b8 100644 --- a/packages/core-components/src/components/DismissableBanner/DismissableBanner.tsx +++ b/packages/core-components/src/components/DismissableBanner/DismissableBanner.tsx @@ -64,17 +64,17 @@ const useStyles = makeStyles( width: '100%', maxWidth: 'inherit', flexWrap: 'nowrap', + color: theme.palette.banner.text, }, message: { display: 'flex', alignItems: 'center', - color: theme.palette.banner.text, '& a': { color: theme.palette.banner.link, }, }, button: { - color: theme.palette.banner.closeButtonColor, + color: theme.palette.banner.closeButtonColor ?? 'inherit', }, info: { backgroundColor: theme.palette.banner.info, diff --git a/packages/theme/api-report.md b/packages/theme/api-report.md index 60566266c7..863ab81b68 100644 --- a/packages/theme/api-report.md +++ b/packages/theme/api-report.md @@ -70,7 +70,7 @@ export type BackstagePaletteAdditions = { error: string; text: string; link: string; - closeButtonColor: string; + closeButtonColor?: string; warning?: string; }; }; diff --git a/packages/theme/src/types.ts b/packages/theme/src/types.ts index ff5dce9e8b..0295e491f1 100644 --- a/packages/theme/src/types.ts +++ b/packages/theme/src/types.ts @@ -85,7 +85,7 @@ export type BackstagePaletteAdditions = { error: string; text: string; link: string; - closeButtonColor: string; + closeButtonColor?: string; warning?: string; }; };