From f430b6c6fda846ce4a2462efc7fdde03f0cd74eb Mon Sep 17 00:00:00 2001 From: Oliver Sand Date: Thu, 27 May 2021 13:05:02 +0200 Subject: [PATCH] Don't merge with previous from state on form changes Signed-off-by: Oliver Sand --- .changeset/eighty-rabbits-fail.md | 5 +++++ .../scaffolder/src/components/TemplatePage/TemplatePage.tsx | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/eighty-rabbits-fail.md diff --git a/.changeset/eighty-rabbits-fail.md b/.changeset/eighty-rabbits-fail.md new file mode 100644 index 0000000000..5f15d79ef4 --- /dev/null +++ b/.changeset/eighty-rabbits-fail.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder': patch +--- + +Don't merge with previous from state on form changes. diff --git a/plugins/scaffolder/src/components/TemplatePage/TemplatePage.tsx b/plugins/scaffolder/src/components/TemplatePage/TemplatePage.tsx index ba71b38d75..12930db2cc 100644 --- a/plugins/scaffolder/src/components/TemplatePage/TemplatePage.tsx +++ b/plugins/scaffolder/src/components/TemplatePage/TemplatePage.tsx @@ -150,8 +150,8 @@ export const TemplatePage = () => { const handleFormReset = () => setFormState({}); const handleChange = useCallback( - (e: IChangeEvent) => setFormState({ ...formState, ...e.formData }), - [setFormState, formState], + (e: IChangeEvent) => setFormState(e.formData), + [setFormState], ); const handleCreate = async () => {