74233 Commits

Author SHA1 Message Date
Deepthi Ajith c4a45bd2f4 Changeset added
Signed-off-by: Deepthi Ajith <deepthi.ajith@infosys.com>
2026-04-23 09:37:35 +02:00
Deepthi Ajith 23ee7899b0 fix(ui): add invalid state styling to Checkbox component
Signed-off-by: Deepthi Ajith <deepthi.ajith@infosys.com>
2026-04-23 09:37:35 +02:00
Patrik Oldsberg b6ca666812 frontend-app-api: isolate invalid feature flag registrations
Wrap each feature flag registration in a try/catch so that a single
invalid flag name (e.g. containing a slash) is reported through the
error collector instead of crashing the entire app at bootstrap.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
Made-with: Cursor
2026-04-23 00:38:05 +02:00
Jan Michael Ong 8d60c70e5d chore: fix uncommitted changes to the public API or reports of a package error
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 12:38:37 -07:00
Jan Michael Ong f388853791 chore: fix tsdoc-characters-after-block-tag warning
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 12:14:41 -07:00
Jan Michael Ong e72787948c chore: fix Warning: (ae-forgotten-export)
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 12:01:06 -07:00
Jan Michael Ong a50f4ec818 chore: incorporate additional copilot suggestions
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 11:35:23 -07:00
Jan Michael Ong 547b91de03 chore: switch retryOptions to an options object
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 11:14:47 -07:00
Jan Michael Ong 5a048ed042 chore: integrate copilot suggestion
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 11:13:51 -07:00
Jan Michael Ong ad3e56f4ac chore: fix incorrect placement
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 10:02:24 -07:00
Jan Michael Ong 9032ec7f1e chore: integrate copilot / awanlin feedback
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:53:01 -07:00
Jan Michael Ong 3b460c2e22 fix: add missing export
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:19:53 -07:00
Jan Michael Ong d5e2dee26a chore: integrate copilot feedback
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:18:54 -07:00
Jan Michael Ong a2ee960900 chore: add changeset
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:03:49 -07:00
Jan Michael Ong e351c07daa chore: add helper to get an octokit client
* add unit tests

Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:03:49 -07:00
Jan Michael Ong 19a4d08bd2 chore: add octokit/plugin-retry
Signed-off-by: Jan Michael Ong <adobejmong@gmail.com>
2026-04-22 09:03:49 -07:00
Charles de Dreuille 6407493de8 Update report.api.md
Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-22 15:25:41 +01:00
Aramis Sennyey 3b8c0557c6 golden-path: backend plugin persistence guide (#33540)
* docs: backend plugin persistence guide

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* fix prettier

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* add dto section

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* Apply suggestion from @aramissennyeydd

Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>

* address feedback

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* test against real scaffolding

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>

* fix knex migrate:make command to specify migrations directory

Without --migrations-directory, knex cannot resolve the config
and errors with "Failed to resolve config file".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

* address copilot review feedback

- Fix file paths in code snippets to match scaffolded layout (src/ prefix)
- Add missing semicolons in toDatabaseRow/fromDatabaseRow return objects
- Change knex from devDependency to regular dependency for type imports
- Add missing customize-your-instance to adoption sidebar

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

---------

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
Signed-off-by: Aramis Sennyey <159921952+aramissennyeydd@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-22 10:12:51 -04:00
Charles de Dreuille a69c2e29a2 fix(ui): improve semantic markup and a11y across Header components
- Tags: replace div+Fragment with ul/li; move circle divider to CSS ::before pseudo-element, removing it from the DOM
- Metadata: replace div wrapper with dl/dt/dd for proper key-value semantics; reset dl and dd browser margins
- HeaderMetadataUsers: render multi-user stack as ul/li; simplify single-user branch into one ternary with a fragment
- HeaderMetadataStatus: add role="img" and aria-label to the status dot so screen readers announce its meaning
- Restore Fragment import from react

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-22 15:02:28 +01:00
Patrik Oldsberg 1b55701923 Merge pull request #34006 from backstage/rugvip/fix-lockfile-removal-detection
Fix lockfile dependency removal detection in PackageGraph
2026-04-22 15:36:14 +02:00
Etienne Napoleone 6ce1444ca0 chore(changeset): add card scroll shadow fix changeset
Signed-off-by: Etienne Napoleone <etienne.napoleone@gmail.com>
2026-04-22 14:28:42 +02:00
Fredrik Adelöw db3e59cc70 Merge pull request #34004 from backstage/bui-fix-external-links
fix(ui): preserve external hrefs in BUI link components
2026-04-22 14:28:36 +02:00
Etienne Napoleone a0ea7b3152 fix(ui): disable card content scroll shadow on unsuported browsers
bugged in firefox https://caniuse.com/mdn-css_properties_animation-timeline_scroll

Signed-off-by: Etienne Napoleone <etienne.napoleone@gmail.com>
2026-04-22 14:10:02 +02:00
Charles de Dreuille ec109ce7fb fix(ui): replace custom regex with marked Lexer for inline description parsing
Uses marked's Lexer.lexInline() instead of a hand-rolled regex to parse
inline links in the Header description. marked ships CommonJS, has zero
dependencies, and is already used in the monorepo. This gives us a proper
token model that handles edge cases the regex could not.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-22 12:41:26 +01:00
Fredrik Adelöw d0aa11ba64 Merge pull request #34023 from backstage/freben/cleanup-released-patches
chore: remove .patches entries already released in v1.50.2
2026-04-22 10:50:39 +02:00
Fredrik Adelöw f5354dc5ff Merge pull request #34019 from backstage/freben/swappable-notification-description
Make NotificationDescription a swappable component
2026-04-22 10:34:28 +02:00
Fredrik Adelöw 8521de1d46 Merge pull request #33122 from johnmcollier/filterstatustasks
feat(scaffolder): Allow filtering by status in scaffolderService.listTasks
2026-04-22 10:27:36 +02:00
Fredrik Adelöw 504ebe49a0 Update .changeset/gold-friends-end.md
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-04-22 10:27:27 +02:00
Fredrik Adelöw 8a871869fa Merge pull request #34018 from backstage/freben/fix-swappable-components-docs
docs(swappable-components): fix missing backticks and small typos
2026-04-22 09:23:44 +02:00
1337 e907ba6fe1 Merge branch 'backstage:master' into feature/catalog-export 2026-04-22 09:17:13 +02:00
Fredrik Adelöw df8e8196e0 chore: remove .patches entries already released in v1.50.2
The following patches were included in the v1.50.2 patch release and
no longer need to be tracked:

- pr-33908 (TechDocs sidebar positioning)
- pr-33952 (zod v4 bump)
- pr-33975 (React Aria dependency clamping)
- pr-33984 (tab indicator opacity fix)

Signed-off-by: Fredrik Adelöw <freben@spotify.com>
Made-with: Cursor
2026-04-22 09:13:40 +02:00
Johan Persson 20f0689b29 patches: add entry for #34004
Signed-off-by: Johan Persson <johanopersson@gmail.com>
2026-04-22 09:03:40 +02:00
backstage-goalie[bot] 14b50d85ac Merge pull request #34020 from backstage/renovate/npm-dompurify-vulnerability
Update dependency dompurify to v3.4.0 [SECURITY]
2026-04-22 00:13:57 +00:00
Fredrik Adelöw 94c1cf55c7 Use a type-only import for NotificationDescriptionProps
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-04-21 18:14:54 +02:00
Fredrik Adelöw e2fdc2b61f Merge pull request #33911 from backstage/changeset-release/master
Version Packages (next)
2026-04-21 18:05:23 +02:00
renovate[bot] 4c66f3e96c Update dependency dompurify to v3.4.0 [SECURITY]
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-04-21 15:14:31 +00:00
Fredrik Adelöw de9fc68cf1 Document the description prop on NotificationDescription
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-04-21 17:10:29 +02:00
github-actions[bot] 1cc86bee1c Version Packages (next) 2026-04-21 15:07:43 +00:00
Charles de Dreuille 50a66a9183 Merge pull request #33909 from backstage/cursor/add-date-range-picker
feat(ui): add DateRangePicker component
2026-04-21 15:54:38 +01:00
Fredrik Adelöw 4f7e5219de Load the default NotificationDescription implementation lazily
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-04-21 16:44:48 +02:00
Fredrik Adelöw 03311e33da Make NotificationDescription a swappable component
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-04-21 16:35:29 +02:00
Fredrik Adelöw 8c8199cdf9 Update docs/frontend-system/building-plugins/06-swappable-components.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2026-04-21 16:29:15 +02:00
Fredrik Adelöw ffb749e4b6 docs(swappable-components): fix missing backticks and small typos
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Fredrik Adelöw <freben@spotify.com>
2026-04-21 16:21:03 +02:00
Patrik Oldsberg 957be583cd Merge pull request #34017 from drodil/home_fix_patch
chore: add patch file for #33721
2026-04-21 11:56:07 +02:00
Hellgren Heikki 81f8d5f7de chore: add patch file for #33721
Signed-off-by: Hellgren Heikki <heikki.hellgren@op.fi>
2026-04-21 12:42:00 +03:00
Charles de Dreuille ea11646d8d fix(ui): address second round of PR review comments
- Replace hardcoded gap: 20px with var(--bui-space-5) in metadata row
- Trim leading whitespace from href before unsafe-scheme check to prevent bypass

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-21 09:34:34 +01:00
Fredrik Adelöw e5e7700c7b Merge pull request #34001 from backstage/freben/facets-perf
catalog-backend: fix facets endpoint performance regression
2026-04-21 09:59:56 +02:00
Charles de Dreuille 4dfd2f1284 revert(ui): restore Container wrapper on Header
Reverting the full-width change as it is too disruptive at this time
and will be handled in a separate PR.

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-21 08:55:53 +01:00
Charles de Dreuille a2e0636c1f fix(ui): address PR review comments on Header components
- Guard against unsafe URL schemes (javascript:/vbscript:/data:) in description links
- Use index-based keys for tags and metadata to avoid duplicate-key warnings
- Render ReactNode metadata values directly instead of wrapping in Text to avoid invalid span>div nesting; only wrap plain strings in Text
- Replace empty-string Avatar src fallback with data:, to prevent spurious page requests
- Fix JSDoc in HeaderMetadataUsers to accurately describe the row layout

Signed-off-by: Charles de Dreuille <charles.dedreuille@gmail.com>
2026-04-20 21:22:20 +01:00
the-serious-programmer 3ec5c61b0e feature(catalog export): process copilot feedback
Signed-off-by: the-serious-programmer <19777147+the-serious-programmer@users.noreply.github.com>
2026-04-20 21:29:26 +02:00