paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 35 Packages Projects Releases Wiki Activity
24,671 Commits 1 Branch 0 Tags
111995470d715054cfaeb0083a17897e6deccfeb
Commit Graph

10319 Commits

Author SHA1 Message Date
Prasetya Aria Wibawa 19fe9bfafb add checked props to switch component 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 2566b48ebb transitive ownership of entities for group kind 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:17 +07:00
Joe Porpeglia c84d4ad373 Fix usePermission usage 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 3e0bbeda8b permission-react: fix usePermission tests 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 8c6129d3e0 permission-react: inline parameter type to clean up the api report a bit 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
Joe Porpeglia 91703e8086 permission-react: use object instead of tuple for usePermission args 
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 16:07:10 -04:00
Mike Lewis 5bdcb8c45d permission-react: more restrictive typing for usePermission and PermissionedRoute 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 9da18e4715 search: throw error for unexpected non-resource permissions when authorizing result-by-result 
We only reach this point in the code for types where the initial
authorization returned CONDITIONAL -- ALLOWs return early immediately
above, and types where the decision was DENY get filtered out entirely
when querying.

This means the call to isResourcePermission here is mostly about
narrowing the types, since the only way for it to be false is if the
PermissionPolicy returned a CONDITIONAL decision for a non-resource
permission, which can't happen - it would throw an error during
validation in the permission-backend.

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 15:58:42 -04:00
Mike Lewis 30f9884359 search: check for non-resource permissions when authorizing results 
Now that we can differentiate between ResourcePermissions and other
kinds of permissions, we can skip authorizing result-by-result
when the permission for a given document type is not a
ResourcePermission.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 15:58:42 -04:00
Joe Porpeglia 1e0dbd4fb5 Add todo 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 8cb7acd781 catalog-react: stop using CatalogEntityPermission convenience type 
There's currently an issue with importing alpha exports from other
packages in the monorepo. This works around the issue for now by
skipping the use of the `CatalogEntityPermission` convenience type,
using `ResourcePermission<'catalog-entity'>` directly instead.

cf. https://github.com/backstage/backstage/pull/10128

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 0ffd88a90e catalog-react: require CatalogEntityPermission in useEntityPermission 
Now that we have stricter typing for permissions, we can restrict the
useEntityPermission hook to only be used with permissions of type
`CatalogEntityPermission`.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 8c8bee47f4 catalog-common: add CatalogEntityPermission convenience type 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Fredrik Adelöw 6a8c4251a1 Merge pull request #10291 from RoadieHQ/allow-customizing-default-catalog-component 
Expose initialFiliter from Catalog Page
 2022-03-23 17:03:36 +01:00
Ben Lambert 9792812e2d Merge pull request #9859 from shvmbisht/add-default-commit-msg 
Added default commit message
 2022-03-23 10:02:36 +01:00
Fredrik Adelöw b6fbd2e594 Merge pull request #10071 from Erog38/feature/insights-tasks 
updating backend-tasks and tech-insights to work together
 2022-03-22 19:59:52 +01:00
MT Lewis f71db7b1a0 permission-react: clean up unneeded 'as const' in test suite 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
MT Lewis 9a80cfc768 permission-common: add comment explaining separation of type property on PermissionBase 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
MT Lewis 8dc2be1daa permission-common: add doc comment to PermissionBase.type 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
Mike Lewis 9cbb270aef permissions: add a discriminator type to Permission 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
Mike Lewis ada4446733 permission-common: use createCondition helper when creating conditions 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
Mike Lewis 899d38ea68 permission-common: add utility types for creating and refining Permissions 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
Mike Lewis 95284162d6 permission-common: introduce ResourcePermission type 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-22 14:32:38 -04:00
Fredrik Adelöw c1cfe0db30 review updates 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-22 19:24:05 +01:00
Phil Gore 9053686daa updates for readability 
Signed-off-by: Phil Gore <pgore@ea.com>
 2022-03-22 14:48:18 +01:00
Phil Gore 231fee736b updating tasks and tech-insights to work together 
Signed-off-by: Phil Gore <pgore@ea.com>
 2022-03-22 14:48:17 +01:00
Shivam bisht 45b4b821a0 updated api reports 
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:50 +05:30
Shivam bisht 1e128d9531 changed gitCommitMessage from defaultCommitMessage 
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:50 +05:30
Shivam bisht caa98d4d9e modified defaultCommitMessage 
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:50 +05:30
Shivam bisht 87b30f4efb added commitMessage to test file 
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:50 +05:30
mufaddal motiwala 44766e8f67 md fix 
Signed-off-by: mufaddal motiwala <mufaddalmm.52@gmail.com>
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:50 +05:30
Shivam bisht 8a7d4444e3 Added default commit message 
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
 2022-03-22 18:32:49 +05:30
github-actions[bot] ad955c1b1b Version Packages (next) 2022-03-22 12:28:03 +00:00
Camila Belo 2f04424190 Merge pull request #10311 from backstage/techdocs-fix-permalink-scrolling 
[TechDocs] Fix permalink scrolling
 2022-03-22 07:35:24 +01:00
Mike Lewis 71f8708f00 jenkins: make resourceRef required in JenkinsApi#buildProject 
This method is only called in one place outside tests, and the
resourceRef is guaranteed to be set there, so we can tighten this
typing up a bit to make the value mandatory.

This class is not exported by the package, so this can be shipped as
a patch change.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-21 18:12:17 -04:00
Fredrik Adelöw 3d15619d49 Merge pull request #10287 from AaronvDiepen/master 
Implement code changes as suggested by analysis tools
 2022-03-21 19:51:32 +01:00
Fredrik Adelöw b6af1b73fc Merge pull request #10061 from backstage/blam/next-scaffolder-frontend 
Introduce the `next` scaffolder frontend
 2022-03-21 17:01:54 +01:00
Fredrik Adelöw c0e9864d27 Merge pull request #10244 from backstage/dependabot/npm_and_yarn/ajv-8.10.0 
build(deps): bump ajv from 7.0.3 to 8.10.0
 2022-03-21 16:40:54 +01:00
Fredrik Adelöw 43d323c917 Merge pull request #10325 from backstage/freben/providers 
Add to contrib: `ImmediateEntityProvider`, `LoadTestingEntityProvider`
 2022-03-21 14:28:11 +01:00
Fredrik Adelöw 2651fa8db4 Merge pull request #10341 from backstage/freben/cherry-blossom-auth-backend 
Apply #10338
 2022-03-21 14:22:31 +01:00
Fredrik Adelöw 3b4e2d560a Merge pull request #10336 from backstage/dependabot/npm_and_yarn/react-use-17.3.2 
build(deps): bump react-use from 17.2.4 to 17.3.2
 2022-03-21 14:21:32 +01:00
Fredrik Adelöw 2cc1d1b235 apply fix here too 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-21 13:53:35 +01:00
Fredrik Adelöw ff4f1b6f51 make sure to apply tz column fix for newly created backstage instances 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-21 13:50:41 +01:00
Fredrik Adelöw 9c6e849d1c make the act() expecting test more robust to variations, and fix missing await 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-21 13:43:39 +01:00
dependabot[bot] e0a51384ac build(deps): bump ajv from 7.0.3 to 8.10.0 
Bumps [ajv](https://github.com/ajv-validator/ajv) from 7.0.3 to 8.10.0.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v7.0.3...v8.10.0)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-21 10:32:49 +01:00
Fredrik Adelöw 95408dbe99 Add to contrib: ImmediateEntityProvider, LoadTestingEntityProvider 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-19 16:13:14 +01:00
Andre Wanlin ed09652184 Fixed wording 
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
 2022-03-18 13:20:23 -05:00
Andre Wanlin 2fe58c7285 Improved Tech-Insights documentation 
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
 2022-03-18 13:13:20 -05:00
Eric Peterson f9653d19eb Merge pull request #10305 from backstage/techdocs/no-cache-head 
[TechDocs] Fix HEAD request cache bug
 2022-03-18 17:52:45 +01:00
Camila Belo 3b7f1ef418 test: cover anchor starting with number 
Signed-off-by: Camila Belo <camilaibs@gmail.com>
 2022-03-18 16:34:30 +01:00