Commit Graph

317 Commits

Author SHA1 Message Date
github-actions[bot] b228d7d9c2 Version Packages
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-09-20 11:24:40 +02:00
github-actions[bot] a6d1580062 Version Packages (next) 2023-09-12 11:41:29 +00:00
Patrik Oldsberg cb7fc410ed backend-app-api: make feature discovery only discovery default exports
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-09-07 18:52:34 +02:00
Patrik Oldsberg 3b30b179cb backend-app-api: add support for adding module imports
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-09-07 18:52:34 +02:00
Fredrik Adelöw ba4506076e Ensure that root scoped services cannot accept (at a type level) plugin scoped deps
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2023-09-07 14:09:41 +02:00
Patrik Oldsberg 154632d875 backend-app-api: add support for discoverying additional service factories
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-09-06 13:30:34 +02:00
github-actions[bot] 32a09adcff Version Packages (next) 2023-09-05 10:03:17 +00:00
Patrik Oldsberg 56c4216dbf Merge pull request #19654 from backstage/rugvip/service-tester
backend-test-utils: add ServiceFactoryTester utility
2023-08-30 20:11:02 +02:00
Jack Palmer 7a821e9618 Merge pull request #19674 from UsainBloot/jackpalmer/feature-discovery-package-targetting
backend-app-api: Feature Discovery - include, exclude & alpha modules
2023-08-30 17:14:13 +01:00
Patrik Oldsberg b7ceb86a07 backend-app-api: minor ServiceRegistry.create refactor
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-30 17:48:33 +02:00
Patrik Oldsberg 6cc775b8c2 backend-test-utils: some ServiceFactoryTester tweaks
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-30 17:45:53 +02:00
Patrik Oldsberg 0423c1d0d9 backend-app-api: migrate tests to use ServiceFactoryTester
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-30 17:45:53 +02:00
Patrik Oldsberg 153b091040 Merge pull request #19268 from marleypowell/marley/19264-circular-dependency-fix
fix: 🐛 implemented a circular dependency check in the ServiceRegistry
2023-08-30 17:43:25 +02:00
Jack Palmer 0b99b64b6c chore: Remove unused exception param
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 16:27:44 +01:00
Jack Palmer 866185e516 chore: Change wording of logging
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 16:24:30 +01:00
Jack Palmer ee7566fc4f chore: Address pr feedback
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 16:23:06 +01:00
Jack Palmer 5f9205767b chore: Add logging to discovery
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 16:16:45 +01:00
Jack Palmer 855cf4082f fix: linting
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 15:26:20 +01:00
Jack Palmer 68c4031069 feat: Discovery alpha exports
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 15:26:20 +01:00
Jack Palmer 032622bdcb feat: Add include and exclude to backend.packages discovery
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 15:26:20 +01:00
Jack Palmer eaba7ba1bd fix: backend-plugin-module role
Signed-off-by: Jack Palmer <jackpalmer@spotify.com>
2023-08-30 15:26:20 +01:00
David Festal 3fc64b9e2f Index features on id instead of object.
This will allow features added from an external package location
to be loaded correctly.,
without the requirement of making backstage packages singletons.

Signed-off-by: David Festal <dfestal@redhat.com>
2023-08-29 17:42:15 +02:00
github-actions[bot] fc1a38bc57 Version Packages (next) 2023-08-29 12:18:08 +00:00
Marley Powell 5c29b98d30 refactor: implemented code review suggestions
Signed-off-by: Marley Powell <marley.powell@exclaimer.com>
2023-08-24 14:31:36 +01:00
Eric Peterson f5cdb61269 Add maintainer-owned catalog-info.yaml files
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2023-08-23 18:02:53 +02:00
github-actions[bot] f8c8e8de37 Version Packages (next) 2023-08-22 11:37:48 +00:00
Marley Powell 8ba316e287 fix: 🐛 implemented up front circular dependency check in the BackendInitializer
Signed-off-by: Marley Powell <marley.powell@exclaimer.com>
2023-08-18 11:38:22 +01:00
Marley Powell bef7098987 feat: updated DependencyGraph to deduplicate the second occurence of a circular cycle
Signed-off-by: Marley Powell <marley.powell@exclaimer.com>
2023-08-18 10:30:48 +01:00
Marley Powell 51d21f22c9 refactor: ♻️ updated ServiceRegistry to use DependencyGraph for circular dependency checks
Signed-off-by: Marley Powell <marley.powell@exclaimer.com>
2023-08-17 12:12:01 +01:00
Marley Powell 1d12a7fa7d fix: 🐛 updated detectCircularDependency in DependencyGraph to return circular dependencies starting from the first node
Signed-off-by: Marley Powell <marley.powell@exclaimer.com>
2023-08-17 11:59:01 +01:00
Marley Powell 7a4ef5aff5 Merge remote-tracking branch 'origin/master' into marley/19264-circular-dependency-fix 2023-08-17 11:17:15 +01:00
github-actions[bot] aaf5cb2ca1 Version Packages 2023-08-15 17:12:48 +00:00
Vincenzo Scamporlino 09fea35cd1 backend-app-api: use provided service factories
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino f66d490332 backend-test-utils: remove services from startTestBackend
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino 175e4c3516 api-reports
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino 6e7a1b07f3 backend-app-api: keep track of the provided services
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino 263f6be4f6 backend-app-api: keep ServiceRegistry immutable
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino 0c1f57b6b6 backend-app-api: add missing check for pluginMetadata service
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino b10bf736d0 backend-app-api: accepts service factory as feature
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:12 +02:00
Vincenzo Scamporlino 90fdcfb403 backend-app-api: add methods accepts a backend feature factory
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:11 +02:00
Vincenzo Scamporlino 108728f5fe backend-app-api: add add method to ServiceRegistry
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:11 +02:00
Vincenzo Scamporlino 966e376056 backend-app-api: rename services option to defaultServiceFactories
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2023-08-15 17:47:11 +02:00
Patrik Oldsberg a796cc04e7 Merge pull request #19354 from backstage/rugvip/ep-check
backend-app-api: validate extension point deps
2023-08-14 15:05:46 +02:00
Patrik Oldsberg ea706fd0f3 Merge pull request #19337 from backstage/rugvip/module-extensions
backend-plugin-api: allow modules to register extension points
2023-08-14 14:34:56 +02:00
Patrik Oldsberg 1fb03402ea backend-app-api: make sure DependencyGraph.findUnsatisfiedDeps doesn't break on circular deps
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-14 14:03:24 +02:00
Patrik Oldsberg d197f13172 backend-app-api: restructure DependencyGraph tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-14 14:01:00 +02:00
Patrik Oldsberg 57a10c6c69 backend-app-api: validate extension point deps
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-12 14:04:59 +02:00
Patrik Oldsberg c49785f00c backend-app-api: disallow required service factory options
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-11 17:22:16 +02:00
Patrik Oldsberg b7e0362496 backend-app-api: some docs for DependencyGraph
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-11 15:17:07 +02:00
Patrik Oldsberg afe320acec backend-app-api: rename DependencyTree -> DependencyGraph
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2023-08-11 15:17:07 +02:00