Commit Graph

31 Commits

Author SHA1 Message Date
Himanshu Mishra c1d6bc03f6 Vale: Enforce vale to be run on CI 2020-10-14 11:16:23 +02:00
Himanshu Mishra 3b17fa02f8 Vale: Use files provided by lint staged to check 2020-10-14 11:07:56 +02:00
Himanshu Mishra 689b2f50e5 Run vale linter only if vale is installed 2020-10-12 15:38:34 +02:00
Mayursinh Sarvaiya 5c6a0356c0 feat: TechDocs - Add vale linter to check words quality in md files. (#2631)
* fix(docs): typos which were reflacted from vale linter's command

* feat: Implement Vale linter (#2031)
Initialize .vale.ini file
Add 'lint:docs' script to package.json, to lint all md files except the ones which are located in node_modules
Generate 'vocab.txt' by using command 'yarn run lint:docs' | grep -o ''[a-z A-Z]*'' | grep -o '[a-z A-Z]*' | sort | uniq > .github/styles/vocab.txt
Add steps to github workflow 'master' to check docs quality

* chore: Separate workflow for quality checking

* chore: Added 'shx' dev dependency to support grep command in cross platform

* feat: Add script to operate same quality check process on different platform

* ignore: remove lint:docs from lint-stages which was added for experiment purpose

* fix: check-all-files on push event & check-changed-files on pull_request event

* chore(CI): triggle workflow only when there is any updates in .md file(s) on pull request

* fix: use spawnSync to solve 'The command line is too long.' error

* fix: github workflow syntax

* fix: prettier error

* chore: add vale command directly to lint-staged

* chore: use shebang for easy access

* fix: windows script issue & remove shebang

* chore: Add shebang flag

* chore: better error message related to vale

* chore: mention vale linter in documentation

* fix: spelling errors & add keywords to vocab.txt
2020-10-02 07:20:47 +02:00
Patrik Oldsberg fd7c93db6c Revert "chore(deps): prepare us to typescript 4"
This reverts commit 82ba3169fe.
2020-08-31 11:36:50 +02:00
Fredrik Adelöw 82ba3169fe chore(deps): prepare us to typescript 4 2020-08-31 10:46:56 +02:00
Patrik Oldsberg 067d44181b scripts/check-type-dependencies: only verify type deps for packages that have been built 2020-06-01 17:00:50 +02:00
Patrik Oldsberg 25a4d6ed6b scripts: added check-type-dependencies 2020-06-01 12:26:58 +02:00
Patrik Oldsberg d70337eb53 scripts: move cli-e2e-test to packages/cli/e2e-test 2020-04-16 19:38:01 +02:00
Patrik Oldsberg e522989249 github/workflows,scripts/cli-e2e-test: use runner temp dir instead of generated dir 2020-04-16 19:06:11 +02:00
Patrik Oldsberg 7a320302c1 scripts/cli-e2e-test: refactor path handling a bit 2020-04-16 18:54:50 +02:00
Patrik Oldsberg be0881ff35 scripts/cli-e2e-test: removed yarn init 2020-04-16 18:46:30 +02:00
Marcus Eide 99c2c5879e Export helper methods differently 2020-04-16 15:31:14 +02:00
Marcus Eide 99986cfc11 Fix path for cli cmd and add debug logs 2020-04-16 15:23:38 +02:00
Marcus Eide 3eca6cc9d5 Change name of env variable used in script 2020-04-16 15:00:21 +02:00
Marcus Eide ed32b1d161 Properly change to temp directory 2020-04-16 09:57:35 +02:00
Marcus Eide 300a891f71 Create new app in temp dir 2020-04-16 08:50:11 +02:00
Marcus Eide ceb716c3b4 Add create-app to e2e and move common functionality into seperate modules 2020-04-15 20:58:12 +02:00
Patrik Oldsberg ad977c10dd scripts/cli-e2e-test: fixed some flakiness (#493) 2020-04-07 11:10:31 +02:00
Paul Marbach 32072ad429 chore: use eslint-config-oss 2020-04-03 16:28:10 -04:00
Patrik Oldsberg 43a523cc58 script/cli-e2e-test: better error output when page load fails 2020-04-01 18:24:23 +02:00
Fredrik Adelöw 1d3a8c110c Better waiting 2020-03-23 14:32:41 +01:00
Fredrik Adelöw 9d977ccb9c Fix act() warnings on newly created plugin test run 2020-03-23 14:32:41 +01:00
Fredrik Adelöw 263199da55 Merge pull request #340 from spotify/freben/codeowners
[cli] Add CODEOWNERS support to create-plugin
2020-03-23 08:52:15 +01:00
Patrik Oldsberg 3195e2f2c4 eslint: move copyright template to separate file 2020-03-22 21:52:06 +01:00
Fredrik Adelöw 231c991fe0 Address review comments 2020-03-22 21:49:31 +01:00
Patrik Oldsberg d4f587fdbe Merge pull request #304 from spotify/rugvip/cli-helpers
cli: add helpers for running child processes and error handling in commands
2020-03-18 16:07:15 +01:00
Patrik Oldsberg a60bfc31d9 script/cli-e2e-test: error out if child exits early 2020-03-18 15:53:16 +01:00
Fredrik Adelöw 72bbbfd243 Require plugin IDs to be valid 2020-03-18 15:45:05 +01:00
Patrik Oldsberg 3772c82beb cli: use shell option to fix build issues on windows 2020-03-17 20:40:48 +01:00
Patrik Oldsberg 9850aaeca7 added scripts dir with test for making sure serve and plugin scaffolding works 2020-03-10 13:37:13 +01:00