Commit Graph

10656 Commits

Author SHA1 Message Date
Eric Peterson 39a6eda01d Review feedback 2: electric boogaloo
Co-authored-by: Otto Sichert <git@ottosichert.de>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-12 15:37:29 +02:00
Eric Peterson a357c354af Do not use @alpha type in @public export
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-12 13:07:58 +02:00
Eric Peterson 3fde9ea637 Merge branch 'master' into techdocs/addon-integration
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-12 11:36:59 +02:00
Eric Peterson ca4420782c Review feedback.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-12 11:25:25 +02:00
Otto Sichert 1f51e960af Update draft comment for COMPONENT TechDocs location
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-12 11:11:04 +02:00
Johan Haals 4e74532566 Merge pull request #10752 from backstage/emmaindal/search-react
[Search] introduce a new search-react package.
2022-04-12 11:08:21 +02:00
Otto Sichert 9c576e803b Make entity metadata exports private in TechDocs
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-12 11:06:41 +02:00
Otto Sichert a424baae87 Move TechDocs Subheader props to reduce API report
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-12 10:29:27 +02:00
Otto Sichert 55c9f867a2 Downgrade @testing-library/react to resolve dependency conflict in tests
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-12 10:27:27 +02:00
Shivam bisht 86a7c4bc5c added input label for GitlabRepoPicker
Signed-off-by: Shivam bisht <shvmbisht@gmail.com>
2022-04-12 12:36:36 +05:30
Emma Indal b7d035cc29 feedback fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 17:11:52 +02:00
Otto Sichert 883ab7228a Moved shared TechDocs utilities from plugin-techdocs to plugin-techdocs-react
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-11 17:06:32 +02:00
Otto Sichert b05870bcb7 Move @backstage/techdocs-addons to @backstage/plugin-techdocs-react
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-11 16:13:07 +02:00
Otto Sichert 4e489d10db Move GiveFeedbackAddon out of initial branch merge
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-11 15:40:30 +02:00
Fredrik Adelöw f4cdf4cac1 Defensively encode URL parameters when fetching ELB keys
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-04-11 15:06:35 +02:00
Emma Indal ab230a433f add changesets
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 14:37:54 +02:00
Fredrik Adelöw 8bda364ece Merge pull request #10428 from spreadshirt/kubernetes-cluster-refresh
Make Kubernetes clusters refreshable
2022-04-11 14:21:15 +02:00
Fredrik Adelöw 2c92727d36 Merge pull request #10584 from LvffY/master
[#10582] Use getEntitySourceLocation instead of custom method to get the entity source URL
2022-04-11 14:13:16 +02:00
Emma Indal c64c33f74b dependency and docs fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 13:52:04 +02:00
Emma Indal 6a4f081128 let template logos live in home plugin for now
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 12:08:29 +02:00
Eric Peterson b90722229b Replace <Example* /> examples in app with <GiveFeedbackAddon /> (and add repo/edit for fixture docs sites).
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 12:05:05 +02:00
Eric Peterson 65c0c3e628 Add subheader back to app reader.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 12:04:59 +02:00
Emma Indal a39a931b39 search api report
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:43:22 +02:00
Emma Indal 301b4606e3 import from new search-react package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:42:57 +02:00
Emma Indal 09cba0bdae deprecate search api ref, search api interface and search context in plugin-search
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:41:59 +02:00
Emma Indal bc31ff1bbd move home default template story to the app
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:40:20 +02:00
Emma Indal c4baa24009 introduce new search-react package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:37:33 +02:00
Eric Peterson 6a96ba0eaa Using version-bridge for the TechDocs Reader Page context.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 11:05:33 +02:00
Luna Stadler 2fc0e86616 Move refresh handling into KubernetesClustersSupplier implementations
Signed-off-by: Luna Stadler <luc@spreadshirt.net>
2022-04-11 10:53:12 +02:00
Emma Indal d26e1b0146 [TechDocs Addons] Give Feedback Addon (#10733)
* give feedback addon implementation

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export replaceUrlType from @backstage/integration-reacte

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export give feedback addon

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* add hooks used for give feedback addon

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* replaceUrlType -> replaceGitLabUrlType

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* clarify template + template builder types

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* feedback fixups

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
2022-04-11 08:55:54 +02:00
Fredrik Adelöw e9b48b20c9 Merge pull request #10702 from angeliski/add-check-id
Add checksId option to EntityTechInsightsScorecardContent component
2022-04-09 15:40:55 +02:00
dependabot[bot] f26cf63878 build(deps-dev): bump @types/jest-when from 2.7.2 to 3.5.0
Bumps [@types/jest-when](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest-when) from 2.7.2 to 3.5.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest-when)

---
updated-dependencies:
- dependency-name: "@types/jest-when"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-09 12:31:58 +00:00
Emma Indal 88fd7d1e55 rebase fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 14:28:45 +02:00
Fredrik Adelöw 3b65fc11e4 Merge pull request #10532 from brethubbard/index-group-display-name
Search: Index group display name in DefaultCatalogCollatorFactory
2022-04-09 14:25:55 +02:00
Rogerio Angeliski c2b79c12de Update docs to refer new prop
Signed-off-by: Rogerio Angeliski <angeliski@hotmail.com>
2022-04-09 09:22:36 -03:00
Emma Indal b4ed5c1226 remove duplicated dependency
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:28 +02:00
Emma Indal e315a3b154 add TechDocsReaderPage tests
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Eric Peterson f04b458bbc Resolve or clarify simpler todos in techdocs-addons
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:47:02 +02:00
Camila Belo 68f49e4ac6 fix(techdocs): scroll flickering when navigating
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal a122923bd0 api-reports and prettier
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal c969da2fcd fix techdocs-cli embedded app
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 914cfdb0b7 fix(techdocs): update api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 2605805cb5 fix(techdocs): embed cli app reader
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 3fdc1b4f71 fix(techdocs): add backwards compatibility
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 6412209815 fix(techdocs): fix page re-renders
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 5ad229a24b fix(techdocs): entity page links
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:00 +02:00
Camila Belo e0dc1e8ccd tests(techdocs): fix broken tests
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:47 +02:00
Camila Belo 236089c6cd feat(techdocs): delete addons plugin
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:47 +02:00
Camila Belo fbc5c68d91 feat(techdocs): merge reader components
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:10 +02:00
Eric Peterson ace749b785 Allow addons (except header location) to be used in Entity Reader
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:46:10 +02:00