ee60ad9ea4
Do not require double-nesting of custom TechDocs readers.
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-15 16:41:28 +02:00
82124f1837
Fix subheader positioning
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-15 16:39:17 +02:00
39a6eda01d
Review feedback 2: electric boogaloo
...
Co-authored-by: Otto Sichert <git@ottosichert.de >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-12 15:37:29 +02:00
3fde9ea637
Merge branch 'master' into techdocs/addon-integration
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-12 11:36:59 +02:00
9c576e803b
Make entity metadata exports private in TechDocs
...
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-12 11:06:41 +02:00
a424baae87
Move TechDocs Subheader props to reduce API report
...
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-12 10:29:27 +02:00
883ab7228a
Moved shared TechDocs utilities from plugin-techdocs to plugin-techdocs-react
...
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-11 17:06:32 +02:00
b05870bcb7
Move @backstage/techdocs-addons to @backstage/plugin-techdocs-react
...
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-11 16:13:07 +02:00
4e489d10db
Move GiveFeedbackAddon out of initial branch merge
...
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-11 15:40:30 +02:00
65c0c3e628
Add subheader back to app reader.
...
Co-authored-by: Anders Näsman <andersn@spotify.com >
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-11 12:04:59 +02:00
301b4606e3
import from new search-react package
...
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-04-11 11:42:57 +02:00
6a96ba0eaa
Using version-bridge for the TechDocs Reader Page context.
...
Co-authored-by: Anders Näsman <andersn@spotify.com >
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-11 11:05:33 +02:00
d26e1b0146
[TechDocs Addons] Give Feedback Addon ( #10733 )
...
* give feedback addon implementation
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Anders Näsman <andersn@spotify.com >
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* export replaceUrlType from @backstage/integration-reacte
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Anders Näsman <andersn@spotify.com >
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* export give feedback addon
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* add hooks used for give feedback addon
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Anders Näsman <andersn@spotify.com >
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* replaceUrlType -> replaceGitLabUrlType
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* clarify template + template builder types
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
* feedback fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Anders Näsman <andersn@spotify.com >
2022-04-11 08:55:54 +02:00
e315a3b154
add TechDocsReaderPage tests
...
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-04-09 13:47:02 +02:00
f04b458bbc
Resolve or clarify simpler todos in techdocs-addons
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-09 13:47:02 +02:00
68f49e4ac6
fix(techdocs): scroll flickering when navigating
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:02 +02:00
a122923bd0
api-reports and prettier
...
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Eric Peterson <ericpeterson@spotify.com >
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-04-09 13:47:02 +02:00
c969da2fcd
fix techdocs-cli embedded app
...
Co-authored-by: Camila Belo <camilaibs@gmail.com >
Co-authored-by: Eric Peterson <ericpeterson@spotify.com >
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-04-09 13:47:02 +02:00
914cfdb0b7
fix(techdocs): update api reports
...
Co-authored-by: Emma Indal <emma.indahl@gmail.com >
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:02 +02:00
2605805cb5
fix(techdocs): embed cli app reader
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:02 +02:00
3fdc1b4f71
fix(techdocs): add backwards compatibility
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:02 +02:00
6412209815
fix(techdocs): fix page re-renders
...
Co-authored-by: Emma Indal <emma.indahl@gmail.com >
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Otto Sichert <git@ottosichert.de >
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:02 +02:00
5ad229a24b
fix(techdocs): entity page links
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:47:00 +02:00
e0dc1e8ccd
tests(techdocs): fix broken tests
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:46:47 +02:00
fbc5c68d91
feat(techdocs): merge reader components
...
Co-authored-by: Emma Indal <emma.indahl@gmail.com >
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-04-09 13:46:10 +02:00
ace749b785
Allow addons (except header location) to be used in Entity Reader
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-09 13:46:10 +02:00
10a7736ced
Testbed to help iterate on addons + correct dependency graph
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-09 13:46:08 +02:00
bff981c780
Merge pull request #10345 from RoadieHQ/fix-techdocs-query-selectors
...
Fix broken querySelectors on techdocs
2022-04-01 10:41:11 +02:00
179b5070fc
fix(techdocs): apply review suggestion
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 16:12:47 +02:00
e8d84d2ee6
fix(techdocs): use sidebar config
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 13:45:00 +02:00
49f646a9c9
fix(techdocs): drawer toggle margins
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 10:52:32 +02:00
bf4d052897
fix(techdocs): code block margins
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 10:52:32 +02:00
52708317f9
fix(techdocs): inner content width
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 10:52:32 +02:00
e56bcbfb0c
fix(techdocs): footer link width
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 10:52:32 +02:00
216c262bf2
fix(techdocs): mobile sidebar width
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-28 10:52:32 +02:00
e2cfd53847
techdocs: update client test to work with jsdom environment
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-25 11:28:16 +01:00
f0fb9153b7
Fix broken querySelectors on techdocs
...
This change fixes the broken pattern for selecting DOM elements to scroll to.
Previously it had error messages like so:
```
Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '#fn:someidtag' is not a valid selector.
```
This did not bode well with the techdocs integration with footnotes.
The query has now changed to include something that is expected by the DOM queries.
Signed-off-by: Nicolas Arnold <nic@roadie.io >
2022-03-22 09:05:35 +00:00
3b7f1ef418
test: cover anchor starting with number
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-18 16:34:30 +01:00
f90ffdc84e
fix: permalink scroll for enumerated anchors
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-03-18 15:08:36 +01:00
c689d7a94c
catalog: group, rename, and move filter components to catalog-react
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-16 15:10:41 +01:00
6565f2c50b
Merge pull request #10147 from rex4539/typos
...
Fix typos
2022-03-15 11:01:46 +01:00
b44692890b
tests fixups
...
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-03-14 22:39:18 +01:00
7cb5788e9c
clean up deprecations of techdocs plugin
...
Signed-off-by: Emma Indal <emma.indahl@gmail.com >
2022-03-14 22:39:17 +01:00
90f145fbce
Merge pull request #9944 from realandersn/andersn/fix-techdocs-sidebar-scroll
...
[Techdocs] fix sidebar scroll
2022-03-14 14:40:44 +01:00
aedd4daa66
Fix typos
...
Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com >
2022-03-13 14:12:05 +02:00
d3e9ec43b7
catalog-model: Remove target from EntityRelation type.
...
Signed-off-by: Johan Haals <johan.haals@gmail.com >
2022-03-10 16:15:12 +01:00
275e7ba746
Merge pull request #10001 from backstage/rugvip/nouser
...
catalog-react: removed useOwnUser
2022-03-05 09:14:34 +01:00
7a1dbe6ce9
techdocs: remove custom ownership handling
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-04 16:23:14 +01:00
fc6290a76d
catalog-react: removed useOwnUser
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2022-03-04 16:03:51 +01:00
7af635f2af
Merge branch 'master' into jhaals/dep-favoriteEntityTooltip
2022-03-03 14:23:35 +01:00
Eric Peterson