Commit Graph

10613 Commits

Author SHA1 Message Date
Otto Sichert 4e489d10db Move GiveFeedbackAddon out of initial branch merge
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-11 15:40:30 +02:00
Eric Peterson b90722229b Replace <Example* /> examples in app with <GiveFeedbackAddon /> (and add repo/edit for fixture docs sites).
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 12:05:05 +02:00
Eric Peterson 65c0c3e628 Add subheader back to app reader.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 12:04:59 +02:00
Eric Peterson 6a96ba0eaa Using version-bridge for the TechDocs Reader Page context.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 11:05:33 +02:00
Emma Indal d26e1b0146 [TechDocs Addons] Give Feedback Addon (#10733)
* give feedback addon implementation

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export replaceUrlType from @backstage/integration-reacte

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export give feedback addon

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* add hooks used for give feedback addon

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* replaceUrlType -> replaceGitLabUrlType

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* clarify template + template builder types

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* feedback fixups

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
2022-04-11 08:55:54 +02:00
Emma Indal 88fd7d1e55 rebase fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 14:28:45 +02:00
Emma Indal b4ed5c1226 remove duplicated dependency
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:28 +02:00
Emma Indal e315a3b154 add TechDocsReaderPage tests
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Eric Peterson f04b458bbc Resolve or clarify simpler todos in techdocs-addons
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:47:02 +02:00
Camila Belo 68f49e4ac6 fix(techdocs): scroll flickering when navigating
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal a122923bd0 api-reports and prettier
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal c969da2fcd fix techdocs-cli embedded app
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 914cfdb0b7 fix(techdocs): update api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 2605805cb5 fix(techdocs): embed cli app reader
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 3fdc1b4f71 fix(techdocs): add backwards compatibility
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 6412209815 fix(techdocs): fix page re-renders
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 5ad229a24b fix(techdocs): entity page links
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:00 +02:00
Camila Belo e0dc1e8ccd tests(techdocs): fix broken tests
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:47 +02:00
Camila Belo 236089c6cd feat(techdocs): delete addons plugin
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:47 +02:00
Camila Belo fbc5c68d91 feat(techdocs): merge reader components
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:10 +02:00
Eric Peterson ace749b785 Allow addons (except header location) to be used in Entity Reader
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:46:10 +02:00
Anders Näsman 413024e182 add test-utils
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Anders Näsman <andersn@spotify.com>
2022-04-09 13:46:10 +02:00
Emma Indal 5c86f3e2b7 downgrade test utils package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:46:10 +02:00
Emma Indal 4f9de91af5 update tests based on implementation changes
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:46:10 +02:00
Eric Peterson 10a7736ced Testbed to help iterate on addons + correct dependency graph
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:46:08 +02:00
Emma Indal 0b67af3485 Write tests for hooks
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:44:50 +02:00
Emma Indal 42cc7e5991 Split hooks into separate file
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:44:50 +02:00
Emma Indal f0a3055d17 add tests for useEntityMetadata, useTechDocsMetadata, useTechDocsReaderPage
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:44:50 +02:00
Eric Peterson e328e3d31b Make utility hook responses async, allowing addons to handle errors independently.
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:44:50 +02:00
Eric Peterson d8db6db3d7 Review feedback.
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:44:50 +02:00
Eric Peterson ff1cc8bced Expose an alternative, add-on-aware read component and hooks.
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>
Co-authored-by: Anders Näsman <andersn@spotify.com>

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:44:47 +02:00
Eric Peterson 30d2ca2669 Allow addons to be created and registered.
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:43:46 +02:00
Eric Peterson 19c0db60aa Initial package to encapsulate the TechDocs addon framework.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:43:46 +02:00
Fredrik Adelöw 2888d41a0b Merge pull request #10717 from RoadieHQ/add-grpc-api-definition-widget
add dedicated grpc api widget
2022-04-08 21:11:17 +02:00
Fredrik Adelöw f1895929b8 Merge pull request #10675 from backstage/unregister-location-implicit-delete
Update behavior when unregistering locations from `UnregisterEntityDialog`
2022-04-08 20:59:45 +02:00
Kiss Miklos eb85cd5fac use explicit type for props
Signed-off-by: Kiss Miklos <miklos@roadie.io>
2022-04-08 16:09:59 +02:00
Fredrik Adelöw 9b8fa1972e Merge pull request #10548 from julioz/gocd-analytics
Add DORA metrics insights to GoCD builds page
2022-04-08 15:36:32 +02:00
Andre Wanlin 776a91ea3a Corrected title and URL to setup documentation
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
2022-04-08 07:10:25 -05:00
Johan Haals 52768fe181 Merge pull request #10697 from Bonial-International-GmbH/PJ_awsS3_handle-zero-integrations
feat: handle potential future case of no awsS3 integration
2022-04-08 13:42:56 +02:00
Patrick Jungermann 3f801d1279 feat: handle potential future case of no awsS3 integration
Relates-to: PR #10480
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
2022-04-08 12:50:14 +02:00
Vincenzo Scamporlino 63902fcc17 PermissionEvaluator: rename query to authorizeConditional
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:29:00 +02:00
Vincenzo Scamporlino 6ca16bdf2d Apply suggestions from code review
Co-authored-by: Joe Porpeglia <josephp@spotify.com>
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:29:00 +02:00
Vincenzo Scamporlino b4af8664b5 api report and minor fixes
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:29:00 +02:00
Vincenzo Scamporlino 173aadff5b Avoid PermissionEvaluator breaking changes
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:29:00 +02:00
Vincenzo Scamporlino 8b27170d30 search-backend: Use PermissionEvaluator instead of PermissionAuthorizer
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00
Vincenzo Scamporlino 8f4792a196 Mark PermissionAuthorizer as deprecated
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00
Vincenzo Scamporlino 6dd85d588a catalog-backend: use new PermissionEvaluator instead of PermissionAuthorizer
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00
Vincenzo Scamporlino 1917923ab8 Jenkins: use PermissionEvaluator instead of PermissionAuthorizer
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00
Vincenzo Scamporlino a119dfbbd5 Apply suggestions from code review
Co-authored-by: Joe Porpeglia <josephp@spotify.com>
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00
Vincenzo Scamporlino e7f28d8152 IdentityPermissionApi: strict typing
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-04-08 12:28:59 +02:00