Commit Graph

722 Commits

Author SHA1 Message Date
Otto Sichert 4e489d10db Move GiveFeedbackAddon out of initial branch merge
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-04-11 15:40:30 +02:00
Eric Peterson 65c0c3e628 Add subheader back to app reader.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 12:04:59 +02:00
Eric Peterson 6a96ba0eaa Using version-bridge for the TechDocs Reader Page context.
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-11 11:05:33 +02:00
Emma Indal d26e1b0146 [TechDocs Addons] Give Feedback Addon (#10733)
* give feedback addon implementation

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export replaceUrlType from @backstage/integration-reacte

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* export give feedback addon

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* add hooks used for give feedback addon

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* replaceUrlType -> replaceGitLabUrlType

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* clarify template + template builder types

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* feedback fixups

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Anders Näsman <andersn@spotify.com>
2022-04-11 08:55:54 +02:00
Emma Indal 88fd7d1e55 rebase fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 14:28:45 +02:00
Emma Indal b4ed5c1226 remove duplicated dependency
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:28 +02:00
Emma Indal e315a3b154 add TechDocsReaderPage tests
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Eric Peterson f04b458bbc Resolve or clarify simpler todos in techdocs-addons
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:47:02 +02:00
Camila Belo 68f49e4ac6 fix(techdocs): scroll flickering when navigating
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal a122923bd0 api-reports and prettier
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Emma Indal c969da2fcd fix techdocs-cli embedded app
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 914cfdb0b7 fix(techdocs): update api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 2605805cb5 fix(techdocs): embed cli app reader
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 3fdc1b4f71 fix(techdocs): add backwards compatibility
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 6412209815 fix(techdocs): fix page re-renders
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:02 +02:00
Camila Belo 5ad229a24b fix(techdocs): entity page links
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:47:00 +02:00
Camila Belo e0dc1e8ccd tests(techdocs): fix broken tests
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:47 +02:00
Camila Belo fbc5c68d91 feat(techdocs): merge reader components
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-04-09 13:46:10 +02:00
Eric Peterson ace749b785 Allow addons (except header location) to be used in Entity Reader
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:46:10 +02:00
Eric Peterson 10a7736ced Testbed to help iterate on addons + correct dependency graph
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:46:08 +02:00
Eric Peterson ff1cc8bced Expose an alternative, add-on-aware read component and hooks.
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Otto Sichert <git@ottosichert.de>
Co-authored-by: Anders Näsman <andersn@spotify.com>

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-09 13:44:47 +02:00
Ben Lambert 38d6a4745c Merge pull request #10558 from backstage/blam/node16types
chore: @node/types -> 16.x
2022-04-06 15:47:21 +02:00
dependabot[bot] 24254fd433 build(deps): bump @testing-library/user-event from 13.5.0 to 14.0.0
Bumps [@testing-library/user-event](https://github.com/testing-library/user-event) from 13.5.0 to 14.0.0.
- [Release notes](https://github.com/testing-library/user-event/releases)
- [Changelog](https://github.com/testing-library/user-event/blob/main/CHANGELOG.md)
- [Commits](https://github.com/testing-library/user-event/compare/v13.5.0...v14.0.0)

---
updated-dependencies:
- dependency-name: "@testing-library/user-event"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-04-05 10:19:52 +02:00
github-actions[bot] 39e446d0ff Version Packages (next) 2022-04-05 07:35:01 +00:00
blam f4fd7f5400 chore: fixing the version numbers
Signed-off-by: blam <ben@blam.sh>
2022-04-04 16:01:28 +02:00
blam 2538bf72e3 chore: @node/types -> 16.x
Signed-off-by: blam <ben@blam.sh>
2022-04-04 16:01:06 +02:00
Fredrik Adelöw 9975ff9852 pin event-source-polyfill to 1.0.25
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-04-04 13:16:20 +02:00
Ben Lambert bff981c780 Merge pull request #10345 from RoadieHQ/fix-techdocs-query-selectors
Fix broken querySelectors on techdocs
2022-04-01 10:41:11 +02:00
github-actions[bot] e6f3fb8575 Version Packages (next) 2022-03-29 08:42:22 +00:00
Camila Belo 179b5070fc fix(techdocs): apply review suggestion
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 16:12:47 +02:00
Camila Belo e8d84d2ee6 fix(techdocs): use sidebar config
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 13:45:00 +02:00
Camila Belo 49f646a9c9 fix(techdocs): drawer toggle margins
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 10:52:32 +02:00
Camila Belo bf4d052897 fix(techdocs): code block margins
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 10:52:32 +02:00
Camila Belo 52708317f9 fix(techdocs): inner content width
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 10:52:32 +02:00
Camila Belo e56bcbfb0c fix(techdocs): footer link width
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 10:52:32 +02:00
Camila Belo 216c262bf2 fix(techdocs): mobile sidebar width
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-28 10:52:32 +02:00
Patrik Oldsberg e2cfd53847 techdocs: update client test to work with jsdom environment
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-03-25 11:28:16 +01:00
github-actions[bot] ad955c1b1b Version Packages (next) 2022-03-22 12:28:03 +00:00
Nicolas Arnold f0fb9153b7 Fix broken querySelectors on techdocs
This change fixes the broken pattern for selecting DOM elements to scroll to.

Previously it had error messages like so:
```
Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '#fn:someidtag' is not a valid selector.
```

This did not bode well with the techdocs integration with footnotes.

The query has now changed to include something that is expected by the DOM queries.

Signed-off-by: Nicolas Arnold <nic@roadie.io>
2022-03-22 09:05:35 +00:00
Camila Belo 3b7f1ef418 test: cover anchor starting with number
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-18 16:34:30 +01:00
Camila Belo f90ffdc84e fix: permalink scroll for enumerated anchors
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-03-18 15:08:36 +01:00
github-actions[bot] 0bc1611d6e Version Packages 2022-03-17 09:02:30 +00:00
Patrik Oldsberg c689d7a94c catalog: group, rename, and move filter components to catalog-react
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-03-16 15:10:41 +01:00
Fredrik Adelöw 6565f2c50b Merge pull request #10147 from rex4539/typos
Fix typos
2022-03-15 11:01:46 +01:00
Emma Indal da7d91fcdc api report fixup
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-03-14 22:39:19 +01:00
Emma Indal b44692890b tests fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-03-14 22:39:18 +01:00
Emma Indal 7cb5788e9c clean up deprecations of techdocs plugin
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-03-14 22:39:17 +01:00
Eric Peterson 90f145fbce Merge pull request #9944 from realandersn/andersn/fix-techdocs-sidebar-scroll
[Techdocs] fix sidebar scroll
2022-03-14 14:40:44 +01:00
Dimitris Apostolou aedd4daa66 Fix typos
Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2022-03-13 14:12:05 +02:00
Fredrik Adelöw fa2bd08033 Merge pull request #9800 from backstage/dependabot/npm_and_yarn/testing-library/react-12.1.3
chore(deps): bump @testing-library/react from 11.2.6 to 12.1.3
2022-03-11 11:25:56 +01:00