Commit Graph

528 Commits

Author SHA1 Message Date
Patrik Oldsberg 2462b9e275 backend-common: make sure readTree temp dirs are cleaned up
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-12-22 19:25:43 +01:00
Patrik Oldsberg beda508164 Merge pull request #8585 from backstage/rugvip/treeify
backend-common: clarify responsiblity of readTree directory deletion
2021-12-22 15:50:51 +01:00
MT Lewis 5f1333a60b Merge pull request #8357 from backstage/example-app-permission-integration
Example app permission integration
2021-12-22 14:32:25 +00:00
Patrik Oldsberg 2f6d8ec3b6 backend-common: clarify responsiblity of readTree directory deletion
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-12-22 15:06:49 +01:00
MT Lewis c1c7116f4b backend-common: improve error message in ServerTokenManager
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-12-21 10:08:19 +00:00
MT Lewis bc9a205b86 backend-common: remove isSecure property in favour of a property on the NoopServerTokenManager
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-12-21 10:04:04 +00:00
Joon Park f898c014ca Add explicit instance variable to denote the given token manager's scope of authentication
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:52:36 +00:00
Joon Park 816e0e04f9 Address various comments round 1
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:16:47 +00:00
Joon Park 24dce3ca43 Reintroduce noop token manager and refactor ServerPermissionClient
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:16:47 +00:00
Joon Park ea96ce2449 Change ServerTokenManager method name back to fromConfig
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:16:47 +00:00
Joon Park 2f8a9b665f Separate changesets
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:16:47 +00:00
Joon Park f786dc8140 Generate secret in development
Signed-off-by: Joon Park <joonp@spotify.com>
2021-12-17 18:16:46 +00:00
Fredrik Adelöw 3e79c4bc58 Merge pull request #8406 from prkeshri/7340-remote-config-fix
7340 remote config fix
2021-12-17 10:34:32 +01:00
Colton Padden 67d6cb3c7e remove deprecations packages/config-loader/src/loader.ts:63
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-12-16 08:32:01 -05:00
Joe Porpeglia 63f5bc5f2c Add connection.directory support for sqlite
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 18:00:04 -05:00
Joe Porpeglia d9a286bd56 Use path.join for tests
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 16:43:39 -05:00
Joe Porpeglia cf192e1a72 Check if sqlite filename was provided before making plugin-specific filename
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 16:43:39 -05:00
Joe Porpeglia ef8392dab2 Use path.join
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 16:43:39 -05:00
Joe Porpeglia e51369952e Add suffix to plugin sqlite db file
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 16:43:39 -05:00
Joe Porpeglia 189ba4c340 Overwrite sqlite filepath per plugin
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
2021-12-09 16:43:39 -05:00
Johan Haals 6ff2055519 Merge pull request #8383 from radoslaw-wielonski-nc/feat/add-custom-error-handler
Feat/add custom error handler
2021-12-08 16:48:22 +01:00
Radoslaw Wielonski aec2c96c88 docs: update documentation of disableDefaultErrorHandler method
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-08 15:13:37 +01:00
Radoslaw Wielonski 0105e3cd64 docs: update documentation of setErrorHandler method
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-08 15:11:07 +01:00
radoslaw-wielonski-nc d2ad94df97 Update packages/backend-common/src/service/types.ts
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-08 15:08:40 +01:00
Radoslaw Wielonski a07e0f5f06 docs: update documentation of setErrorHandler method
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-08 13:15:25 +01:00
Fredrik Adelöw 986a5d869e Merge pull request #8405 from backstage/freben/nounpack
Do not unpack arguments directly on exported items 🧹
2021-12-08 13:15:13 +01:00
Fredrik Adelöw dcd1a0c3f4 Do not unpack arguments directly on exported items
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-07 19:42:10 +01:00
Praveen Ranjan Keshri d5d69f1169 Merge branch 'backstage:master' into 7340-remote-config-fix 2021-12-07 22:46:46 +05:30
Johan Haals c869f6dbbe Merge pull request #8303 from backstage/eide/run-migrations
[backend-common]: Make it possible to skip database migrations
2021-12-07 15:09:32 +01:00
Marcus Eide dac55f3cc7 Make optional
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-07 12:44:16 +01:00
Radoslaw Wielonski 6026ebb680 refactor: use prototype to access private properties and avoid // @ts-ignore
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-07 12:24:14 +01:00
Radoslaw Wielonski 06d80ac7a6 refactor: remove ts-ignore comments from tests
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-07 12:02:58 +01:00
Radoslaw Wielonski 5a59f5507e feat: add flag for default error handler
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-07 11:35:08 +01:00
Marcus Eide 5c1840c16e Rename to DatabaseManagerOptions and export
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-07 11:06:59 +01:00
Radoslaw Wielonski f0064d4ee3 fix: fix tests for custom error handler
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-06 15:40:02 +01:00
Radoslaw Wielonski ad8ed6f91b feat: add ability to set custom errorHandler
Signed-off-by: Radoslaw Wielonski <radoslaw.wielonski@nordcloud.com>
2021-12-06 15:29:11 +01:00
Fredrik Adelöw 8c84e4ef1f add test
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-02 21:08:39 +01:00
Fredrik Adelöw 6cecfbba73 final tweaks
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-02 19:53:44 +01:00
Andrew Shirley 6298de32dd Add knexConfig sections to the config
Signed-off-by: Andrew Shirley <andrew.shirley@sainsburys.co.uk>
2021-12-02 19:43:44 +01:00
Marcus Eide 7b61f2c3b6 Make migrations object required
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-02 14:19:02 +01:00
Marcus Eide 70c46a708b Add options with migrations category
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-02 13:05:31 +01:00
Fredrik Adelöw 54989b671d Fix a potential crash in the log redaction code
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-02 10:10:34 +01:00
Fredrik Adelöw 6b500622d5 remove more cross-fetch usage in backends
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-01 16:51:05 +01:00
Marcus Eide 2f45b29875 Change runMigrations to only accept a boolean
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-01 16:21:40 +01:00
Marcus Eide 5cb156ef3b Add tests for runMigrations argument when creating a database manager
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-01 14:19:21 +01:00
Marcus Eide 86e1fbde1d Add runMigrations argument to DatabaseManager
Signed-off-by: Marcus Eide <eide@spotify.com>
2021-12-01 14:17:49 +01:00
MT Lewis a8eeaa13b4 backend-common: refactor away namespace usage in ServerTokenManager
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-11-26 13:38:32 +00:00
MT Lewis 1cad4e54ca backend-common: additional api-report comments and tags
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-11-26 12:24:48 +00:00
MT Lewis 54eaeddaf1 backend-common: move NoopTokenManager into ServerTokenManager namespace
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-11-26 12:16:38 +00:00
MT Lewis 10d0109d2e backend-common: extract NoopTokenManager from ServerTokenManager
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
2021-11-26 12:01:11 +00:00