Commit Graph

615 Commits

Author SHA1 Message Date
Fredrik Adelöw 53b9c0766d Move the plugin init into their own files to keep index clean 2020-05-08 14:00:25 +02:00
Patrik Oldsberg bf4ad8d84f Merge pull request #758 from spotify/rugvip/diffcheck
packages/cli: make plugin:diff --check output all errors
2020-05-08 13:25:28 +02:00
Stefan Ålund 8b6d05abbf Adjust header label spacing (#756) 2020-05-08 13:07:36 +02:00
Patrik Oldsberg d568edb876 packages/cli: make plugin:diff --check output all errors 2020-05-08 13:02:29 +02:00
Wesley Yee 2e475ff00a Fix: Add initial stepper step to step history (#740) 2020-05-07 10:42:55 -04:00
Stefan Ålund 5c8bd82aa1 Changed style of Table story (#733) 2020-05-07 10:49:26 +02:00
Fredrik Adelöw c1dd24a100 OCD time: devDependencies consistently below dependencies :) 2020-05-07 08:46:10 +02:00
Bilawal Hameed 91101b05f0 Merge pull request #698 from spotify/bil/tech-radar-as-a-react-component
plugin(tech-radar): make configurable as a UI component or Backstage plugin
2020-05-06 20:59:24 +02:00
Stefan Ålund f9a9e8cea2 Simplify welcome screen (#728)
* Simplify welcome screen

* Delete non-used code

* Review comments
2020-05-06 17:25:38 +02:00
Patrik Oldsberg 70040b22a7 drop support for src-relative imports 2020-05-06 16:48:55 +02:00
Fredrik Adelöw 5961be5861 Simplify logger creation in tests 2020-05-06 13:30:58 +02:00
Sebastian Qvarfordt 425cf93c08 Replacing SortableTable and a few MUI tables with new Table component (#722)
* Befind work of replacing tables with new Table component

* Removed test plugins and fixed test

* Fixed lint issue

* Removed toolbar from lighthouse audit page

* Moved column out of auditstables render function, no no interation with useInterval
2020-05-06 12:58:34 +02:00
Jose Balanza Martinez 5b0e808204 Structured metadata list color fix and update to typescript DRAFT (#656)
* Fix Structure Metadata Table and change to .tsx

* Change StructuredMetadataTable to typescript

* Oops forgot to actually fix the font color

* Fixing some more type issues

* changed padding to theme.spacing()

* fixes some more types
2020-05-06 07:36:10 +02:00
Wesley Yee ddff830b04 Rewrite sequence component (#682)
* Rework sequence component to be more declarative and simple
* Renamed to SimpleStepper
2020-05-05 15:27:35 -04:00
Fredrik Adelöw 1fae559054 Merge pull request #723 from spotify/freben/testerr
Forgot to add the error tests
2020-05-05 21:06:25 +02:00
Patrik Oldsberg eeb2646226 Merge pull request #721 from OrkoHunter/OrkoHunter/#718-fail-storybook-build-on-warnings
Fail Storybook build if there are Webpack compilation warnings
2020-05-05 18:36:47 +02:00
Fredrik Adelöw 1401141505 Forgot to add the error tests 2020-05-05 16:52:31 +02:00
Himanshu Mishra a835294a70 Add comment about Webpack plugin to fail builds on warnings 2020-05-05 22:49:27 +09:00
Fredrik Adelöw 2327cd121a Merge pull request #720 from OrkoHunter/OrkoHunter/#708-fix-flaky-e2e-test
[CLI] Fix flaky end-to-end tests
2020-05-05 14:25:09 +02:00
Himanshu Mishra b36bf68d7d 240 attempts should not just be 239 :D 2020-05-05 20:42:44 +09:00
Himanshu Mishra 5d5d093b20 Set maxFindTextAttempts as a function argument 2020-05-05 20:38:57 +09:00
Himanshu Mishra f40ccc38a4 Fix syntax to check if an element is in a set 2020-05-05 20:25:45 +09:00
Himanshu Mishra b2b91013eb Fix bug in warnings whitelist check 2020-05-05 20:16:13 +09:00
Himanshu Mishra 82b6f1e4cb Retry search text for any type of error 2020-05-05 20:09:03 +09:00
Himanshu Mishra 9ea93173f0 Do browser.visit again after getting error in finding text 2020-05-05 20:07:43 +09:00
Himanshu Mishra fe088038d6 Better variable names
attemptsToLoad -> loadAttempts
maxAttempts -> maxLoadAttempts
attemptsToSearchText -> findTextAttempts
maxAttemptsToSearchText -> maxFindTextAttempts
2020-05-05 20:06:16 +09:00
Himanshu Mishra a984c9cf22 Ignore a set of warnings during storybook webpack build 2020-05-05 19:25:54 +09:00
Patrik Oldsberg 4f32c5a5d3 Merge pull request #702 from spotify/rugvip/pdiff
package/cli: added plugin:diff command
2020-05-05 11:06:16 +02:00
Ben Lambert 6d92a57bbc Merge pull request #717 from spotify/blam/scaffolder
plugin(scaffolder): Bring up to date with the latest backend template
2020-05-05 10:47:01 +02:00
Himanshu Mishra a93f194cb6 Break from loop if the test is successful
Making this mistake since while loops were created :(
2020-05-05 17:28:43 +09:00
Himanshu Mishra d050b1c791 Fix storybook webpack warning because of TS types 2020-05-05 17:10:14 +09:00
Himanshu Mishra fe2f7265d3 Add retries to find the text on page for e2e tests
The page may not be fully loaded on the first go. Hence, we wait for some time and then retry.
2020-05-05 16:57:55 +09:00
Himanshu Mishra f3f1cdb063 Temp commit to trigger Storybook build warning 2020-05-05 16:57:15 +09:00
Himanshu Mishra 706821337e Allow local storybook build even if there are warnings 2020-05-05 16:50:27 +09:00
Himanshu Mishra 23f083a19b Fail Storybook build if there are webpack compilation warnings
Create a Webpack plugin which looks for warnings at the end of the build.
Reference doc: https://webpack.js.org/contribute/writing-a-plugin/
2020-05-05 16:43:56 +09:00
Fredrik Adelöw 1063279b4a Merge pull request #713 from OrkoHunter/OrkoHunter/fix-storybook-build-warning
Fix Storybook compilation warning
2020-05-04 20:58:30 +02:00
blam e3ab861038 chore: fixing eslint config so we can use some great optional?.chaining?.stuff 2020-05-04 20:54:59 +02:00
blam 1af6cbea8d feat(scaffolder): Bring up to date with the latest changes in the inventory service 2020-05-04 20:39:13 +02:00
Himanshu Mishra 5363006759 Fix Storybook compilation warning
Typescript import and export has to be explicit.
Related issue #700
Related PR #701
2020-05-05 02:37:03 +09:00
Stefan Ålund 168db0fe9c Rename Scaffolder -> Create (#712)
* Rename Scaffolder -> Create

* Use Typography
2020-05-04 19:37:03 +02:00
Himanshu Mishra 8354d4a104 Set the initial Storybook theme to light (#711)
This fixes the inconsistency if user's OS/Browser theme is set to Dark mode.
2020-05-04 19:32:47 +02:00
Fredrik Adelöw 9724084186 It's InputError then 2020-05-04 16:42:40 +02:00
Fredrik Adelöw 129991fcfd Even denser errors 2020-05-04 16:34:17 +02:00
Fredrik Adelöw e5529c249b Better errors 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 1b4b98cd05 Show stack in dev 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 48b4a86a97 [backend] use common error types 2020-05-04 16:06:02 +02:00
Fredrik Adelöw 7c6b7b9b94 [inventory] move out inventory instantiation + renaming 2020-05-04 11:22:37 +02:00
Sebastian Qvarfordt 190f11c8f7 Table component with filter and search (#600)
* Initial table component with storybook example

* Moved dependencies to package/core

* Removed dependency to @backstage/core from base package.json

* Clean up some examples and remove type from columns, replacing with property align instead

* Removed more unused stuff and added toggle for filter input

* Fixed some lint issues

* Added example with material-table

* Convert column array passed into MaterialTable Backstage component into MT column array. Allow multiple values in one cell

* Removed subheader from MT

* Nicer double value cell

* Added custom sorting to example

* Cleaned up stories a bit

* Setting field instead of customSort

* Improve styling. Still needs better theme integration

* Using more colors from theme

* Fixed typing issue

* Removed react-table implementation and cleaned up material-table implementation

* Fixed some type issues

* Fixed lint issues
2020-05-04 11:10:35 +02:00
Stefan Ålund 031a4356f1 [Storybook] Improve Status stories (#699)
* [Storybook] Imrove Status stories

* Remove duplicate classes
2020-05-04 11:09:30 +02:00
Himanshu Mishra 3b2aeae05a Fix blinking animation bug for Status Running component (#706)
* Refer to keyframe as a material-ul variable

https://material-ui.com/guides/migration-v3/\#styles

* Update background color of Status

The background color should match with the theme's background color.
2020-05-04 06:34:08 +02:00