Commit Graph

4263 Commits

Author SHA1 Message Date
blam 91e7fad0f7 chore(scaffolder): fixing path to now be the spotify repo to load golang template 2020-08-05 02:19:38 +02:00
Ben Lambert 7af306bf3c Merge pull request #1825 from spotify/blam/fix-gql
chore(gql): graphql should be public
2020-08-05 01:27:33 +02:00
blam 65b55fb0fa chore(gql): graphql should be public 2020-08-05 00:56:12 +02:00
Govindarajan Nagarajan 75467ecb60 Cleanup: Remove deadcode 2020-08-04 18:51:00 +02:00
Govindarajan Nagarajan 4ae351b06f Refactor: Make properties of OAuthState non-optional 2020-08-04 18:48:38 +02:00
Govindarajan Nagarajan cb80b2b4f8 Refactor: encode state Parameters as URLSearchParams instead of JSON 2020-08-04 18:42:16 +02:00
Govindarajan Nagarajan 2d20cf389c Refactor: Address PR Comments
Create a new `OAuthState` type for storing the fields we want in the
`state` parameter.

Update the `encodeState` and `readState` fns to use the new `OAuthState`
type.

Update tests to reflect the new type
2020-08-04 17:06:46 +02:00
dependabot-preview[bot] 69c9964087 chore(deps): bump chokidar from 3.4.0 to 3.4.1 (#1818)
Bumps [chokidar](https://github.com/paulmillr/chokidar) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/paulmillr/chokidar/releases)
- [Commits](https://github.com/paulmillr/chokidar/compare/3.4.0...3.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-04 14:48:30 +02:00
dependabot-preview[bot] f2c063454e chore(deps-dev): bump @types/nodegit from 0.26.5 to 0.26.7 (#1817)
Bumps [@types/nodegit](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodegit) from 0.26.5 to 0.26.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodegit)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-04 14:48:07 +02:00
dependabot-preview[bot] 0001f109a4 chore(deps-dev): bump @testing-library/react-hooks from 3.3.0 to 3.4.1 (#1820)
Bumps [@testing-library/react-hooks](https://github.com/testing-library/react-hooks-testing-library) from 3.3.0 to 3.4.1.
- [Release notes](https://github.com/testing-library/react-hooks-testing-library/releases)
- [Commits](https://github.com/testing-library/react-hooks-testing-library/compare/v3.3.0...v3.4.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-08-04 14:47:41 +02:00
Sebastian Qvarfordt 97f3f58844 Mob/techdocs end to end (#1736)
* Initial techdocs end to end heavily inspired by scaffolder

* added some tests and fixed linting

* fix(techdocs-backend): fix eslint

* fix(techdocs-backend): cleanup commented test

* Removed unused dependency

* fix(techdocs-backend): updated standalone server

* moved type dependency to devDependencies

* fix: updated dependencies and devDependencies.

* Update plugins/techdocs-backend/src/techdocs/stages/generate/types.ts

Co-authored-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Emma Indal <emmai@spotify.com>
Co-authored-by: ellinors <ellinors@spotify.com>
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
2020-08-04 13:04:48 +02:00
Ben Lambert 9d6a1c350a Merge pull request #1815 from spotify/b/update-template-descriptions
chore(scaffolder): updating the wording for the sample templates
2020-08-04 09:55:05 +02:00
blam 0d2ab85858 chore(scaffolder): updating the wording for the sample templates 2020-08-04 09:49:42 +02:00
Patrik Oldsberg 843c6bf3a5 packages/cli: fix packaging of packages without deps 2020-08-04 01:03:05 +02:00
Patrik Oldsberg 62222b543c config-loader,backend-common: refactor config loading to pass in path and use common util for backend 2020-08-03 21:24:44 +02:00
Patrik Oldsberg aa265769d2 techdocs-cli: import version from techdocs-cli directly 2020-08-03 21:24:44 +02:00
Patrik Oldsberg 0a09976548 create-app: use cli-common to discover paths and import version directly 2020-08-03 21:24:44 +02:00
Patrik Oldsberg 2f76581b60 cli: use cli-common to discover paths 2020-08-03 21:24:43 +02:00
Patrik Oldsberg 9306dc035c packages: add cli-common 2020-08-03 21:24:43 +02:00
Govindarajan Nagarajan 51fad03460 Tests: update tests for OAuthProvider to handle
Update OAuthProvider tests to ensure that changes to nonce and
environment handling do not cause regressions
2020-08-03 17:43:16 +02:00
Govindarajan Nagarajan 3e5dfbc5f6 Refactor: move encoding state parameters into a separate function 2020-08-03 17:42:48 +02:00
Govindarajan Nagarajan 081fe60453 Refactor: parse state query param to read nonce
The `state` was modified to be an encoded object of `nonce` and `env`.
When verifying the Nonce value in the callback from the authorization
server, parse the state parameter string to read the right value of
nonce
2020-08-03 15:53:22 +02:00
Govindarajan Nagarajan 685f76d913 Encode env in OAuth flow into the state parameter. refs #1775
`Env` passed as a separate parameter in the request might break the flow
of the authorization flow. Spotify considers the `env` as a first class
abstraction and use it across their application stack.
To ensure both the existing flow and newer flows are supported, use the
`state` parameter to encode an object, consisting of the `nonce` and the
`env` which is then passed to the authorization server. This parameter
is returned to the application in the callbackURL
2020-08-03 15:33:32 +02:00
Fredrik Adelöw 9d02a7b979 Merge pull request #1809 from spotify/freben/bump-react-use
chore(deps): bump react-use from 14.2.0 to 15.3.3
2020-08-03 15:06:51 +02:00
dependabot-preview[bot] 14cfeb390e chore(deps): bump react-use from 14.2.0 to 15.3.3
This is a copy of #1731 with fixes
2020-08-03 14:33:35 +02:00
Patrik Oldsberg bb24f5c448 Merge pull request #1804 from spotify/rugvip/cba-tweaks
create-app: fix lint, deps, and version
2020-08-03 12:02:34 +02:00
Fredrik Adelöw d15cc81c75 Merge pull request #1760 from spotify/dependabot/npm_and_yarn/http-errors-1.8.0
chore(deps-dev): bump http-errors from 1.7.3 to 1.8.0
2020-08-03 10:20:16 +02:00
Fredrik Adelöw 98342de0a9 Merge pull request #1761 from spotify/dependabot/npm_and_yarn/types/webpack-dev-server-3.11.0
chore(deps-dev): bump @types/webpack-dev-server from 3.10.1 to 3.11.0
2020-08-03 10:19:28 +02:00
Fredrik Adelöw f510d40170 Merge pull request #1768 from spotify/dependabot/npm_and_yarn/rollup/plugin-node-resolve-8.4.0
chore(deps): bump @rollup/plugin-node-resolve from 8.1.0 to 8.4.0
2020-08-03 10:18:53 +02:00
Patrik Oldsberg 2c4ee49be8 workflows: run cli checks on changes to create-app 2020-08-03 00:17:21 +02:00
Patrik Oldsberg d1c7d8672a create-app: sync version 2020-08-02 23:57:33 +02:00
Patrik Oldsberg fb1ee74551 create-app: fix deps 2020-08-02 23:57:23 +02:00
Patrik Oldsberg 2909054283 create-app: add lint command 2020-08-02 23:20:39 +02:00
Patrik Oldsberg bd3d0de77f Merge pull request #1745 from ayshiff/refactor/cli-create-app
Refactor: Move @backstage/cli create-app to separate package
2020-08-02 22:37:43 +02:00
Rémi DOREAU b5a6d82d5c feat(create-app): add missing template backend package 2020-08-02 20:30:49 +02:00
Patrik Oldsberg 5ff1ac0dad Merge pull request #1803 from spotify/rugvip/gqlfix
plugins/graphql: fix schema packaging
2020-08-02 20:29:50 +02:00
Patrik Oldsberg 650830cf4f plugins/graphql: fix schema packaging 2020-08-02 19:29:21 +02:00
Rémi Doreau 21d8043878 Merge pull request #1 from spotify/refactor/cli-create-app
create-app: packaging fixes
2020-08-02 17:02:49 +02:00
Patrik Oldsberg d273c74985 create-app: packaging fixes 2020-08-02 16:28:27 +02:00
Rémi DOREAU 5e78cc1082 fix(create-app): update entrypoint 2020-08-02 13:46:28 +02:00
Patrik Oldsberg 7994c64c54 Merge pull request #1793 from andrewthauer/config-string-fallback
Fallback to string if config value is not json
2020-07-31 18:43:34 +02:00
bodilb dbcc1383e0 Merge pull request #1799 from spotify/doc-tweaks
Tweaks to techdocs docs
2020-07-31 18:16:24 +02:00
Andrew Thauer 0bd997d981 feat: fallback to string value if config value is not json 2020-07-31 06:36:37 -04:00
Patrik Oldsberg cd5755cdfd Merge pull request #1796 from spotify/rugvip/postwut
cli: just print warning if postpack fails
2020-07-31 11:40:05 +02:00
Patrik Oldsberg 9131b9b5b1 yarn.lock: security fix (#1797) 2020-07-31 11:35:58 +02:00
Rémi DOREAU 730d1b21be fix(cli): add create-app import to e2e tests 2020-07-31 10:34:00 +02:00
Patrik Oldsberg 5c79a0d314 cli: just print warning if postpack fails 2020-07-31 10:19:17 +02:00
Raghunandan Balachandran 21c57181f0 Merge pull request #1795 from spotify/pianilsson-patch-1
broken link to create an app
2020-07-31 09:42:45 +02:00
Patrik Oldsberg d4a50e82c5 Merge pull request #1762 from spotify/shmidt-i/github-actions-widget-redone
feat(github-actions): widget inside catalog
2020-07-31 09:33:21 +02:00
Pia Nilsson 377bd94338 broken link to create an app 2020-07-31 09:23:10 +02:00