Commit Graph

18831 Commits

Author SHA1 Message Date
Fredrik Adelöw 92d85b80e9 more tests and a review comment
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:48 +01:00
Fredrik Adelöw b5c106ac4c fix api export and test timeouts
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:48 +01:00
Fredrik Adelöw 26cf7f631d final cleanup, removing unschedule
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:48 +01:00
Fredrik Adelöw 9bee0b9f71 make it possible to abort tasks
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:48 +01:00
Fredrik Adelöw d8c28d99cf make the original task definition into just one object
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:47 +01:00
Fredrik Adelöw b91fe07309 use a proper AbortController instead of the home baked one
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:40 +01:00
Fredrik Adelöw cc3b6c25aa make timeout and frequency mandatory
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw aeaa2fe3e6 log the task id as well when unable to parse settings
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw d252c983b5 use dashes in not-ready-yet
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw 5d602f8e29 get rid of the ts-ignore
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw 3f1237147f remove the lock functionality
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw 67456f7fc9 remove knexfile
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw c1ac8dd174 log on failed release
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:28 +01:00
Fredrik Adelöw e09bf604cd move to a separate package instead and address comments
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:22:27 +01:00
Fredrik Adelöw 222793c849 do not modify the backend yet
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:21:51 +01:00
Fredrik Adelöw d7c1e0e34a docs
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:21:51 +01:00
Fredrik Adelöw 751317dbf3 finishing touches
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:21:51 +01:00
Fredrik Adelöw d4f412fcd3 Get most of the task worker code into place
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:21:51 +01:00
Fredrik Adelöw d088c7f0a3 Implement the locks part of the task manager
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:21:49 +01:00
Fredrik Adelöw 6f276707e3 review comments
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:06:45 +01:00
Fredrik Adelöw a8732a1200 Make sure that the server builder propagates init errors properly
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 20:02:59 +01:00
Fredrik Adelöw 9010cdc4d7 add snyk ignores for the node-gyp tar vuln
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-11 19:59:13 +01:00
Colton Padden 1b3fab7193 Use mock-fs during createApp to prevent filesystem modifications
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-11-11 13:28:43 -05:00
Colton Padden bd90ded8b7 Add type annotations for mocked child_process.exec
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-11-11 13:28:43 -05:00
Colton Padden 1d666cb67e Add regression tests to createApp entrypoint
Ensure that appropriate tasks are called depending on inquirer prompt answers,
and command-line argument options (--path, and --skip-install).

Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-11-11 13:28:43 -05:00
Colton Padden 2163e83fa2 Refactor create-app tasks and introduce regression tests
- Tasks were moved from the script entrypoint to the lib directory
- Doc comments were added for each task function defined in `src/lib/tasks.ts`
- The `yarn test` script was added to package.json
- Unit tests were written for each task -- verying file operations using fs-mock

Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-11-11 13:28:43 -05:00
Patrik Oldsberg 01a0a39521 Merge pull request #7790 from backstage/mob/decouple-core
core-app-api: deprecate dependency on core-components, theme, and MUI
2021-11-11 18:31:24 +01:00
Patrik Oldsberg 25f637f39f cli: make sure JSS styles receive the highest priority
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 18:15:39 +01:00
Patrik Oldsberg b85ccce84d app-defaults: update internal deps
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:28:57 +01:00
Patrik Oldsberg 46570fecbc test-utils: migrate theme usage and switch to actual MUI icons
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:49 +01:00
Patrik Oldsberg 1be02e09dc core-app-api: fix AppManager tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:48 +01:00
Patrik Oldsberg eb489db0c1 app-defaults: lazier api initialization to work around import cycle
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:48 +01:00
Patrik Oldsberg 6d790f0f63 test-utils: reintroduce defaultApis
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:48 +01:00
Patrik Oldsberg 569acdb8f8 core-app-api: fix fix docs docs
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:48 +01:00
Patrik Oldsberg 29eb8d7dbe test-utils: switch mock icons to be plain svg elements
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg 2dd2a7b2cc changesets: add changesets for test-utils createApp and AppTheme deprecation
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg cdbddf196f app-defaults: clean up dependencies
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg 465dffb05c core-app-api,app-defaults: API report and doc fixups
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg f2bd241972 docs: introduce deprecation docs + app-theme deprecation
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg 03da4c0946 create-app: add app-defaults dependency to app + notice in changeset
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:47 +01:00
Patrik Oldsberg c98c5c3d00 core-app-api: switch auth provider icons to be empty by default
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:46 +01:00
Patrik Oldsberg 7ca03b85ab core-app-api: createSpecializedApp returns a BackstageApp
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:46 +01:00
Patrik Oldsberg a3b6707eb2 app-defaults: bump internal deps
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:46 +01:00
Patrik Oldsberg 60e5d356cb core-app-api: add missing core feature icons + move icon things around a bit
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:46 +01:00
Patrik Oldsberg c1578d609b update API reports for createApp split
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:46 +01:00
Patrik Oldsberg b7958c36db core-components: wrap page stories in test app
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:13 +01:00
Patrik Oldsberg 687fca4ff7 changesets,create-app: update for createApp split
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:13 +01:00
Patrik Oldsberg 0fb57d28e3 dev-utils,test-utils,app: update to use app-defaults
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:13 +01:00
Patrik Oldsberg 1c3413bab0 app-defaults,core-app-api: refactor into createApp/createSpecializedApp split
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:26:13 +01:00
Patrik Oldsberg 4217549648 core-app-api: rename PrivateAppImpl to AppManager
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-11 17:25:02 +01:00