Commit Graph

689 Commits

Author SHA1 Message Date
Patrik Oldsberg 5608c9e0d5 Merge pull request #13312 from ericbottard/ui-schema-on-deps
Fix a complex case where uiSchema loses previous values
2022-08-31 14:29:27 +02:00
Fredrik Adelöw aaab1e34da Fix linting errors after #13392
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-30 13:44:09 +02:00
Patrik Oldsberg 9f1feb5464 plugins: fix tests for react router bump
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-29 14:10:52 +02:00
Patrik Oldsberg aa2bfb3087 scaffolder: fix route structure for RedirectingComponent
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-29 14:10:52 +02:00
Patrik Oldsberg c286cce3f1 scaffolder: fix index routes for react-router stable
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-29 14:10:52 +02:00
blam 18ee24197e chore: fix autoselect of the workspace when there are a list provided
Signed-off-by: blam <ben@blam.sh>
2022-08-25 14:53:28 +02:00
Patrik Oldsberg 763fb81e82 refactors to avoid using useParams where possible
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-23 18:43:26 +02:00
Eric Bottard de336de9cd Fix a complex case where uiSchema loses previous values
In non trivial cases of using eg a schema with dependencies,
the extractUiSchema function could reset ui properties previously
set by the recursive call.

Signed-off-by: Eric Bottard <bottarde@vmware.com>
2022-08-23 16:20:13 +02:00
blam a2217c28a1 chore: empty strings are still strings, so if it's not set default to undefined to throw the correct error
Signed-off-by: blam <ben@blam.sh>
2022-08-22 11:21:51 +02:00
Ben Lambert bc41225ccf Merge pull request #13246 from backstage/blam/next-scaffolder/wizard-2
scaffolder(next): implement the review step
2022-08-22 11:14:57 +02:00
blam d558c5bf09 chore: working some more on the review
Signed-off-by: blam <ben@blam.sh>
2022-08-19 13:46:24 +02:00
blam b5986929b7 chore: added in the ability to customise the review step
Signed-off-by: blam <ben@blam.sh>
2022-08-19 13:28:09 +02:00
blam d8e317e661 chore: working out the review step a little more
Signed-off-by: blam <ben@blam.sh>
2022-08-19 13:23:16 +02:00
blam 784673638a chore: reworking how we do the review step
Signed-off-by: blam <ben@blam.sh>
2022-08-19 11:44:56 +02:00
Ben Lambert 2c8cb22ec0 Merge pull request #12952 from backstage/blam/next-scaffolder/wizard-2
scaffolder(next): Support `async` validation for `CustomFieldExtensions` and run validation for `type: object`
2022-08-19 10:56:11 +02:00
blam 64658427a0 chore: fixing tests by wrapping in act
Signed-off-by: blam <ben@blam.sh>
2022-08-19 10:21:53 +02:00
blam ddb0557e56 chore: code-review comments
Signed-off-by: blam <ben@blam.sh>
2022-08-18 16:47:28 +02:00
blam 5d2b0b8fc8 chore: remove some whitespace
Signed-off-by: blam <ben@blam.sh>
2022-08-18 16:26:13 +02:00
blam ac002fe3f0 chore: removing the error context, this isn't used anymore
Signed-off-by: blam <ben@blam.sh>
2022-08-18 16:24:46 +02:00
blam bc6a0c248a chore: fixing typescript
Signed-off-by: blam <ben@blam.sh>
2022-08-18 15:54:14 +02:00
blam d120031676 chore: added a library to work with the json schema form and make it easier to take into account all the different versions of jsonschema
Signed-off-by: blam <ben@blam.sh>
2022-08-18 15:53:46 +02:00
blam 7b186350d8 chore: rendering the errors for the async validation
Signed-off-by: blam <ben@blam.sh>
2022-08-18 15:47:07 +02:00
blam 6c8c1a4140 chore: starting to add async validation to the next scaffolder
Signed-off-by: blam <ben@blam.sh>
2022-08-18 15:47:07 +02:00
Fredrik Adelöw 3f739be9d9 more api cleanup
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-18 15:16:19 +02:00
blam 5b7f8fb442 chore: saving state in the form
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:50 +02:00
blam 60ac7f3ad7 chore: starting to clean up some of the form components
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:50 +02:00
blam 94ce0cda13 chore: move to use effect
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 3251a491da chore: fixing the actual tests and resetting the worflows so they are right
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 4b5d417e17 chore: fix typescript
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 43342dcf0a chore: use the existing secrets provider otherwise existing fields wont work
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 2e8cf988e3 chore: need to use the proper routeRef
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 5a6e291cff chore: reworking how the schema looks
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 797c17eef7 chore: updating template schema to support ui:backstage featureFlag
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam d3e8169a62 chore: adding a hook to deal with all the logic around the parameters schema
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam f534f52696 chore: added step extraction with tests
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 06f44b95bd more schema stuff
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 4b3687939f chore: starting to write ui:schema extractors
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam e4f5f6029b chore: some more stepper work
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam d41a786669 chore: some more progress on the forms
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 97d34d4765 chore: reworking some more styles for the stepperf
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 39f1355eba chore: starting to build the json schema form Stepper
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam e67ab9c4a2 chore: fixing wizardy things
Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 3400190663 chore: starting to build some things for the wizard page component
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:45:49 +02:00
blam 44ddbab4cd chore: added simple pageTitleOverride
\
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-07-29 11:44:52 +02:00
Ben Lambert ecafb7f34e Merge pull request #12640 from Bonial-International-GmbH/pjungermann/bitbucket-cloud/repo-picker-allowed-owners
feat: add support for `allowedOwners` at the `BitbucketRepoPicker`
2022-07-15 20:40:42 +02:00
Patrick Jungermann 9a96199f86 feat: add support for allowedOwners at the BitbucketRepoPicker
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
2022-07-14 22:27:18 +02:00
Ben Lambert 16a1aed6e8 Merge pull request #12631 from kjuulh/feature/require-valid-owner-in-owner-picker
Add allowArbitraryValues to <OwnerPicker />
2022-07-14 14:20:56 +02:00
kjuulh 180c06d623 Change boolean pipe to a Optional chaining pipe
Change boolean pipe to a Optional chaining pipe

Signed-off-by: kjuulh <contact@kjuulh.io>
2022-07-14 13:19:09 +02:00
kjuulh 3bce493156 Add allowArbitraryValues to <OwnerPicker />
This change makes the OwnerPicker able to validate that the selected
option is one of the provided values. This should provide a smoother
experience for users, as they now can only enter valid values on the
client side

None of the tests are changed, as this value is passed to MUI, which
is the library containing the validation.

Signed-off-by: kjuulh <contact@kjuulh.io>
2022-07-14 13:19:09 +02:00
Thomas Cardonne 1764296a68 feat(scaffolder): allow to create Gerrit project using default owner
Signed-off-by: Thomas Cardonne <thomas.cardonne@adevinta.com>
2022-07-13 11:51:45 +02:00