Commit Graph

18688 Commits

Author SHA1 Message Date
samiramkr 03b0e9eda0 Merge pull request #7842 from backstage/samiramkr/add-warning
add warning to dismissableBanner
2021-10-29 18:51:52 +02:00
Samira Mokaram a300f19a93 add api-report
Signed-off-by: Samira Mokaram <samiram@spotify.com>
2021-10-29 17:45:54 +02:00
Samira Mokaram c493f261e2 fix changeset
Signed-off-by: Samira Mokaram <samiram@spotify.com>
2021-10-29 17:32:36 +02:00
Samira Mokaram 83cc72f6cb fix
Signed-off-by: Samira Mokaram <samiram@spotify.com>
2021-10-29 17:16:29 +02:00
Patrik Oldsberg 970e1f37fa Merge pull request #7840 from backstage/rugvip/dedup
user-settings: remove duplicate core-plugin-api dependency
2021-10-29 16:51:53 +02:00
Samira Mokaram c11a37710a add changeset
Signed-off-by: Samira Mokaram <samiram@spotify.com>
2021-10-29 16:51:32 +02:00
Samira Mokaram f1903c7167 add warning to dismissableBanner
Signed-off-by: Samira Mokaram <samiram@spotify.com>
2021-10-29 16:47:02 +02:00
Ben Lambert 142e0458e6 Merge pull request #7426 from RoadieHQ/scaffolder-improvement
changes to allow the task workers run outside the backend process
2021-10-29 16:41:14 +02:00
Fredrik Adelöw f9ef0eae16 Merge pull request #7679 from RoadieHQ/tech-insights-backend
Implement Tech Insights backend
2021-10-29 16:24:57 +02:00
Alex Rybchenko a0a6600060 fix typo
Signed-off-by: Alex Rybchenko <arybchenko@box.com>
2021-10-29 16:17:47 +02:00
Patrik Oldsberg dd355bca46 cli: dynamically determine which packages are unsafe to repack
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-29 16:17:47 +02:00
Alex Rybchenko 7c5f6a0400 added comments
Signed-off-by: Alex Rybchenko <arybchenko@box.com>
2021-10-29 16:15:07 +02:00
Patrik Oldsberg 1bbaa719ff user-settings: remove duplicate core-plugin-api dependency
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-29 16:10:13 +02:00
Jussi Hallila b863feefbb Address warnings within api-docs
Move extra info on doc to be under remarks block

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila 9c19d6ad01 Tweak formatting of snippets on README.md files.
Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila 5ebfedd9c2 Add new api-report
Update persistence context to not be wrapped into a useless class. Modify the way test databases are created.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila 29faa2ace2 Update cli version
Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila da4577d731 Un-yikesify example FactRetriever cron to not pollute the DB
Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila 2b3e959ef4 Modifications after PR review
* Change entity filter to be an actual entity filter instead of a list of kinds or types
* Modify/simplify types a little bit
* Split common type libs to one for node and one isomorphic
* Remove unnecessary items from FactChecker interface to simplify execution loop.

Needs still matching README.md changes.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila df000b9596 Address various code review comments.
Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila a1afbe0498 Use a direct custom Error since backstage/errors seems unusable.
Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila b427f4ba0b Modify validation to have a more user friendly API
* Adding a container type to be returned from validate function
* Modifying JsonRulesEngineFactChecker to throw with error information if check addition fails on validation

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila b2363f3e3b Add explicit type information to checks
Types can be used to:
* Determine which check logic to run
* Determine the correct persistence option to use
* Choose correct ser/deser logic for the check
* Determine correct components to render on the frontend

Modify router API to be post for better usability. The API might end up doing writes if caching etc. is added in later as well.

Modify CheckRegistry & FactChecker to return persisted check when it is registered.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Jussi Hallila 75fc6ac85b Implement Tech Insights backend
* Add common types and interfaces for Tech Insights. Exposing components needed to use and modify tech-insights-backend module and to implement individual Fact Retrievers, Fact Checkers and their persistence options.

* Implement a framework to run fact retrievers and store fact data into the database. Add migration scripts to create a new database for `tech_insights`.

* Create a default implementation of a FactChecker enabling users to construct checks and run them and generate scorecards based on checks.

* To be able to use tech insights in your application you need to implement `FactRetriever`s to retrieve and return data for facts and register them to the tech-insights-backend. If you want to use fact checking functionality, you need to create `check`s and register them to an implementation of a `FactChecker`.

For more information see documentation on the README.md files of the respective packages.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2021-10-29 15:20:58 +02:00
Eric Peterson bb1539a89f Merge pull request #7837 from backstage/techdocs/bump-container-v035
[TechDocs] Bump container to v0.3.5
2021-10-29 12:20:43 +02:00
Elliot Greenwood 8c4cad0bf2 Add changeset for backstage common
Signed-off-by: Elliot Greenwood <elliot@fundapps.co>
2021-10-29 11:10:26 +01:00
Elliot Greenwood 7e6186cf6b Add NotModifiedError for the AWSS3UrlReader
Signed-off-by: Elliot Greenwood <elliot@fundapps.co>
2021-10-29 11:10:26 +01:00
Patrik Oldsberg cf686e366d Merge pull request #7836 from backstage/rugvip/hotfix
techdocs-backend: release schema hotfix
2021-10-29 11:51:19 +02:00
Eric Peterson 6129c89a47 Bump TechDocs container to v0.3.5.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-10-29 11:48:39 +02:00
Patrik Oldsberg 4eb087ccdc techdocs-backend: release schema hotfix
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-10-29 11:03:53 +02:00
Patrik Oldsberg 09217edd88 Merge pull request #7827 from andrewthauer/optional-techdocs-aws-config
fix: make techdocs s3 credentials optional in config schema
2021-10-29 10:50:30 +02:00
djamaile 2406f82644 docs(#7768): include dependsOn to depict a relation between a component and resource
Signed-off-by: djamaile <rdjamaile@gmail.com>
2021-10-29 10:32:04 +02:00
Johan Haals e3d9a4b380 Merge pull request #7832 from backstage/dependabot/npm_and_yarn/roadiehq/backstage-plugin-github-insights-1.2.2
build(deps): bump @roadiehq/backstage-plugin-github-insights from 1.1.23 to 1.2.2
2021-10-29 09:34:40 +02:00
Johan Haals dfa73c5701 Merge pull request #7814 from backstage/remove-keyboardjs-usage
Remove usage of deprecated Keyboard class
2021-10-29 08:37:18 +02:00
Fredrik Adelöw 411540af6f Merge pull request #7831 from backstage/dependabot/npm_and_yarn/azure/msal-node-1.3.2
build(deps): bump @azure/msal-node from 1.2.0 to 1.3.2
2021-10-29 08:11:35 +02:00
Matto f7cd672c7f Updated error message
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 16:39:13 +11:00
Muhammad Hamadto d86a5734fd Merge branch 'master' into read-remote-config 2021-10-29 15:26:03 +11:00
Matto 5cce78f968 Resolved conflicts
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 15:16:54 +11:00
dependabot[bot] 547b902b68 build(deps): bump @roadiehq/backstage-plugin-github-insights
Bumps [@roadiehq/backstage-plugin-github-insights](https://github.com/RoadieHQ/roadie-backstage-plugins/tree/HEAD/plugins/frontend/backstage-plugin-github-insights) from 1.1.23 to 1.2.2.
- [Release notes](https://github.com/RoadieHQ/roadie-backstage-plugins/releases)
- [Changelog](https://github.com/RoadieHQ/roadie-backstage-plugins/blob/main/plugins/frontend/backstage-plugin-github-insights/docs/releases-widget.png)
- [Commits](https://github.com/RoadieHQ/roadie-backstage-plugins/commits/HEAD/plugins/frontend/backstage-plugin-github-insights)

---
updated-dependencies:
- dependency-name: "@roadiehq/backstage-plugin-github-insights"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-29 04:12:33 +00:00
dependabot[bot] 4316c9632e build(deps): bump @azure/msal-node from 1.2.0 to 1.3.2
Bumps [@azure/msal-node](https://github.com/AzureAD/microsoft-authentication-library-for-js) from 1.2.0 to 1.3.2.
- [Release notes](https://github.com/AzureAD/microsoft-authentication-library-for-js/releases)
- [Commits](https://github.com/AzureAD/microsoft-authentication-library-for-js/compare/v1.2.0...v1.3.2)

---
updated-dependencies:
- dependency-name: "@azure/msal-node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-10-29 04:09:55 +00:00
Matto e7f4718b40 Merge branch 'resoved-conflicts' into read-remote-config
# Conflicts:
#	packages/backend-common/package.json
#	packages/backend-common/src/config.ts
#	packages/config-loader/api-report.md
#	packages/config-loader/package.json
#	packages/config-loader/src/loader.ts
#	yarn.lock
2021-10-29 15:00:30 +11:00
Matto 5b51907cbf resolved conflicts
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 14:56:31 +11:00
Kenneth Feng a794c341ca add changeset
Signed-off-by: Kenneth Feng <kenneth.feng@onepeloton.com>
2021-10-28 22:20:34 -04:00
Kenneth Feng 83e462c0be plugins/scaffolder-backend: Fix a bug where only file mode 775 is considered executable.
Due to the default umask 002 on Ubuntu, the executable files checked out by Git
have file mode 100775 (33277), which by mistake, was assumed to be the only possible file mode
produced by Git.  This bug was introduced in https://github.com/backstage/backstage/pull/7738.

There are other possible file modes, such as 100700, 100755, which
should be considered executable.  This behavior is consistent with how
Git behaves.  Git only tracks whether a file is executable.

This pull request considers a file to be executable as long as there is
an execute bit in owner, group, or everyone.

Signed-off-by: Kenneth Feng <kenneth.feng@onepeloton.com>
2021-10-28 22:17:05 -04:00
Matto 1cecd737f9 Removed dependency, introduced isValidUrl, and reinstated configPaths
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 12:53:15 +11:00
Matto 8e85a0bca0 Change variable name
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 12:51:11 +11:00
Matto ce843364f0 Remove the dependency on Etag headers for reloading config
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 12:47:18 +11:00
Matto e51740f9c9 Added documentation
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 12:44:07 +11:00
Matto 5d4053c827 Read config from remote config server
Signed-off-by: Matto <muhamadto@gmail.com>
2021-10-29 12:43:53 +11:00
Andrew Thauer b45607a2ec fix: make techdocs s3 credentials optional in config schema
Signed-off-by: Andrew Thauer <athauer@wealthsimple.com>
2021-10-28 17:56:59 -04:00