paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 23 Packages Projects Releases Wiki Activity
25,135 Commits 1 Branch 0 Tags
a73f8f48a174cefa8e894e46f5afb889554ff2cb
Commit Graph

25135 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Prasetya Aria Wibawa 0e5c9b2c8a remove unused comment 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 16:14:26 +07:00
Patrik Oldsberg 3a18c0732c Merge pull request #10409 from backstage/rugvip/tweaks 
workflow: tweak changeset feedback to work with forks
 2022-03-24 09:49:12 +01:00
Prasetya Aria Wibawa f12cb33bd5 passing down isGroup value from ownershipCard to useGetEntities 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:56:56 +07:00
Prasetya Aria Wibawa 102e6efea5 fix test ownership card 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:35:20 +07:00
Prasetya Aria Wibawa 103b72b704 update to just use one hooks and one component grid in ownership card 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:20:30 +07:00
Prasetya Aria Wibawa 69d652f3cc use relations.ownedBy for filter params in getEntities 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:26 +07:00
Prasetya Aria Wibawa e4d5b8c7ff rename owner to ownerEntity for getQueryParams 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa 80b47162be fix failing test for links to the catalog with group filter 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa 4a790094ee use humanizeEntityRef 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa da70c0ef1a check looping from length of requestedEntities 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa be6b97e2ed change to use getEntityByRef 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa 303bc1c7fb use prettier 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa d9497b9b6e change filterKinds in OwnershipCard test 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa b759a21c96 change isOwnerOf to use filter relations.ownedBy 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa 5606d6065b use getEntityRelations to get all memberOf groups 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:25 +07:00
Prasetya Aria Wibawa 8183a00eae change system test expectation for displays entity counts case 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 3e1a4ed473 use additional kind system for OwnershipCard test 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa fce26e8204 change to use supported version of useAsync 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 21f99270bb change transitive word to aggregated 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 8e9ddcc5f0 change label props 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa b0dcb1289f fix typo comment in changeset 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 539a0d754c remove catalogListResponse from import statement 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 111995470d add changeset 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 19fe9bfafb add checked props to switch component 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:24 +07:00
Prasetya Aria Wibawa 2566b48ebb transitive ownership of entities for group kind 
Signed-off-by: Prasetya Aria Wibawa <prasetya.wibawa@grabtaxi.com>
 2022-03-24 14:12:17 +07:00
dependabot[bot] f151dfee5a build(deps): bump eslint-webpack-plugin from 2.6.0 to 3.1.1 
Bumps [eslint-webpack-plugin](https://github.com/webpack-contrib/eslint-webpack-plugin) from 2.6.0 to 3.1.1.
- [Release notes](https://github.com/webpack-contrib/eslint-webpack-plugin/releases)
- [Changelog](https://github.com/webpack-contrib/eslint-webpack-plugin/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/eslint-webpack-plugin/compare/v2.6.0...v3.1.1)

---
updated-dependencies:
- dependency-name: eslint-webpack-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-24 04:13:20 +00:00
dependabot[bot] f672b24272 build(deps): bump @graphql-tools/schema from 8.3.1 to 8.3.5 
Bumps [@graphql-tools/schema](https://github.com/ardatan/graphql-tools/tree/HEAD/packages/schema) from 8.3.1 to 8.3.5.
- [Release notes](https://github.com/ardatan/graphql-tools/releases)
- [Changelog](https://github.com/ardatan/graphql-tools/blob/master/packages/schema/CHANGELOG.md)
- [Commits](https://github.com/ardatan/graphql-tools/commits/@graphql-tools/schema@8.3.5/packages/schema)

---
updated-dependencies:
- dependency-name: "@graphql-tools/schema"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-24 04:11:15 +00:00
dependabot[bot] ecd72391fb build(deps): bump @spotify/eslint-config-typescript 
Bumps [@spotify/eslint-config-typescript](https://github.com/spotify/web-scripts) from 12.0.0 to 13.0.0.
- [Release notes](https://github.com/spotify/web-scripts/releases)
- [Changelog](https://github.com/spotify/web-scripts/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotify/web-scripts/compare/v12.0.0...v13.0.0)

---
updated-dependencies:
- dependency-name: "@spotify/eslint-config-typescript"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-03-24 04:09:00 +00:00
Shailendra Ahir e230f704dd #8850 Updated api report 
Signed-off-by: Shailendra Ahir <shailendraahir@hotmail.com>
 2022-03-24 08:40:46 +05:30
Patrik Oldsberg 918d695c62 workflows: make sure no existing feedback generate script exists 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-03-24 00:17:04 +01:00
Patrik Oldsberg 8943792a3f workflows: avoid running changeset feedback on bot PRs altogether 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-03-23 23:59:08 +01:00
Patrik Oldsberg e704667f01 workflows: switch changeset feedback to pull_request_target 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-03-23 23:59:08 +01:00
Simon Gellis f5f921dafb Add changeset 
Signed-off-by: Simon Gellis <sgellis@attentivemobile.com>
 2022-03-23 17:59:13 -04:00
Simon Gellis 5fd5a1ae80 Update API docs 
Signed-off-by: Simon Gellis <sgellis@attentivemobile.com>
 2022-03-23 17:58:56 -04:00
Simon Gellis aabd601b11 Support creating draft github PRs 
Signed-off-by: Simon Gellis <sgellis@attentivemobile.com>
 2022-03-23 17:46:42 -04:00
Joe Porpeglia 4431873583 Add changeset 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 16:07:10 -04:00
Joe Porpeglia c84d4ad373 Fix usePermission usage 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 3e0bbeda8b permission-react: fix usePermission tests 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 8c6129d3e0 permission-react: inline parameter type to clean up the api report a bit 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
Joe Porpeglia 91703e8086 permission-react: use object instead of tuple for usePermission args 
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 16:07:10 -04:00
MT Lewis d88b5b3009 permission-react: fix changeset typo 
Co-authored-by: Joe Porpeglia <josephp@spotify.com>
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
Mike Lewis 5bdcb8c45d permission-react: more restrictive typing for usePermission and PermissionedRoute 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 16:07:10 -04:00
MT Lewis 9da18e4715 search: throw error for unexpected non-resource permissions when authorizing result-by-result 
We only reach this point in the code for types where the initial
authorization returned CONDITIONAL -- ALLOWs return early immediately
above, and types where the decision was DENY get filtered out entirely
when querying.

This means the call to isResourcePermission here is mostly about
narrowing the types, since the only way for it to be false is if the
PermissionPolicy returned a CONDITIONAL decision for a non-resource
permission, which can't happen - it would throw an error during
validation in the permission-backend.

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 15:58:42 -04:00
Mike Lewis 30f9884359 search: check for non-resource permissions when authorizing results 
Now that we can differentiate between ResourcePermissions and other
kinds of permissions, we can skip authorizing result-by-result
when the permission for a given document type is not a
ResourcePermission.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 15:58:42 -04:00
Joe Porpeglia 1e0dbd4fb5 Add todo 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-03-23 14:25:14 -04:00
MT Lewis 146ea2117b catalog-common: mention that CatalogEntityPermission type is alpha in changeset 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 8cb7acd781 catalog-react: stop using CatalogEntityPermission convenience type 
There's currently an issue with importing alpha exports from other
packages in the monorepo. This works around the issue for now by
skipping the use of the `CatalogEntityPermission` convenience type,
using `ResourcePermission<'catalog-entity'>` directly instead.

cf. https://github.com/backstage/backstage/pull/10128

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 0ffd88a90e catalog-react: require CatalogEntityPermission in useEntityPermission 
Now that we have stricter typing for permissions, we can restrict the
useEntityPermission hook to only be used with permissions of type
`CatalogEntityPermission`.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Mike Lewis 8c8bee47f4 catalog-common: add CatalogEntityPermission convenience type 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-23 14:25:14 -04:00
Fredrik Adelöw 6a8c4251a1 Merge pull request #10291 from RoadieHQ/allow-customizing-default-catalog-component 
Expose initialFiliter from Catalog Page
 2022-03-23 17:03:36 +01:00