paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 42 Packages Projects Releases Wiki Activity
23,281 Commits 1 Branch 0 Tags
d4f67fa728400d0dc0beb83eaa4379eb58b1d13b
Commit Graph

9651 Commits

Author SHA1 Message Date
Johan Haals d4f67fa728 catalog-react: Deprecate useOwnedEntities & useOwnUser 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-22 16:19:45 +01:00
Ben Lambert 53dbebbcde Merge pull request #9701 from backstage/blam/deprecations/octokit 
deprecations: Deprecate the `OctokitProvider` export from `scaffolder-backend`
 2022-02-22 13:38:32 +01:00
blam dbe239808d chore: encodeURIComponent 
Signed-off-by: blam <ben@blam.sh>
diff --git c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
index ca70084ef5..9efc11210a 100644
--- c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
+++ i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
@@ -65,10 +65,14 @@ export const defaultClientFactory = async ({
   host = 'github.com',
   token: providedToken,
 }: ClientFactoryInput): Promise<PullRequestCreator> => {
+  const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map(
+    encodeURIComponent,
+  );
+
   const octokitOptions = await getOctokitOptions({
     integrations,
     credentialsProvider: githubCredentialsProvider,
-    repoUrl: `https://${host}/${owner}/${repo}`,
+    repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo}`,
     token: providedToken,
   });
 2022-02-22 13:10:39 +01:00
Fredrik Adelöw 0045270527 airbrake: fix config to be optional, unbreak local dev startup 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-02-22 11:31:05 +01:00
blam 8142c09b3f chore: wth prettier 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 11:29:35 +01:00
Fredrik Adelöw d788fa8495 Merge pull request #9665 from djamaile/feature-flag-scaffolding 
feat(scaffolder): remove sections or fields based on a feature flag
 2022-02-21 21:53:40 +01:00
blam 5b7079a696 chore review comments 
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
 2022-02-21 20:52:27 +01:00
djamaile 04d4829cf4 refactor: respond to comments #2 
Signed-off-by: djamaile <rdjamaile@gmail.com>
 2022-02-21 20:26:54 +01:00
Fredrik Adelöw b212bed480 Merge pull request #9605 from moltenice-forks/airbrake-connect 
Make the Airbrake plugin useable
 2022-02-21 19:49:03 +01:00
Eric Peterson 78e31e6b68 Merge pull request #9244 from jonathan-ash/techdocs-reader-custom-error-page 
Added the option to supply a custom error page to TechDocsPage
 2022-02-21 17:50:03 +01:00
Eric Peterson 3675e7120c Minor feedback 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-02-21 17:12:50 +01:00
Fredrik Adelöw 1b7d5e5bea Merge pull request #9686 from backstage/dependabot/npm_and_yarn/graphql-modules-2.0.0 
chore(deps): bump graphql-modules from 1.4.4 to 2.0.0
 2022-02-21 16:59:39 +01:00
Karan Shah 96e8c9fd59 Refactor to not need core-app-api 
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
 2022-02-21 15:38:07 +00:00
djamaile 5c5362137a refactor: respond to comments 
Signed-off-by: djamaile <rdjamaile@gmail.com>
 2022-02-21 16:30:04 +01:00
Johan Haals ac27092211 Merge pull request #9698 from backstage/jhaals/cleanup-catalog-backend 
catalog-backend: Cleanup API report
 2022-02-21 16:14:31 +01:00
blam 5042a822f6 chore: fix auth provided 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 16:08:16 +01:00
blam 1a864a3b68 chore: updating the api report 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:57:18 +01:00
blam 9553964f28 chore: providing a new helper for generating octokit credentialsProvider 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:41:30 +01:00
blam afee525a36 chore: deprecating the OctokitProvider 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:40:38 +01:00
Karan Shah f62ce97a15 This is needed 
https://github.com/backstage/backstage/runs/5275475872?check_suite_focus=true
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
 2022-02-21 14:33:09 +00:00
Karan Shah 4abc806f23 Remove unnecessary dependency 
Signed-off-by: Karan Shah <karan.shah@simplybusiness.co.uk>
 2022-02-21 14:15:23 +00:00
Ben Lambert 416032660b Merge pull request #9670 from backstage/blam/deprecations/3 
deprecations: More small type fixes and deprecations for `scaffolder-backend`
 2022-02-21 15:01:12 +01:00
Fredrik Adelöw c503e588b5 Merge pull request #9673 from backstage/server-permission-client-error 
[Permissions] Improve error message for backend-to-backend authn setup
 2022-02-21 14:59:01 +01:00
Johan Haals 750f7dffdb Merge pull request #9695 from backstage/jhaals/deprecate-useEntityListProvider 
catalog-react: Rename useEntityListProvider hook to useEntityList
 2022-02-21 14:57:49 +01:00
Fredrik Adelöw 7c4a51ae0e Merge pull request #9640 from backstage/dependabot/npm_and_yarn/asyncapi/react-component-1.0.0-next.33 
chore(deps): bump @asyncapi/react-component from 1.0.0-next.32 to 1.0.0-next.33
 2022-02-21 14:56:05 +01:00
Johan Haals 6d994fd9da catalog-backend: Cleanup API report 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-21 14:55:34 +01:00
Emma Indal 0cbeaf04ce Merge pull request #9697 from backstage/emmaindal/techdocs-backend-api-report 
[TechDocs] clean up techdocs backend api report
 2022-02-21 14:20:09 +01:00
Johan Haals b776ce5aab catalog-react: Rename useEntityListProvider hook to useEntityList 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-21 13:32:37 +01:00
Johan Haals 1482bb9349 Merge pull request #9690 from backstage/jhaals/deprecate-useEntityKinds 
catalog-react: deprecate useEntityKinds
 2022-02-21 13:25:36 +01:00
Emma Indal 68abf6e837 Update plugins/techdocs-backend/src/search/DefaultTechDocsCollator.ts 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>

Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com>
 2022-02-21 13:24:56 +01:00
Emma Indal e60175e87a clean up deprecated code 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
 2022-02-21 12:06:43 +01:00
Emma Indal 81b6d0fabe clean up api report 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
 2022-02-21 12:02:50 +01:00
Camila Belo 8651981680 Merge pull request #9569 from backstage/bump-mkdocs-material 
[TechDocs] Adjust theme styles
 2022-02-21 11:38:07 +01:00
Johan Haals e1e9b72cba Merge pull request #9662 from backstage/jhaals/useEntityFromUrl 
catalog: Deprecate `useEntityFromUrl` and `useEntityCompoundName`
 2022-02-21 11:34:11 +01:00
Fredrik Adelöw 8cf39de043 Merge pull request #9564 from kim5566/feature/todo-exclude-folders 
[TODO] filter out certain folders from plugin
 2022-02-21 11:17:36 +01:00
Johan Haals b0f2c7d3a6 chore: Rename file 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-21 10:41:09 +01:00
Julio Zynger 2d7afdf100 Add screenshot to GoCD plugin README 
Signed-off-by: Julio Zynger <julio.zynger@soundcloud.com>
 2022-02-21 10:36:09 +01:00
Johan Haals 4c91f2d3b1 update api report 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-21 10:32:42 +01:00
Camila Belo 89edb124f5 refactor: apply review suggestions 
Signed-off-by: Camila Belo <camilaibs@gmail.com>
 2022-02-21 10:29:35 +01:00
djamaile 50473a3f05 fix(scaffolder): change variable name 
Signed-off-by: djamaile <rdjamaile@gmail.com>
 2022-02-21 10:18:16 +01:00
Johan Haals a8331830f1 catalog-react: deprecate useEntityKinds 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-21 10:09:49 +01:00
dependabot[bot] 68913af4ff chore(deps): bump graphql-modules from 1.4.4 to 2.0.0 
Bumps [graphql-modules](https://github.com/Urigo/graphql-modules) from 1.4.4 to 2.0.0.
- [Release notes](https://github.com/Urigo/graphql-modules/releases)
- [Commits](https://github.com/Urigo/graphql-modules/compare/graphql-modules@1.4.4...graphql-modules@2.0.0)

---
updated-dependencies:
- dependency-name: graphql-modules
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2022-02-21 04:27:51 +00:00
Joe Porpeglia 0816f8237a Improve error message when permissions are enabled without backend-to-backend authentication 
Signed-off-by: Joe Porpeglia <josephp@spotify.com>
 2022-02-18 15:38:01 -05:00
kim5566 fab01d0140 clearup 
Signed-off-by: kim5566 <28945404+kim5566@users.noreply.github.com>
 2022-02-19 07:05:34 +11:00
Patrik Oldsberg c323b2b6af Merge pull request #9667 from backstage/rugvip/nocols 
catalog: remove columnFactories export
 2022-02-18 19:10:16 +01:00
blam 65a7939c6c deprecations: more scaffolder backend stuff 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 19:07:08 +01:00
djamaile d50c44d04a Merge branch 'backstage:master' into feature-flag-scaffolding 2022-02-18 16:48:01 +01:00
Patrik Oldsberg e7b9c3d713 catalog: remove columnFactories export 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-02-18 16:29:33 +01:00
blam 756f6cc5ef chore: added some more deprecations and fixing some more of the api-report 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 16:22:18 +01:00
djamaile 2f2543592c feat(scaffolder): remove sections or fields based on a feature flag 
Signed-off-by: djamaile <rdjamaile@gmail.com>
 2022-02-18 16:21:37 +01:00