f11f42b8e1
Merge pull request #16659 from agentbellnorm/techdocs/remove-warnings
...
[TechDocs] remove warnings
2023-03-20 14:43:11 +01:00
791c7467d4
cancel the debounce in the cleanup function that actually handles the event setup and teardown, where it belongs
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-20 13:27:47 +01:00
6f8035a265
make unmount effect more explicit
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-20 13:14:10 +01:00
fc84b1b04e
removed internal package from changeset
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-20 10:38:17 +01:00
6eaa03d9de
workaround useAsync typescript error
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-17 11:47:38 +01:00
fc1665944b
could it be?
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-17 11:47:31 +01:00
68c7082188
assume metadata is available and only refetch it if we don't have it when the shadowroot is mounted
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-16 16:44:30 +01:00
f6c92d54e7
wait with fetching techdocs metadata until the shadow root exists
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-16 16:44:30 +01:00
103f5e2793
Merge branch 'master' into techdocs/remove-warnings
...
Signed-off-by: Morgan Bentell <morgan.bentell@gmail.com >
2023-03-16 16:18:32 +01:00
7cf160e4bc
cancel debounced function on unmount to avoid updating state on an umounted component
...
Signed-off-by: Morgan Bentell <mbentell@spotify.com >
2023-03-01 13:55:58 +01:00
65454876fb
unpack props inside component bodies
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2023-02-27 15:31:15 +01:00
b8269de9f1
style(react 18): explicitly declaring children as optional props
...
This is to facilitate the react 18 upgrade which introduced the requirement to explicily declare children as props
Helps to address #12252
Signed-off-by: Mark David Avery <mark@webark.cc >
2023-01-04 11:21:34 -08:00
6aa2b965eb
when looking for the page within the outlet, reject addons wrapper as well as addons, because different versions of react router use different numbers of wrappers. Should be compatible with all 6.* versions now
...
Signed-off-by: Morgan <mbentell@spotify.com >
2022-12-19 17:48:13 +01:00
cb716004ef
add some eslint rules for testing-library use in tests
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2022-11-18 11:29:20 +01:00
7d1352d459
Provide entityRef analytics context within TechDocs reader
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-11-11 12:00:09 +01:00
b874bd03bb
change wrapper back to global declaration
...
Signed-off-by: Jake Crews <jake.crews@daveramsey.com >
2022-07-26 09:12:54 -05:00
b2c4aaa7b2
fix lowercaseEntityRefMaybe
...
Signed-off-by: Jake Crews <jake.crews@daveramsey.com >
2022-07-14 12:54:43 -05:00
aef5f69057
change TechDocsReaderPageContext to modify entityRef for casing
...
Signed-off-by: Jake Crews <jake.crews@daveramsey.com >
2022-07-14 09:39:41 -05:00
29d6cf0147
fix(plugin-catalog): Fix viewTechdocLink so kind is lowercase by default in url path
...
Signed-off-by: Jake Crews <jake.crews@daveramsey.com >
2022-07-14 07:34:41 -05:00
c3cfc83af2
chore: Make docstrings MDX compatible
...
Signed-off-by: Johan Haals <johan.haals@gmail.com >
2022-06-14 16:29:17 +02:00
95a5352746
fix(techdocs): prevent content re-renders
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-05-18 14:16:32 +02:00
84717cf5ea
api report fix
...
Signed-off-by: Anders Näsman <andersn@spotify.com >
2022-05-16 09:13:12 +02:00
206c7ccca0
apply review feedback
...
Signed-off-by: Anders Näsman <andersn@spotify.com >
2022-05-16 09:13:12 +02:00
2b74671f52
Move stable alpha exports to public.
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-05-11 13:34:24 +02:00
9e0a6ef4fa
feat(techdocs): add addon settings location
...
Signed-off-by: Camila Belo <camilaibs@gmail.com >
2022-05-06 08:52:54 +02:00
a68de3c984
move TechDocsStorage api from @backstage/plugin-techdocs to @backstage/plugin-techdocs-react
...
Signed-off-by: Anders Näsman <andersn@spotify.com >
2022-04-27 13:10:42 +02:00
075a9a067b
Clean up createTechDocsAddonExtension return type
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-25 15:10:00 +02:00
39a6eda01d
Review feedback 2: electric boogaloo
...
Co-authored-by: Otto Sichert <git@ottosichert.de >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-12 15:37:29 +02:00
a357c354af
Do not use @alpha type in @public export
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-12 13:07:58 +02:00
ca4420782c
Review feedback.
...
Signed-off-by: Eric Peterson <ericpeterson@spotify.com >
2022-04-12 11:25:25 +02:00
1f51e960af
Update draft comment for COMPONENT TechDocs location
...
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-12 11:11:04 +02:00
883ab7228a
Moved shared TechDocs utilities from plugin-techdocs to plugin-techdocs-react
...
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-11 17:06:32 +02:00
b05870bcb7
Move @backstage/techdocs-addons to @backstage/plugin-techdocs-react
...
Co-authored-by: Eric Peterson <iamEAP@users.noreply.github.com >
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com >
Signed-off-by: Otto Sichert <git@ottosichert.de >
2022-04-11 16:13:07 +02:00
Morgan Bentell