Commit Graph

1514 Commits

Author SHA1 Message Date
Johan Persson cd0b8a11a3 chore: make jest a peer dependency with v29/v30 support
Move jest from dependencies to peer dependencies, allowing users to
choose between Jest 29 and Jest 30.

The CLI now detects the Jest version at runtime and uses the
appropriate environment:
- Jest 29: Uses standard jest-environment-jsdom
- Jest 30: Uses a custom environment based on @jest/environment-jsdom-abstract
  with fixes for Web API globals (fetch, streams, Error, etc.)

The cross-fetch polyfill is only injected for Jest 29, as with Jest 30+
our patched Jest environment is used. The network request blocker is made
MSW-compatible by checking if fetch was wrapped before blocking.

Jest 30 (with jsdom v27) fixes `Could not parse CSS stylesheet`
warnings/errors when testing components from @backstage/ui or other
packages using CSS `@layer` declarations.

New peer dependencies (install based on your Jest version):
- jest (required, ^29 or ^30)
- Jest 29 requires: jest-environment-jsdom
- Jest 30 requires: @jest/environment-jsdom-abstract, jsdom

Production code changes for jsdom 27 testability:
- AppIdentityProxy: extract navigateToUrl method for spying
- LiveReloadAddon: export utils.reloadPage for spying
- collect.ts: export internal.resolvePackagePath for mocking

MockFetchApi: evaluate global.fetch at call time instead of construction
time, allowing MSW to patch fetch after MockFetchApi is constructed.

Test adaptations for jsdom 27:
- Use RGB values instead of named colors in CSS assertions
- Update error format expectations (hyphenated type names, SyntaxError
  instead of FetchError for JSON parse errors)
- Simplify URL error assertions for cross-version compatibility
- Fix accessible name whitespace handling for external links
- Use history.replaceState for location mocking (non-configurable)
- Use fireEvent.blur for contentEditable elements
- Move async assertions inside waitFor for race conditions
- Remove Blob.prototype.text polyfill (now native)
- Remove test case using credentials in plugin:// URLs

Test adaptations for Jest 30:
- Replace `expect.objectContaining([...])` with direct array equality
- Replace `expect.objectContaining({ length: N })` with
  `expect.any(Array)` + separate `toHaveLength()` assertions
- Use child process for native Node.js module resolution in
  collect.test.ts to work around Jest 30's resolver behavior
- Update snapshot headers for new Jest format

Also removes the jest-haste-map patch which is no longer needed.

Signed-off-by: Johan Persson <johanopersson@gmail.com>
2025-12-11 18:06:55 +01:00
github-actions[bot] e08f48a9b5 Version Packages (next) 2025-12-09 15:00:09 +00:00
Fredrik Adelöw f3f84f1e4b make .withOverrides have a simplified result type
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2025-12-03 16:51:12 +01:00
Patrik Oldsberg 2c6ea33a74 Merge pull request #31946 from backstage/rugvip/tsbumps
cli: switch tsconfig to default to bundler resolution
2025-12-02 23:31:11 +01:00
Patrik Oldsberg f85dafa7f2 update API reports for moduleResolution: bundler
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-12-02 22:25:00 +01:00
github-actions[bot] 336db00d21 Version Packages (next) 2025-12-02 15:37:41 +00:00
Vincenzo Scamporlino ce87e679a1 techdocs: marking techdocs config as optional
Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
2025-11-25 22:07:22 +01:00
github-actions[bot] 756986e5e7 Version Packages (next) 2025-11-25 16:21:32 +00:00
Patrik Oldsberg 395ff1c43b plugins: remove unused dependencies on core-compat-api
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-23 14:36:02 +01:00
Patrik Oldsberg 1c7ea4a3e8 plugins: remove unnecessary use of convertLegacyRouteRef(s)
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-23 14:36:02 +01:00
Patrik Oldsberg d02db50b42 plugins: cleanup unnecessary use of compatWrapper
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-23 12:56:54 +01:00
Patrik Oldsberg ebe5538d55 update API reports for core/frontend inversion
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-23 01:59:07 +01:00
github-actions[bot] 792f4d7e3d Version Packages 2025-11-18 12:23:09 +00:00
Patrik Oldsberg a1c58124a7 sync API reports
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-17 10:35:43 +01:00
github-actions[bot] 3738293d26 Version Packages (next) 2025-11-04 15:00:26 +00:00
Ben Lambert 3bdeb378e2 Merge pull request #31277 from Andy2003/feature/provide-icon-for-search-result-icon
Add support for customizable icons in SearchResultListItemBlueprint
2025-11-04 11:21:14 +01:00
Patrik Oldsberg 878c25146c frontend-plugin-api: make ExtensionInput type parameters optional
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2025-11-03 22:36:53 +01:00
Fredrik Adelöw dc5aad652e Merge pull request #31242 from hopehadfield/remove-more-unused
Remove unused dependencies from kubernetes, signals, and techdocs
2025-10-29 22:50:03 +01:00
github-actions[bot] 2c1fe37d3b Version Packages (next) 2025-10-24 13:22:48 +00:00
github-actions[bot] 807af8ce0e Version Packages (next) 2025-10-21 16:14:43 +00:00
Gabriel Dugny 52e01b98bc chore: Simplify by removing a useless useMemo & merging useEffect
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2025-10-17 22:05:55 +02:00
Gabriel Dugny a4d4a7084a chore: changeset & clarifications
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2025-10-16 18:47:13 +02:00
Gabriel Dugny 1b3d2a1bbe chore: split to dedicated hook
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2025-10-16 18:21:11 +02:00
Gabriel Dugny da6b06f4ff fix(techdocs): Header reload when navigating inside Techdocs
Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>

Attempt to fix regression introduced by https://github.com/backstage/backstage/pull/30984

LLM-generated, not review thoroughly yet.

Signed-off-by: Gabriel Dugny <gabriel.dugny@believe.com>
2025-10-16 18:02:23 +02:00
github-actions[bot] d6ce2db9ca Version Packages 2025-10-14 15:29:54 +00:00
Andreas Berger 0a4e495019 Merge remote-tracking branch 'origin/master' into feature/provide-icon-for-search-result-icon 2025-10-09 08:50:15 +02:00
Fredrik Adelöw 3ce99627d0 Merge pull request #31246 from backstage/search-abortcontroller
Implement AbortController request cancellation for search.
2025-10-07 23:02:12 +02:00
github-actions[bot] ffb5b44d86 Version Packages (next) 2025-09-30 14:42:12 +00:00
Andreas Berger a521911fbc Add support for customizable icons in SearchResultListItemBlueprint and related components
Signed-off-by: Andreas Berger <andreas@berger-ecommerce.com>
2025-09-25 12:40:31 +02:00
github-actions[bot] c2c60546d2 Version Packages (next) 2025-09-24 12:57:42 +00:00
Sydney Achinger e02473eeb3 Update test
Signed-off-by: Sydney Achinger <sydneynicoleachinger@spotify.com>
2025-09-23 16:18:13 -04:00
Hope Hadfield d2a6929f05 Remove unused dependencies from kubernetes, signals, and techdocs
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
2025-09-23 13:43:11 -04:00
github-actions[bot] c73bfa46d4 Version Packages (next) 2025-09-23 15:00:29 +00:00
github-actions[bot] b799a2d07f Version Packages 2025-09-16 13:22:58 +00:00
Paul Schultz 133ac7ad66 fix(repo-tools): resolve knip-reports failure with spaces in workspace paths
Signed-off-by: Paul Schultz <pschultz@pobox.com>
2025-09-15 12:34:26 -05:00
Fredrik Adelöw e6ff786ae4 Merge pull request #30991 from MegaManSec/xss-fix 2025-09-15 17:19:25 +02:00
Joshua Rogers b87e54c355 tests(techdocs): add transformer tests for sanitizing javascript: hrefs
Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
2025-09-11 08:44:33 +02:00
Joshua Rogers cb9e2d1155 Revert "techdocs: Disallow javascript URLs"
This reverts commit 067fdcd0a5.

Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
2025-09-11 08:26:59 +02:00
Luna Stadler 8d18d23e34 Improve TechDocs page titles (especially for nested pages) (#31054)
* Replace underscores in techdocs titles

Signed-off-by: Luna Stadler <luc@spreadshirt.net>

* Make techdocs titles similar to component titles

The pattern for components is entity name, page/tab and then app title.
This ordering makes it easier to distinguish tabs at a glance.

Signed-off-by: Luna Stadler <luc@spreadshirt.net>

* Abbreviate nested pages in techdocs

A deeply nested page like `/really/very/deeply/nested/page`, will now
become "Really | ... | Nested | Page".

This should preserve some of the context and support docs whith deeply
nested pages.

Signed-off-by: Luna Stadler <luc@spreadshirt.net>

* Add changeset for TechDocs page title improvements

Signed-off-by: Luna Stadler <luc@spreadshirt.net>

* Display the full title based on all parts of the path

Signed-off-by: Luna Stadler <luc@spreadshirt.net>

---------

Signed-off-by: Luna Stadler <luc@spreadshirt.net>
2025-09-10 14:34:58 -04:00
Fredrik Adelöw 933a982c12 Merge pull request #30984 from Frueber/tech-docs/external-tech-docs-redirect/add-handling-tests-and-documentation 2025-09-10 19:24:28 +02:00
Jackson Chen 313cec7bed add changeset
Signed-off-by: Jackson Chen <jacksonc@spotify.com>
2025-09-09 17:47:35 -04:00
Jackson Chen d821c01c5e refactor and fix dompurify tsc errors
Signed-off-by: Jackson Chen <jacksonc@spotify.com>
2025-09-09 17:32:04 -04:00
Fredrik Adelöw 1184c55a2a Merge pull request #30723 from Believe-SA/techdocs-redirect-dompurify 2025-09-09 20:27:05 +02:00
github-actions[bot] 020d484ac4 Version Packages (next) 2025-09-09 15:00:36 +00:00
github-actions[bot] ac48eeb3ba Version Packages (next) 2025-09-02 12:17:03 +00:00
Owen Shartle ff40e2297c Using catalogApiMock from @backstage/plugin-catalog-react/testUtils.
Signed-off-by: Owen Shartle <timeloveinvent+github@gmail.com>
2025-09-01 21:09:50 -04:00
Owen Shartle 8eb950ff64 Adding a try-catch around the usage of the catalog API in the TechDocsReaderPage as it could still attempt to load a standard TechDocs page.
Signed-off-by: Owen Shartle <timeloveinvent+github@gmail.com>
2025-08-25 21:36:57 -04:00
Owen Shartle a0b604cb6a Adding handling which checks if the current entity (the catalog entity being loaded) has an annotation for an external entity's TechDocs. If it does then we will redirect there rather than allowing a 404 (mic drop). This helps keep older URLs routing to the updated locations.
Adding changesets.
Adding test coverage for external TechDocs entitiy redirect.

Signed-off-by: Owen Shartle <timeloveinvent+github@gmail.com>
2025-08-25 15:39:29 -04:00
github-actions[bot] 9c441f9a78 Version Packages (next) 2025-08-25 15:09:39 +00:00
John Philip 53b4426952 revert sidebar css changes
Signed-off-by: John Philip <jphilip@spotify.com>
2025-08-20 11:36:00 -04:00