7e2c0bc96f
FIX: Stop sed escaping numbers 2 and 7 in Docker
...
An interesting edge case has come up whilst using BackStage.
When using the example frontend-with-nginx work to run a separate
frontend, whilst then providing an override for the
googleAnalyticsTrackingId in yaml config via
APP_CONFIG_app_googleAnalyticsTrackingId. I received an "Octal escape
sequences are not allowed in strict mode" error in the browser dev
console.
After looking into it it appears that the sed used escapes the numbers 2
and 7 if they are present in an APP_CONFIG_* ENV override value.
I happened to have both a 2 and a 7 in my GA ids, hence the edge case
part!
Of note this did not happen on my mac but it is present inside of the
nginx:mainline Docker container used in the example.
This fix simply removes the hex from the sed substitution regex and
replaces it with a single quote '
Signed-off-by: Ben Chidgey <ben@feedmypixel.com >
2021-09-23 17:34:54 +01:00
d0a47c8605
move to node 14 & 16
...
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com >
2021-09-17 23:03:29 +02:00
ccfd99c9b1
update dockerfile instructions to build only app workspace
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2021-08-12 09:47:16 +02:00
8bd92cff3f
Update nginx deployment to use 1.19 features
...
- There is no need to override the `CMD` on the base image to get the custom scripts to run. This can be done simply by adding the custom configuration script to the `/docker-entrypoint.d` folder. See https://github.com/nginxinc/docker-nginx/blob/master/mainline/debian/docker-entrypoint.sh .
- With the above change made, we can now also reap the benefit of support for `envsubst` having been added in 1.19 - as long as the config is placed in the folder `/etc/nginx/templates/`. See https://github.com/docker-library/docs/tree/master/nginx#using-environment-variables-in-nginx-configuration-new-in-119 and https://github.com/nginxinc/docker-nginx/blob/master/mainline/debian/20-envsubst-on-templates.sh for more info.
Signed-off-by: Brian Fox <brianhfox@gmail.com >
2021-04-22 17:36:05 +02:00
e669a8013f
update the standalone frontend contribs
...
Signed-off-by: Fredrik Adelöw <freben@gmail.com >
2021-04-20 20:24:06 +02:00
3067de45a8
docs(contrib/docker/devops): improve devops containers readability
...
Signed-off-by: Eric Swanson <ericis@users.noreply.github.com >
2021-04-05 10:18:12 -04:00
a133c273e3
chore(contrib/docker/devops): improve make targets
...
more holistic and consistent tasks
improved documentation
Signed-off-by: Eric Swanson <ericis@users.noreply.github.com >
2021-04-05 10:16:49 -04:00
bd001c2093
fix(contrib/docker/devops): use libsecret-dev
...
chore: parameterize the vale url
Signed-off-by: Eric Swanson <ericis@users.noreply.github.com >
2021-04-05 10:15:24 -04:00
298ea04df6
docs(contrib): docker
...
Signed-off-by: Eric Swanson <ericis@users.noreply.github.com >
2021-04-05 10:14:00 -04:00
4d4183941f
chore(devops): move container example under docker dir
...
Signed-off-by: Eric Swanson <ericis@users.noreply.github.com >
2021-04-02 16:29:37 -04:00
673c4f7d5a
Allow overriding cookiecutter's docker imageName
...
.. to allow running custom-built images that have
cookiecutter installed alongwith extensions, for
example.
https://cookiecutter.readthedocs.io/en/1.7.2/advanced/template_extensions.html
related to:
https://github.com/backstage/backstage/pull/4956#discussion_r596846365
Signed-off-by: Vinay P <mail@vinayvinay.com >
2021-03-25 12:12:36 +00:00
3105b46afa
Document use of Jinja2 extensions with fetch:cookiecutter
...
Signed-off-by: Vinay P <mail@vinayvinay.com >
2021-03-25 12:12:17 +00:00
cca03162bc
chore: Remove yarn docker-build:app command and related docs
2021-01-17 21:53:37 +01:00
9560a1a4ab
chore: Move Dockerfile at root to contrib/
...
In deployment docs https://backstage.io/docs/getting-started/deployment-other , we suggest doing a `yarn docker-build` and I thought the root Dockerfile was being used to build the image. Hence I modified it for some needs, but no changes were reflected. Later I found that `yarn docker-build` uses the `Dockerfile` present inside `packages/backend` https://github.com/backstage/backstage/blob/master/packages/backend/Dockerfile . So, I think the Dockerfile at the root is a bit misleading, and should be moved to contrib.
Signed-off-by: Himanshu Mishra <himanshu@orkohunter.net >
2021-01-13 15:24:22 +01:00
478e17bcf4
Apply development config in Helm charts ( #3161 )
...
This isn't the best fix because we're still using NODE_ENV=development
in a "production" environment. Ideally we would stop doing this.
Right now, the Helm charts are broken because they deploy the backend
straight into Error state.. This change will unbreak them for the
moment.
2020-11-02 09:05:57 +01:00
2476e3fa25
Add Dockerfile for helm chart
...
Add a Dockerfile which can be used to build an image that the helm
charts will use as default. These images require mkdocs and cookiecutter
to be installed (for now) in order to work around the docker requirement
in kubernetes.
2020-10-08 15:36:08 +01:00
f77333c351
Update docker base image to buster for node
2020-09-21 11:01:22 +01:00
357a99a20b
Fix Dockerfile comments and README instructions
2020-09-20 23:32:17 +03:30
5d8afa9bc6
Fix prettier on multi-stage-fontend README.md
2020-09-20 17:57:36 +04:30
0cfe7461dd
Move standalone.Dockerfile to contrib directory
2020-09-20 17:36:19 +04:30
Ben Chidgey