Commit Graph

19467 Commits

Author SHA1 Message Date
Mike Lewis 40ea710c14 backend-common: add api doc comments
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 18:22:53 +00:00
Mike Lewis 4b6de2f872 backend-common: remove 'Server' from TokenManager method names
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 18:12:28 +00:00
Mike Lewis 905dd952ac chore: split up backend-to-backend auth changeset to reduce changelog noise
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 17:55:48 +00:00
Mike Lewis 8a001f8202 backend-common: TokenManager throws for invalid tokens rather than returning boolean
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 17:55:47 +00:00
Johan Haals 950b36393c core-plugin-api: Add tests and changesets
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2021-11-23 16:58:27 +01:00
Johan Haals a3c5b2f70b core-plugin-api: Deprecate Plugin register and output
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2021-11-23 16:58:21 +01:00
Mike Lewis f38dff4085 backend-common: tests validating interop of multiple token managers
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 14:58:48 +00:00
Mike Lewis 8cb1c4d17c backend-common: rename config block from authorization to auth
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 14:41:33 +00:00
Adrian Barwicki 7071dce02d feat: expose catalog lib in plugin-auth-backend
We are writing a custom OIDC provider plugin and need to use CatalogIdentityClient class in our provider. It is however not exported and we are not able to use it.

It is not a problem for providers that are committed to backstage repo as they use the local path, e.g https://github.com/backstage/backstage/blob/master/plugins/auth-backend/src/providers/aws-alb/provider.ts#L31 - but only for the ones that are developed locally.

Signed-off-by: Adrian Barwicki <adrianbarwicki@gmail.com>
2021-11-23 15:17:19 +01:00
Mike Lewis 42b01ee725 backend-common: import ConfigReader from @backstage/config
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 13:57:38 +00:00
Mike Lewis db1befcf39 backend-common: make secret required if authorization config block is provided
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 13:56:07 +00:00
Mike Lewis ef9dfd3440 backend-common: leave ConfigReader to throw errors when config is missing in ServerTokenManager
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 13:54:04 +00:00
Patrik Oldsberg 68eddf88a0 Merge pull request #8118 from backstage/rugvip/test-port
packages,plugins: migrate to using TestApiProvider and TestApiRegistry
2021-11-23 13:47:51 +01:00
Patrik Oldsberg a7085710d5 Merge pull request #8208 from backstage/rugvip/rollupup
yarn.lock: bump rollup-plugin-postcss
2021-11-23 13:10:51 +01:00
Camila Belo c0a624b03f Merge pull request #8179 from cmpadden/snyk-ignore-techdocs-cli
Add .snyk ignore file for @techdocs/cli
2021-11-23 13:03:00 +01:00
Patrik Oldsberg fcfac818c8 package.json: add script for running snyk tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-23 12:11:47 +01:00
Patrik Oldsberg b922d3be1b yarn.lock: bump rollup-plugin-postcss
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-23 12:10:37 +01:00
Mike Lewis 03962638a0 create-app: fix formatting in search.ts
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-23 11:10:29 +00:00
Patrik Oldsberg 5573149d3a Merge pull request #8206 from backstage/rugvip/app-theme
docs/deprecations: add note about working around AppTheme type
2021-11-23 11:39:36 +01:00
Fredrik Adelöw 0eee3d98b9 Merge pull request #8117 from cbjjensen/add-headers
Letting GraphiQL use headers
2021-11-23 11:11:59 +01:00
Fredrik Adelöw a6b5becf0f Merge pull request #8202 from backstage/freben/bump-rjsf
bump rjsf
2021-11-23 11:11:13 +01:00
Patrik Oldsberg 7e4a1ea4cb docs/deprecations: add note about working around AppTheme type
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-23 10:05:07 +01:00
blam c9ddb070c2 chore: fixing changeset formatting
Signed-off-by: blam <ben@blam.sh>
2021-11-23 09:42:08 +01:00
Joon Park 740f958290 Handle empty values array in EntityFilter
While an empty values array is not really a sensible input, if an empty array is provided, technically nothing should be returned as a matching value, thus the existing behavior was technically a bug.

Signed-off-by: Joon Park <joonp@spotify.com>
2021-11-22 21:07:55 +00:00
Fredrik Adelöw e74daa5893 Merge pull request #8199 from timja/patch-1
Fix broken ssl postgres docs
2021-11-22 20:20:54 +01:00
Fredrik Adelöw 2d7d165737 bump rjsf
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-11-22 19:59:52 +01:00
Mike Lewis 839e931d34 create-app: pass tokenManager when constructing TechDocsCollator
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 18:44:49 +00:00
Mike Lewis 14a6c46dff Merge remote-tracking branch 'origin/master' into natasha/b2b-auth
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 18:22:57 +00:00
Patrik Oldsberg 8a96019a39 Merge branch 'master' into rugvip/test-port 2021-11-22 17:33:10 +01:00
Tim Jacomb 52d3ca287e Fix broken ssl postgres docs
Signed-off-by: Tim Jacomb <tim.jacomb@hmcts.net>
2021-11-22 16:30:51 +00:00
Patrik Oldsberg 9f9ff42e28 Merge pull request #8193 from backstage/mod/auth-responses
auth-backend: use more standardized error responses
2021-11-22 17:28:52 +01:00
Mike Lewis 5bff67aac4 permission-node: expose ApplyConditionsResponse type
This type will be shared with the backend.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:36 +00:00
Mike Lewis 3254303a96 permission-node: refactor and split createPermissionIntegration
This refactor makes the createPermissionIntegration system much more
flexible by splitting it up into a few different helpers with different
responsibilities. This frees up plugin authors to connect together the
different parts of the permission integration in whatever way is
convenient for them, and makes the process of registering additional
permission rules a bit more explicit, by requiring them to be passed
in when constructing the systems for transforming or applying
conditions.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
Co-authored-by: Joon Park <joonp@spotify.com>
Co-authored-by: Tim Hansen <timbonicus@gmail.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 70ce7c91e2 permission-node: bump @backstage/cli version
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 0eb339c3a4 permission-node: more visible condition transform in mapCriteria test
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Tim Hansen 27d5f5fed3 Improve api-report
Signed-off-by: Tim Hansen <timbonicus@gmail.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 5c5a1d16e4 authz: remove superfluous union type
PermissionCriteria<TQuery> is a union type which already includes
TQuery itself, so we don't need a second union here.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 75dd00c8b6 authz: add missing fields to permission-node package.json
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis e2088541dd authz: update references to permission-common after move to plugins
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis f72d7bba0e authz: add testsuite for createPermissionIntegration
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 5c75c89106 authz: improve error handling in permission-node apply-conditions route
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 2b668f2eb8 build(deps): add dependency on zod in permission-node
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 22f5de9840 authz: update createPermissionIntegration to work with new PermissionCriteria type
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis d0a99e3219 authz: update permission-node api-report
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 64b6ff368f authz: fix expected response type for /apply-conditions route
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis 652af0834a authz: add test suite for conditionFor
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis f3d2ccfeb8 authz: switch to unknown[] in PermissionRule type parameter
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis 4083fcdb5e authz: fix PermissionCondition type parameter
`unknown` doesn't satisfy the (recently added) `extends unknown[]`
constraint. In these two cases, we can remove the parameter entirely and
rely instead on the default of `unknown[]`.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis a82709c38f authz: update unused type params in conditionFor to unknown
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Tim Hansen a1e2972dda Add permission-node package
Signed-off-by: Tim Hansen <timbonicus@gmail.com>
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>
Co-authored-by: Joe Porpeglia <joeporpeglia@users.noreply.github.com>
Co-authored-by: Vincenzo Scamporlino <vinzscam@users.noreply.github.com>
2021-11-22 15:37:32 +00:00